| Message ID | 20160912221631.15812-8-paul.gortmaker@windriver.com |
|---|---|
| State | New |
| Headers | show |
On Tue, Sep 13, 2016 at 12:16 AM, Paul Gortmaker <paul.gortmaker@windriver.com> wrote: > The Kconfig for this file is: > > drivers/gpio/Kconfig:config GPIO_WHISKEY_COVE > drivers/gpio/Kconfig: tristate "GPIO support for Whiskey Cove PMIC" > > ...but however it does not include module.h -- it in turn gets it from > another header (gpio/driver.h) and we'd like to replace that with a > forward delcaration of "struct module;" but if we do, this file will > fail to compile. > > So we fix this first to avoid putting build failures into the bisect > commit history. > > Cc: Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com> > Cc: Bin Gao <bin.gao@intel.com> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> > Cc: Mika Westerberg <mika.westerberg@linux.intel.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c index e11d6a3fb641..d0ddba7a9d08 100644 --- a/drivers/gpio/gpio-wcove.c +++ b/drivers/gpio/gpio-wcove.c @@ -16,6 +16,7 @@ */ #include <linux/bitops.h> +#include <linux/module.h> #include <linux/interrupt.h> #include <linux/gpio/driver.h> #include <linux/mfd/intel_soc_pmic.h>
The Kconfig for this file is: drivers/gpio/Kconfig:config GPIO_WHISKEY_COVE drivers/gpio/Kconfig: tristate "GPIO support for Whiskey Cove PMIC" ...but however it does not include module.h -- it in turn gets it from another header (gpio/driver.h) and we'd like to replace that with a forward delcaration of "struct module;" but if we do, this file will fail to compile. So we fix this first to avoid putting build failures into the bisect commit history. Cc: Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com> Cc: Bin Gao <bin.gao@intel.com> Cc: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Mika Westerberg <mika.westerberg@linux.intel.com> Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Alexandre Courbot <gnurou@gmail.com> Cc: linux-gpio@vger.kernel.org Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- drivers/gpio/gpio-wcove.c | 1 + 1 file changed, 1 insertion(+)