Patchwork powerpc/4xx: Add GPIO, SPI and MMC suport to the Arches

login
register
mail settings
Submitter Stefan Roese
Date Oct. 31, 2008, 11:11 a.m.
Message ID <1225451506-24727-1-git-send-email-sr@denx.de>
Download mbox | patch
Permalink /patch/6687/
State Changes Requested
Delegated to: Josh Boyer
Headers show

Comments

Stefan Roese - Oct. 31, 2008, 11:11 a.m.
This patch adds GPIO, SPI & MMC (for onboard uSD) support to the
Arches dts

Signed-off-by: Stefan Roese <sr@denx.de>
---
 arch/powerpc/boot/dts/arches.dts |   32 ++++++++++++++++++++++++++++++++
 1 files changed, 32 insertions(+), 0 deletions(-)
Anton Vorontsov - Oct. 31, 2008, 12:21 p.m.
Hi Stefan,

On Fri, Oct 31, 2008 at 12:11:46PM +0100, Stefan Roese wrote:
> This patch adds GPIO, SPI & MMC (for onboard uSD) support to the
> Arches dts
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  arch/powerpc/boot/dts/arches.dts |   32 ++++++++++++++++++++++++++++++++
>  1 files changed, 32 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/arches.dts b/arch/powerpc/boot/dts/arches.dts
> index d9113b1..c568095 100644
> --- a/arch/powerpc/boot/dts/arches.dts
> +++ b/arch/powerpc/boot/dts/arches.dts
> @@ -195,6 +195,38 @@
>  				interrupts = <0x3 0x4>;
>  			};
>  
> +			SPI0: spi@ef600900 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				device_type = "spi";

device_type isn't needed.

> +				compatible = "ibm,spi-460gt", "ibm,ppc4xx-spi";
> +				reg = <0xef600900 7>;
> +				interrupt-parent = <&UIC1>;
> +				interrupts = <2 4>;
> +
> +				/* gpio(s) representing chip select(s) */
> +				gpios = <&GPIO1 11 0>;
> +
> +				mmc-slot@0 {
> +					compatible = "linux,mmc-spi", "mmc-spi";

According to new (though still not approved) bindings, this should
be "<board-specific>-mmc-slot", "mmc-spi-slot".

> +					reg = <0>;
> +					spi-max-frequency = <10000000>;
> +					voltage-range = <3300 3300>;

For new bindings I changed this to "voltage-ranges", so that we
could specify discontinuous range.

> +				};
> +			};
> +
> +			GPIO0: gpio@ef600b00 {
> +				#gpio-cells = <2>;
> +				compatible = "ibm,460gt-gpio","ibm,ppc4xx-gpio";
> +				reg = <0xef600b00 38>;
> +			};
> +
> +			GPIO1: gpio@ef600c00 {
> +				#gpio-cells = <2>;
> +				compatible = "ibm,460gt-gpio","ibm,ppc4xx-gpio";
> +				reg = <0xef600c00 38>;
> +			};
> +
>  			TAH0: emac-tah@ef601350 {
>  				compatible = "ibm,tah-460gt", "ibm,tah";
>  				reg = <0xef601350 0x00000030>;
> -- 
> 1.6.0.3
Stefan Roese - Oct. 31, 2008, 2:31 p.m.
Hi Anton,

thanks for your comments.

On Friday 31 October 2008, Anton Vorontsov wrote:
> > diff --git a/arch/powerpc/boot/dts/arches.dts
> > b/arch/powerpc/boot/dts/arches.dts index d9113b1..c568095 100644
> > --- a/arch/powerpc/boot/dts/arches.dts
> > +++ b/arch/powerpc/boot/dts/arches.dts
> > @@ -195,6 +195,38 @@
> >  				interrupts = <0x3 0x4>;
> >  			};
> >
> > +			SPI0: spi@ef600900 {
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +				device_type = "spi";
>
> device_type isn't needed.

OK, will remove.

> > +				compatible = "ibm,spi-460gt", "ibm,ppc4xx-spi";
> > +				reg = <0xef600900 7>;
> > +				interrupt-parent = <&UIC1>;
> > +				interrupts = <2 4>;
> > +
> > +				/* gpio(s) representing chip select(s) */
> > +				gpios = <&GPIO1 11 0>;
> > +
> > +				mmc-slot@0 {
> > +					compatible = "linux,mmc-spi", "mmc-spi";
>
> According to new (though still not approved) bindings, this should
> be "<board-specific>-mmc-slot", "mmc-spi-slot".

So I will wait a while with re-sending until this is "approved".

> > +					reg = <0>;
> > +					spi-max-frequency = <10000000>;
> > +					voltage-range = <3300 3300>;
>
> For new bindings I changed this to "voltage-ranges", so that we
> could specify discontinuous range.

OK, will change in next version.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de
=====================================================================

Patch

diff --git a/arch/powerpc/boot/dts/arches.dts b/arch/powerpc/boot/dts/arches.dts
index d9113b1..c568095 100644
--- a/arch/powerpc/boot/dts/arches.dts
+++ b/arch/powerpc/boot/dts/arches.dts
@@ -195,6 +195,38 @@ 
 				interrupts = <0x3 0x4>;
 			};
 
+			SPI0: spi@ef600900 {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				device_type = "spi";
+				compatible = "ibm,spi-460gt", "ibm,ppc4xx-spi";
+				reg = <0xef600900 7>;
+				interrupt-parent = <&UIC1>;
+				interrupts = <2 4>;
+
+				/* gpio(s) representing chip select(s) */
+				gpios = <&GPIO1 11 0>;
+
+				mmc-slot@0 {
+					compatible = "linux,mmc-spi", "mmc-spi";
+					reg = <0>;
+					spi-max-frequency = <10000000>;
+					voltage-range = <3300 3300>;
+				};
+			};
+
+			GPIO0: gpio@ef600b00 {
+				#gpio-cells = <2>;
+				compatible = "ibm,460gt-gpio","ibm,ppc4xx-gpio";
+				reg = <0xef600b00 38>;
+			};
+
+			GPIO1: gpio@ef600c00 {
+				#gpio-cells = <2>;
+				compatible = "ibm,460gt-gpio","ibm,ppc4xx-gpio";
+				reg = <0xef600c00 38>;
+			};
+
 			TAH0: emac-tah@ef601350 {
 				compatible = "ibm,tah-460gt", "ibm,tah";
 				reg = <0xef601350 0x00000030>;