| Message ID | ydd37l5y21b.fsf@CeBiTec.Uni-Bielefeld.DE |
|---|---|
| State | New |
| Headers | show |
On Mon, Sep 12, 2016 at 1:07 AM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote: > The libgo syscall test has been failing on Solaris for quite some time: > > exec_unix_test.go:174:19: error: reference to undefined identifier 'syscall.Ioctl' > errno := syscall.Ioctl(tty.Fd(), syscall.TIOCGPGRP, uintptr(unsafe.Pointer(&fpgrp))) > ^ > exec_unix_test.go:209:18: error: reference to undefined identifier 'syscall.Ioctl' > errno = syscall.Ioctl(tty.Fd(), syscall.TIOCSPGRP, uintptr(unsafe.Pointer(&fpgrp))) > ^ > FAIL: syscall > > The following patch fixes it, tested across the whole {i386-pc, > sparc-sun}-solaris2.1[012] range. Thanks. Committed to mainline. Ian
diff --git a/libgo/go/syscall/export_unix_test.go b/libgo/go/syscall/export_unix_test.go --- a/libgo/go/syscall/export_unix_test.go +++ b/libgo/go/syscall/export_unix_test.go @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. -// +build darwin dragonfly freebsd linux netbsd openbsd +// +build darwin dragonfly freebsd linux netbsd openbsd solaris package syscall
The libgo syscall test has been failing on Solaris for quite some time: exec_unix_test.go:174:19: error: reference to undefined identifier 'syscall.Ioctl' errno := syscall.Ioctl(tty.Fd(), syscall.TIOCGPGRP, uintptr(unsafe.Pointer(&fpgrp))) ^ exec_unix_test.go:209:18: error: reference to undefined identifier 'syscall.Ioctl' errno = syscall.Ioctl(tty.Fd(), syscall.TIOCSPGRP, uintptr(unsafe.Pointer(&fpgrp))) ^ FAIL: syscall The following patch fixes it, tested across the whole {i386-pc, sparc-sun}-solaris2.1[012] range. Rainer