From patchwork Tue Oct  5 13:28:51 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [2/4] trace: Don't strip lines containing '#' arbitrarily
Date: Tue, 05 Oct 2010 03:28:51 -0000
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
X-Patchwork-Id: 66846
Message-Id: <1286285333-21003-2-git-send-email-stefanha@linux.vnet.ibm.com>
To: <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>,
 Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
 Prerna Saxena <prerna@linux.vnet.ibm.com>

Although comment lines must be skipped, the '#' character can occur in
valid format strings.  Be more careful when checking for comments.
Leave comments at the end of the line where they will not interfere with
other processing.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

---
tracetool |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/tracetool b/tracetool
index 534cc70..63e3e29 100755
--- a/tracetool
+++ b/tracetool
@@ -318,8 +318,7 @@ convert()
 
     while read -r str; do
         # Skip comments and empty lines
-        str=${str%%#*}
-        test -z "$str" && continue
+        test -z "${str%%#*}" && continue
 
         # Process the line.  The nop backend handles disabled lines.
         disable=${str%%disable *}