From patchwork Tue Oct 5 13:28:53 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 66843 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E8833B70A6 for ; Wed, 6 Oct 2010 03:38:16 +1100 (EST) Received: from localhost ([127.0.0.1]:50582 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P3AWs-0001M6-75 for incoming@patchwork.ozlabs.org; Tue, 05 Oct 2010 12:38:14 -0400 Received: from [140.186.70.92] (port=33497 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P3AWB-0001Ks-AF for qemu-devel@nongnu.org; Tue, 05 Oct 2010 12:37:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P3AW8-0008Ia-CR for qemu-devel@nongnu.org; Tue, 05 Oct 2010 12:37:31 -0400 Received: from mtagate6.de.ibm.com ([195.212.17.166]:53024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P3AW8-0008IC-4q for qemu-devel@nongnu.org; Tue, 05 Oct 2010 12:37:28 -0400 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.1/8.13.1) with ESMTP id o95DT36v005663 for ; Tue, 5 Oct 2010 13:29:03 GMT Received: from d12av04.megacenter.de.ibm.com (d12av04.megacenter.de.ibm.com [9.149.165.229]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o95DT1De3887188 for ; Tue, 5 Oct 2010 15:29:02 +0200 Received: from d12av04.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o95DT1as019936 for ; Tue, 5 Oct 2010 15:29:01 +0200 Received: from stefan-thinkpad.ibm.com (sig-9-145-201-78.de.ibm.com [9.145.201.78]) by d12av04.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id o95DSxxX019881; Tue, 5 Oct 2010 15:29:00 +0200 From: Stefan Hajnoczi To: Date: Tue, 5 Oct 2010 14:28:53 +0100 Message-Id: <1286285333-21003-4-git-send-email-stefanha@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1286285333-21003-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1286285333-21003-1-git-send-email-stefanha@linux.vnet.ibm.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Cc: Blue Swirl , Stefan Hajnoczi , Prerna Saxena Subject: [Qemu-devel] [PATCH 4/4] trace: Trace bdrv_aio_{readv,writev} X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Observing block layer aio readv/writev operations is useful for debugging image formats or understanding guest disk I/O patterns. Signed-off-by: Stefan Hajnoczi --- block.c | 4 ++++ trace-events | 2 ++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index ebbc376..a19374d 100644 --- a/block.c +++ b/block.c @@ -1983,6 +1983,8 @@ BlockDriverAIOCB *bdrv_aio_readv(BlockDriverState *bs, int64_t sector_num, BlockDriver *drv = bs->drv; BlockDriverAIOCB *ret; + trace_bdrv_aio_readv(bs, sector_num, nb_sectors, opaque); + if (!drv) return NULL; if (bdrv_check_request(bs, sector_num, nb_sectors)) @@ -2007,6 +2009,8 @@ BlockDriverAIOCB *bdrv_aio_writev(BlockDriverState *bs, int64_t sector_num, BlockDriver *drv = bs->drv; BlockDriverAIOCB *ret; + trace_bdrv_aio_writev(bs, sector_num, nb_sectors, opaque); + if (!drv) return NULL; if (bs->read_only) diff --git a/trace-events b/trace-events index b43317e..4300178 100644 --- a/trace-events +++ b/trace-events @@ -51,6 +51,8 @@ disable multiwrite_cb(void *mcb, int ret) "mcb %p ret %d" disable bdrv_aio_multiwrite(void *mcb, int num_callbacks, int num_reqs) "mcb %p num_callbacks %d num_reqs %d" disable bdrv_aio_multiwrite_earlyfail(void *mcb) "mcb %p" disable bdrv_aio_multiwrite_latefail(void *mcb, int i) "mcb %p i %d" +disable bdrv_aio_readv(void *bs, int64_t sector_num, int nb_sectors, void *opaque) "bs %p sector_num %"PRId64" nb_sectors %d opaque %p" +disable bdrv_aio_writev(void *bs, int64_t sector_num, int nb_sectors, void *opaque) "bs %p sector_num %"PRId64" nb_sectors %d opaque %p" # hw/virtio-blk.c disable virtio_blk_req_complete(void *req, int status) "req %p status %d"