Patchwork [testsuite] cmpsi-2 test was broken

login
register
mail settings
Submitter Hariharan Sandanagobalane
Date Oct. 5, 2010, 3:25 p.m.
Message ID <4CAB435C.8020700@picochip.com>
Download mbox | patch
Permalink /patch/66837/
State New
Headers show

Comments

Hariharan Sandanagobalane - Oct. 5, 2010, 3:25 p.m.
Hello all,
Is it alright to commit the following patch to fix the broken cmpsi-2 test?

Cheers
Hari

ChangeLog:
gcc.c-torture/execute/cmpsi-2.c : Unsigned comparisons should use 
unsigned values.

Patch:
Michael Eager - Oct. 5, 2010, 7:35 p.m.
Hariharan Sandanagobalane wrote:
> Hello all,
> Is it alright to commit the following patch to fix the broken cmpsi-2 test?

yes, thanks!

> 
> Cheers
> Hari
> 
> ChangeLog:
> gcc.c-torture/execute/cmpsi-2.c : Unsigned comparisons should use 
> unsigned values.
> 
> Patch:
> 
> Index: gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c
> ===================================================================
> --- gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c       (revision 164991)
> +++ gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c       (working copy)
> @@ -49,7 +49,7 @@
>      return F;
>  }
> 
> -fltu (long x, long y)
> +fltu (unsigned long x, unsigned long y)
>  {
>    if (x < y)
>      return T;
> @@ -57,7 +57,7 @@
>      return F;
>  }
> 
> -fgeu (long x, long y)
> +fgeu (unsigned long x, unsigned long y)
>  {
>    if (x >= y)
>      return T;
> @@ -65,7 +65,7 @@
>      return F;
>  }
> 
> -fgtu (long x, long y)
> +fgtu (unsigned long x, unsigned long y)
>  {
>    if (x > y)
>      return T;
> @@ -73,7 +73,7 @@
>      return F;
>  }
> 
> -fleu (long x, long y)
> +fleu (unsigned long x, unsigned long y)
>  {
>    if (x <= y)
>      return T;
>
Hariharan Sandanagobalane - Oct. 6, 2010, 8:59 a.m.
Committed as r165016.

Cheers
Hari

On 05/10/10 20:35, Michael Eager wrote:
> Hariharan Sandanagobalane wrote:
>> Hello all,
>> Is it alright to commit the following patch to fix the broken cmpsi-2 test?
>
> yes, thanks!
>
>>
>> Cheers
>> Hari
>>
>> ChangeLog:
>> gcc.c-torture/execute/cmpsi-2.c : Unsigned comparisons should use
>> unsigned values.
>>
>> Patch:
>>
>> Index: gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c
>> ===================================================================
>> --- gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c       (revision 164991)
>> +++ gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c       (working copy)
>> @@ -49,7 +49,7 @@
>>       return F;
>>   }
>>
>> -fltu (long x, long y)
>> +fltu (unsigned long x, unsigned long y)
>>   {
>>     if (x<  y)
>>       return T;
>> @@ -57,7 +57,7 @@
>>       return F;
>>   }
>>
>> -fgeu (long x, long y)
>> +fgeu (unsigned long x, unsigned long y)
>>   {
>>     if (x>= y)
>>       return T;
>> @@ -65,7 +65,7 @@
>>       return F;
>>   }
>>
>> -fgtu (long x, long y)
>> +fgtu (unsigned long x, unsigned long y)
>>   {
>>     if (x>  y)
>>       return T;
>> @@ -73,7 +73,7 @@
>>       return F;
>>   }
>>
>> -fleu (long x, long y)
>> +fleu (unsigned long x, unsigned long y)
>>   {
>>     if (x<= y)
>>       return T;
>>
>
>

Patch

Index: gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c
===================================================================
--- gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c       (revision 164991)
+++ gcc/testsuite/gcc.c-torture/execute/cmpsi-2.c       (working copy)
@@ -49,7 +49,7 @@ 
      return F;
  }

-fltu (long x, long y)
+fltu (unsigned long x, unsigned long y)
  {
    if (x < y)
      return T;
@@ -57,7 +57,7 @@ 
      return F;
  }

-fgeu (long x, long y)
+fgeu (unsigned long x, unsigned long y)
  {
    if (x >= y)
      return T;
@@ -65,7 +65,7 @@ 
      return F;
  }

-fgtu (long x, long y)
+fgtu (unsigned long x, unsigned long y)
  {
    if (x > y)
      return T;
@@ -73,7 +73,7 @@ 
      return F;
  }

-fleu (long x, long y)
+fleu (unsigned long x, unsigned long y)
  {
    if (x <= y)
      return T;