| Message ID | 1473474049-1854-1-git-send-email-marcel.ziswiler@toradex.com |
|---|---|
| State | Accepted |
| Commit | 7f753cbea4c7cb56f278982c987570e6575d3dd7 |
| Delegated to: | Marek Vasut |
| Headers | show |
Hi Marcel, On Fri, Sep 9, 2016 at 9:20 PM, Marcel Ziswiler <marcel.ziswiler@toradex.com> wrote: > Since commit aa7a648747d8c704a9a81c9e493d386930724e9d > ("net: Stop including NFS overhead in defragment max") the following > has been reproducibly observed while trying to transfer data over TFTP: > > Load address: 0x80408000 > Loading: EHCI timed out on TD - token=0x8008d80 > T EHCI timed out on TD - token=0x88008d80 > Rx: failed to receive: -5 > > This patch fixes this by upping our maximal de-fragmentation aka IP > packet size again. > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > --- > > include/configs/colibri_t30.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/colibri_t30.h b/include/configs/colibri_t30.h > index fbb235d..3431cde 100644 > --- a/include/configs/colibri_t30.h > +++ b/include/configs/colibri_t30.h > @@ -48,6 +48,7 @@ > > /* General networking support */ > #define CONFIG_IP_DEFRAG > +#define CONFIG_NET_MAXDEFRAG (16384 + 4096 + 24) I suspect this is more than you need, right? You are using TFTP, not NFS. You probably only need an extra 34 bytes. > #define CONFIG_TFTP_BLOCKSIZE 16384 You could also just reduce this by 34 bytes. > #define CONFIG_TFTP_TSIZE > > -- > 2.5.5 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot
On 09/10/2016 04:20 AM, Marcel Ziswiler wrote: > Since commit aa7a648747d8c704a9a81c9e493d386930724e9d > ("net: Stop including NFS overhead in defragment max") the following > has been reproducibly observed while trying to transfer data over TFTP: > > Load address: 0x80408000 > Loading: EHCI timed out on TD - token=0x8008d80 > T EHCI timed out on TD - token=0x88008d80 > Rx: failed to receive: -5 > > This patch fixes this by upping our maximal de-fragmentation aka IP > packet size again. > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > --- > > include/configs/colibri_t30.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/colibri_t30.h b/include/configs/colibri_t30.h > index fbb235d..3431cde 100644 > --- a/include/configs/colibri_t30.h > +++ b/include/configs/colibri_t30.h > @@ -48,6 +48,7 @@ > > /* General networking support */ > #define CONFIG_IP_DEFRAG > +#define CONFIG_NET_MAXDEFRAG (16384 + 4096 + 24) > #define CONFIG_TFTP_BLOCKSIZE 16384 > #define CONFIG_TFTP_TSIZE > > Applied, thanks . If you need to rectify this further based on Joe's feedback, please do, but I want this fixed before the release.
On Sat, 2016-09-10 at 18:51 +0200, Marek Vasut wrote: > On 09/10/2016 04:20 AM, Marcel Ziswiler wrote: > > > > Since commit aa7a648747d8c704a9a81c9e493d386930724e9d > > ("net: Stop including NFS overhead in defragment max") the > > following > > has been reproducibly observed while trying to transfer data over > > TFTP: > > > > Load address: 0x80408000 > > Loading: EHCI timed out on TD - token=0x8008d80 > > T EHCI timed out on TD - token=0x88008d80 > > Rx: failed to receive: -5 > > > > This patch fixes this by upping our maximal de-fragmentation aka IP > > packet size again. > > > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > > > > --- > > > > include/configs/colibri_t30.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/configs/colibri_t30.h > > b/include/configs/colibri_t30.h > > index fbb235d..3431cde 100644 > > --- a/include/configs/colibri_t30.h > > +++ b/include/configs/colibri_t30.h > > @@ -48,6 +48,7 @@ > > > > /* General networking support */ > > #define CONFIG_IP_DEFRAG > > +#define CONFIG_NET_MAXDEFRAG (16384 + 4096 + 24) > > #define CONFIG_TFTP_BLOCKSIZE 16384 > > #define CONFIG_TFTP_TSIZE > > > > > Applied, thanks . If you need to rectify this further based on Joe's > feedback, please do, but I want this fixed before the release. Unfortunately the release already happened. Nevertheless I will send an updated version 2 ASAP which fixes all of our boards currently exhibiting this issue the way Joe suggested.
On 09/14/2016 04:36 PM, Marcel Ziswiler wrote: > On Sat, 2016-09-10 at 18:51 +0200, Marek Vasut wrote: >> On 09/10/2016 04:20 AM, Marcel Ziswiler wrote: >>> >>> Since commit aa7a648747d8c704a9a81c9e493d386930724e9d >>> ("net: Stop including NFS overhead in defragment max") the >>> following >>> has been reproducibly observed while trying to transfer data over >>> TFTP: >>> >>> Load address: 0x80408000 >>> Loading: EHCI timed out on TD - token=0x8008d80 >>> T EHCI timed out on TD - token=0x88008d80 >>> Rx: failed to receive: -5 >>> >>> This patch fixes this by upping our maximal de-fragmentation aka IP >>> packet size again. >>> >>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> >>> >>> --- >>> >>> include/configs/colibri_t30.h | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/include/configs/colibri_t30.h >>> b/include/configs/colibri_t30.h >>> index fbb235d..3431cde 100644 >>> --- a/include/configs/colibri_t30.h >>> +++ b/include/configs/colibri_t30.h >>> @@ -48,6 +48,7 @@ >>> >>> /* General networking support */ >>> #define CONFIG_IP_DEFRAG >>> +#define CONFIG_NET_MAXDEFRAG (16384 + 4096 + 24) >>> #define CONFIG_TFTP_BLOCKSIZE 16384 >>> #define CONFIG_TFTP_TSIZE >>> >>> >> Applied, thanks . If you need to rectify this further based on Joe's >> feedback, please do, but I want this fixed before the release. > > Unfortunately the release already happened. Nevertheless I will send an > updated version 2 ASAP which fixes all of our boards currently > exhibiting this issue the way Joe suggested. > Please base that on top of u-boot-usb/master , I already applied V1 . Me and Tom agreed this is not critical enough to wrap it into release.
diff --git a/include/configs/colibri_t30.h b/include/configs/colibri_t30.h index fbb235d..3431cde 100644 --- a/include/configs/colibri_t30.h +++ b/include/configs/colibri_t30.h @@ -48,6 +48,7 @@ /* General networking support */ #define CONFIG_IP_DEFRAG +#define CONFIG_NET_MAXDEFRAG (16384 + 4096 + 24) #define CONFIG_TFTP_BLOCKSIZE 16384 #define CONFIG_TFTP_TSIZE
Since commit aa7a648747d8c704a9a81c9e493d386930724e9d ("net: Stop including NFS overhead in defragment max") the following has been reproducibly observed while trying to transfer data over TFTP: Load address: 0x80408000 Loading: EHCI timed out on TD - token=0x8008d80 T EHCI timed out on TD - token=0x88008d80 Rx: failed to receive: -5 This patch fixes this by upping our maximal de-fragmentation aka IP packet size again. Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> --- include/configs/colibri_t30.h | 1 + 1 file changed, 1 insertion(+)