| Message ID | b1f730436465e511edb56e4486299e4f3835599b.1473428548.git.dcaratti@redhat.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
On Fri, Sep 09, 2016 at 04:02:22PM +0200, Davide Caratti wrote: > the maximum possible ICV length in a MACsec frame is 16 octects, not 32: > fix get_icvlen() accordingly, so that a proper error message is displayed > in case input 'icvlen' is greater than 16. > > Signed-off-by: Davide Caratti <dcaratti@redhat.com> Acked-by: Phil Sutter <phil@nwl.cc>
2016-09-09, 16:02:22 +0200, Davide Caratti wrote: > the maximum possible ICV length in a MACsec frame is 16 octects, not 32: > fix get_icvlen() accordingly, so that a proper error message is displayed > in case input 'icvlen' is greater than 16. > > Signed-off-by: Davide Caratti <dcaratti@redhat.com> Acked-by: Sabrina Dubroca <sd@queasysnail.net>
On Fri, 9 Sep 2016 16:02:22 +0200 Davide Caratti <dcaratti@redhat.com> wrote: > the maximum possible ICV length in a MACsec frame is 16 octects, not 32: > fix get_icvlen() accordingly, so that a proper error message is displayed > in case input 'icvlen' is greater than 16. > > Signed-off-by: Davide Caratti <dcaratti@redhat.com> Applied
diff --git a/ip/ipmacsec.c b/ip/ipmacsec.c index 2e670e9..127fa1e 100644 --- a/ip/ipmacsec.c +++ b/ip/ipmacsec.c @@ -152,9 +152,9 @@ static void get_icvlen(__u8 *icvlen, char *arg) if (ret) invarg("expected ICV length", arg); - if (*icvlen < MACSEC_MIN_ICV_LEN || *icvlen > MACSEC_MAX_ICV_LEN) + if (*icvlen < MACSEC_MIN_ICV_LEN || *icvlen > MACSEC_STD_ICV_LEN) invarg("ICV length must be in the range {" - STR(MACSEC_MIN_ICV_LEN) ".." STR(MACSEC_MAX_ICV_LEN) + STR(MACSEC_MIN_ICV_LEN) ".." STR(MACSEC_STD_ICV_LEN) "}", arg); }
the maximum possible ICV length in a MACsec frame is 16 octects, not 32: fix get_icvlen() accordingly, so that a proper error message is displayed in case input 'icvlen' is greater than 16. Signed-off-by: Davide Caratti <dcaratti@redhat.com> --- ip/ipmacsec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)