| Message ID | 20081031074143.25532.6078.stgit@gitlost.lost |
|---|---|
| State | Rejected, archived |
| Delegated to: | Jeff Garzik |
| Headers | show |
Jeff Kirsher wrote: > The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous, so this > patch adds a description to the kconfig option. > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > CC: Andrew Gallatin <gallatin@myri.com> > --- > > drivers/net/Kconfig | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig > index f749b40..b13a7ff 100644 > --- a/drivers/net/Kconfig > +++ b/drivers/net/Kconfig > @@ -2437,7 +2437,7 @@ config IXGBE > will be called ixgbe. > > config IXGBE_DCA > - bool > + bool "Enable DCA" > default y > depends on IXGBE && DCA && !(IXGBE=y && DCA=m) > > @@ -2489,7 +2489,7 @@ config MYRI10GE > will be called myri10ge. > > config MYRI10GE_DCA > - bool > + bool "Enable DCA" > default y > depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m) If you're gonna do that, please add useful help text for the user who has no idea what this means. (IGB_DCA needs this as well) Jeff -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index f749b40..b13a7ff 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -2437,7 +2437,7 @@ config IXGBE will be called ixgbe. config IXGBE_DCA - bool + bool "Enable DCA" default y depends on IXGBE && DCA && !(IXGBE=y && DCA=m) @@ -2489,7 +2489,7 @@ config MYRI10GE will be called myri10ge. config MYRI10GE_DCA - bool + bool "Enable DCA" default y depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m)
The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous, so this patch adds a description to the kconfig option. Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> CC: Andrew Gallatin <gallatin@myri.com> --- drivers/net/Kconfig | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html