Patchwork [net-next] ipv6: make __ipv6_isatap_ifid static

login
register
mail settings
Submitter stephen hemminger
Date Oct. 5, 2010, 6:17 a.m.
Message ID <20101005151753.363121b8@s6510>
Download mbox | patch
Permalink /patch/66754/
State Accepted
Delegated to: David Miller
Headers show

Comments

stephen hemminger - Oct. 5, 2010, 6:17 a.m.
Another exported symbol only used in one file

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

---
 include/net/addrconf.h |    2 --
 net/ipv6/addrconf.c    |    3 +--
 2 files changed, 1 insertion(+), 4 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eric Dumazet - Oct. 5, 2010, 6:25 a.m.
Le mardi 05 octobre 2010 à 15:17 +0900, Stephen Hemminger a écrit :
> Another exported symbol only used in one file
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 5, 2010, 7:49 a.m.
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 5 Oct 2010 15:17:53 +0900

> Another exported symbol only used in one file
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/include/net/addrconf.h	2010-10-02 09:04:22.700929104 +0900
+++ b/include/net/addrconf.h	2010-10-02 09:11:00.651004530 +0900
@@ -276,8 +276,6 @@  static inline int ipv6_addr_is_ll_all_ro
 		(addr->s6_addr32[3] ^ htonl(0x00000002))) == 0;
 }
 
-extern int __ipv6_isatap_ifid(u8 *eui, __be32 addr);
-
 static inline int ipv6_addr_is_isatap(const struct in6_addr *addr)
 {
 	return (addr->s6_addr32[2] | htonl(0x02000000)) == htonl(0x02005EFE);
--- a/net/ipv6/addrconf.c	2010-10-02 09:04:22.720901336 +0900
+++ b/net/ipv6/addrconf.c	2010-10-02 09:05:09.031021195 +0900
@@ -1544,7 +1544,7 @@  static int addrconf_ifid_infiniband(u8 *
 	return 0;
 }
 
-int __ipv6_isatap_ifid(u8 *eui, __be32 addr)
+static int __ipv6_isatap_ifid(u8 *eui, __be32 addr)
 {
 	if (addr == 0)
 		return -1;
@@ -1560,7 +1560,6 @@  int __ipv6_isatap_ifid(u8 *eui, __be32 a
 	memcpy(eui + 4, &addr, 4);
 	return 0;
 }
-EXPORT_SYMBOL(__ipv6_isatap_ifid);
 
 static int addrconf_ifid_sit(u8 *eui, struct net_device *dev)
 {