From patchwork Tue Oct 5 06:14:17 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: stephen hemminger X-Patchwork-Id: 66753 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9A1F8B6EFF for ; Tue, 5 Oct 2010 17:14:27 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757507Ab0JEGOX (ORCPT ); Tue, 5 Oct 2010 02:14:23 -0400 Received: from mail.vyatta.com ([76.74.103.46]:47697 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754548Ab0JEGOW (ORCPT ); Tue, 5 Oct 2010 02:14:22 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.vyatta.com (Postfix) with ESMTP id 141181829017; Mon, 4 Oct 2010 23:07:36 -0700 (PDT) X-Virus-Scanned: amavisd-new at tahiti.vyatta.com Received: from mail.vyatta.com ([127.0.0.1]) by localhost (mail.vyatta.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9W+cl+vRqzDT; Mon, 4 Oct 2010 23:07:35 -0700 (PDT) Received: from s6510 (p26041-ipngn201yosida.nagano.ocn.ne.jp [180.3.95.41]) by mail.vyatta.com (Postfix) with ESMTPSA id 01E5F1829009; Mon, 4 Oct 2010 23:07:34 -0700 (PDT) Date: Tue, 5 Oct 2010 15:14:17 +0900 From: Stephen Hemminger To: David Miller Cc: netdev@vger.kernel.org Subject: [PATCH net-next] fib: fib_rules_cleanup can be static Message-ID: <20101005151417.57eae0b0@s6510> Organization: Vyatta X-Mailer: Claws Mail 3.7.5 (GTK+ 2.20.1; i486-pc-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org fib_rules_cleanup_ups is only defined and used in one place. Signed-off-by: Stephen Hemminger Acked-by: Eric Dumazet --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/include/net/fib_rules.h 2010-10-02 14:31:52.528341728 +0900 +++ b/include/net/fib_rules.h 2010-10-02 14:31:59.890839969 +0900 @@ -106,7 +106,6 @@ static inline u32 frh_get_table(struct f extern struct fib_rules_ops *fib_rules_register(const struct fib_rules_ops *, struct net *); extern void fib_rules_unregister(struct fib_rules_ops *); -extern void fib_rules_cleanup_ops(struct fib_rules_ops *); extern int fib_rules_lookup(struct fib_rules_ops *, struct flowi *, int flags, --- a/net/core/fib_rules.c 2010-10-02 14:31:52.578341727 +0900 +++ b/net/core/fib_rules.c 2010-10-02 14:32:09.850842358 +0900 @@ -144,7 +144,7 @@ fib_rules_register(const struct fib_rule } EXPORT_SYMBOL_GPL(fib_rules_register); -void fib_rules_cleanup_ops(struct fib_rules_ops *ops) +static void fib_rules_cleanup_ops(struct fib_rules_ops *ops) { struct fib_rule *rule, *tmp; @@ -153,7 +153,6 @@ void fib_rules_cleanup_ops(struct fib_ru fib_rule_put(rule); } } -EXPORT_SYMBOL_GPL(fib_rules_cleanup_ops); static void fib_rules_put_rcu(struct rcu_head *head) {