Patchwork [net-next] fib: fib_rules_cleanup can be static

login
register
mail settings
Submitter stephen hemminger
Date Oct. 5, 2010, 6:14 a.m.
Message ID <20101005151417.57eae0b0@s6510>
Download mbox | patch
Permalink /patch/66753/
State Accepted
Delegated to: David Miller
Headers show

Comments

stephen hemminger - Oct. 5, 2010, 6:14 a.m.
fib_rules_cleanup_ups is only defined and used in one place.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Eric Dumazet - Oct. 5, 2010, 6:19 a.m.
Le mardi 05 octobre 2010 à 15:14 +0900, Stephen Hemminger a écrit :
> fib_rules_cleanup_ups is only defined and used in one place.
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Acked-by: Eric Dumazet <eric.dumazet@gmail.com>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Oct. 5, 2010, 7:49 a.m.
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 5 Oct 2010 15:14:17 +0900

> fib_rules_cleanup_ups is only defined and used in one place.
> 
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- a/include/net/fib_rules.h	2010-10-02 14:31:52.528341728 +0900
+++ b/include/net/fib_rules.h	2010-10-02 14:31:59.890839969 +0900
@@ -106,7 +106,6 @@  static inline u32 frh_get_table(struct f
 
 extern struct fib_rules_ops *fib_rules_register(const struct fib_rules_ops *, struct net *);
 extern void fib_rules_unregister(struct fib_rules_ops *);
-extern void                     fib_rules_cleanup_ops(struct fib_rules_ops *);
 
 extern int			fib_rules_lookup(struct fib_rules_ops *,
 						 struct flowi *, int flags,
--- a/net/core/fib_rules.c	2010-10-02 14:31:52.578341727 +0900
+++ b/net/core/fib_rules.c	2010-10-02 14:32:09.850842358 +0900
@@ -144,7 +144,7 @@  fib_rules_register(const struct fib_rule
 }
 EXPORT_SYMBOL_GPL(fib_rules_register);
 
-void fib_rules_cleanup_ops(struct fib_rules_ops *ops)
+static void fib_rules_cleanup_ops(struct fib_rules_ops *ops)
 {
 	struct fib_rule *rule, *tmp;
 
@@ -153,7 +153,6 @@  void fib_rules_cleanup_ops(struct fib_ru
 		fib_rule_put(rule);
 	}
 }
-EXPORT_SYMBOL_GPL(fib_rules_cleanup_ops);
 
 static void fib_rules_put_rcu(struct rcu_head *head)
 {