| Message ID | 20160907140732.396bc2cf@xeon-e3 |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Stephen Hemminger <stephen@networkplumber.org> Date: Wed, 7 Sep 2016 14:07:32 -0700 > The netdevice type structure for macsec was being defined but never used. > To set the network device type the macro SET_NETDEV_DEVTYPE must be called. > Compile tested only, I don't use macsec. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Sabrina, please review. Thanks.
2016-09-08, 17:24:07 -0700, David Miller wrote: > From: Stephen Hemminger <stephen@networkplumber.org> > Date: Wed, 7 Sep 2016 14:07:32 -0700 > > > The netdevice type structure for macsec was being defined but never used. > > To set the network device type the macro SET_NETDEV_DEVTYPE must be called. > > Compile tested only, I don't use macsec. > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> > > Sabrina, please review. > > Thanks. Sorry for the delay. LGTM: Acked-by: Sabrina Dubroca <sd@queasysnail.net>
From: Stephen Hemminger <stephen@networkplumber.org> Date: Wed, 7 Sep 2016 14:07:32 -0700 > The netdevice type structure for macsec was being defined but never used. > To set the network device type the macro SET_NETDEV_DEVTYPE must be called. > Compile tested only, I don't use macsec. > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org> Applied.
--- a/drivers/net/macsec.c 2016-08-25 17:20:20.671031972 -0700 +++ b/drivers/net/macsec.c 2016-09-07 14:03:01.676238097 -0700 @@ -2973,6 +2973,7 @@ static void macsec_setup(struct net_devi dev->priv_flags |= IFF_NO_QUEUE; dev->netdev_ops = &macsec_netdev_ops; dev->destructor = macsec_free_netdev; + SET_NETDEV_DEVTYPE(dev, &macsec_type); eth_zero_addr(dev->broadcast); }
The netdevice type structure for macsec was being defined but never used. To set the network device type the macro SET_NETDEV_DEVTYPE must be called. Compile tested only, I don't use macsec. Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>