| Message ID | 1473222677-24761-1-git-send-email-avagin@openvz.org |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, Sep 06, 2016 at 09:31:17PM -0700, Andrei Vagin wrote: > This bug was detected by kmemleak: > unreferenced object 0xffff8804269cc3c0 (size 64): > comm "criu", pid 1042, jiffies 4294907360 (age 13.713s) > hex dump (first 32 bytes): > a0 32 cc 2c 04 88 ff ff 00 00 00 00 00 00 00 00 .2.,............ > 00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de ................ > backtrace: > [<ffffffff8184dffa>] kmemleak_alloc+0x4a/0xa0 > [<ffffffff8124720f>] kmem_cache_alloc_trace+0x10f/0x280 > [<ffffffffa02864cc>] __netlink_diag_dump+0x26c/0x290 [netlink_diag] > > v2: don't remove a reference on a rhashtable_iter structure to > release it from netlink_diag_dump_done > > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Fixes: ad202074320c ("netlink: Use rhashtable walk interface in diag dump") > Signed-off-by: Andrei Vagin <avagin@openvz.org> Acked-by: Herbert Xu <herbert@gondor.apana.org.au> Thanks for catching this!
From: Andrei Vagin <avagin@openvz.org> Date: Tue, 6 Sep 2016 21:31:17 -0700 > This bug was detected by kmemleak: > unreferenced object 0xffff8804269cc3c0 (size 64): > comm "criu", pid 1042, jiffies 4294907360 (age 13.713s) > hex dump (first 32 bytes): > a0 32 cc 2c 04 88 ff ff 00 00 00 00 00 00 00 00 .2.,............ > 00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de ................ > backtrace: > [<ffffffff8184dffa>] kmemleak_alloc+0x4a/0xa0 > [<ffffffff8124720f>] kmem_cache_alloc_trace+0x10f/0x280 > [<ffffffffa02864cc>] __netlink_diag_dump+0x26c/0x290 [netlink_diag] > > v2: don't remove a reference on a rhashtable_iter structure to > release it from netlink_diag_dump_done > > Cc: Herbert Xu <herbert@gondor.apana.org.au> > Fixes: ad202074320c ("netlink: Use rhashtable walk interface in diag dump") > Signed-off-by: Andrei Vagin <avagin@openvz.org> Applied, thanks.
diff --git a/net/netlink/diag.c b/net/netlink/diag.c index 3e3e253..b2f0e98 100644 --- a/net/netlink/diag.c +++ b/net/netlink/diag.c @@ -127,7 +127,6 @@ stop: goto done; rhashtable_walk_exit(hti); - cb->args[2] = 0; num++; mc_list:
This bug was detected by kmemleak: unreferenced object 0xffff8804269cc3c0 (size 64): comm "criu", pid 1042, jiffies 4294907360 (age 13.713s) hex dump (first 32 bytes): a0 32 cc 2c 04 88 ff ff 00 00 00 00 00 00 00 00 .2.,............ 00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de ................ backtrace: [<ffffffff8184dffa>] kmemleak_alloc+0x4a/0xa0 [<ffffffff8124720f>] kmem_cache_alloc_trace+0x10f/0x280 [<ffffffffa02864cc>] __netlink_diag_dump+0x26c/0x290 [netlink_diag] v2: don't remove a reference on a rhashtable_iter structure to release it from netlink_diag_dump_done Cc: Herbert Xu <herbert@gondor.apana.org.au> Fixes: ad202074320c ("netlink: Use rhashtable walk interface in diag dump") Signed-off-by: Andrei Vagin <avagin@openvz.org> --- net/netlink/diag.c | 1 - 1 file changed, 1 deletion(-)