| Message ID | 1473212098-4240-2-git-send-email-qiang.zhao@nxp.com |
|---|---|
| State | Superseded |
| Headers | show |
> -----Original Message----- > From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Zhao Qiang > Sent: Wednesday, September 07, 2016 7:05 AM > To: york sun <york.sun@nxp.com> > Cc: u-boot@lists.denx.de; X.B. Xie <xiaobo.xie@nxp.com> > Subject: [U-Boot] [PATCH v3 2/2] pbl: use "wait" command instead of "flush" > command > > FLUSH command is restricted to CCSR board. So use WAIT > command in case of non-CCSR board. > What about this description "'PBL flush command is restricted to CCSR memory space. So use WAIT PBI command to provide enough time for data to get flush in target memory " -prabhakar
> -----Original Message----- > From: Prabhakar Kushwaha > Sent: Wednesday, September 07, 2016 10:46 AM > To: Qiang Zhao <qiang.zhao@nxp.com>; york sun <york.sun@nxp.com> > Cc: u-boot@lists.denx.de; X.B. Xie <xiaobo.xie@nxp.com> > Subject: RE: [U-Boot] [PATCH v3 2/2] pbl: use "wait" command instead of > "flush" command > > > -----Original Message----- > > From: U-Boot [mailto:u-boot-bounces@lists.denx.de] On Behalf Of Zhao > > Qiang > > Sent: Wednesday, September 07, 2016 7:05 AM > > To: york sun <york.sun@nxp.com> > > Cc: u-boot@lists.denx.de; X.B. Xie <xiaobo.xie@nxp.com> > > Subject: [U-Boot] [PATCH v3 2/2] pbl: use "wait" command instead of "flush" > > command > > > > FLUSH command is restricted to CCSR board. So use WAIT command in case > > of non-CCSR board. > > > > What about this description > > "'PBL flush command is restricted to CCSR memory space. > So use WAIT PBI command to provide enough time for data to get flush in > target memory " > Thank you! It is better. -Zhao Qiang
diff --git a/board/freescale/t208xqds/t208x_pbi.cfg b/board/freescale/t208xqds/t208x_pbi.cfg index e200d92..43be8a8 100644 --- a/board/freescale/t208xqds/t208x_pbi.cfg +++ b/board/freescale/t208xqds/t208x_pbi.cfg @@ -37,5 +37,4 @@ 09000014 ff000000 09000018 81000000 #Flush PBL data -09138000 00000000 -091380c0 00000000 +091380c0 00100000 diff --git a/board/freescale/t208xrdb/t2080_pbi.cfg b/board/freescale/t208xrdb/t2080_pbi.cfg index e200d92..43be8a8 100644 --- a/board/freescale/t208xrdb/t2080_pbi.cfg +++ b/board/freescale/t208xrdb/t2080_pbi.cfg @@ -37,5 +37,4 @@ 09000014 ff000000 09000018 81000000 #Flush PBL data -09138000 00000000 -091380c0 00000000 +091380c0 00100000 diff --git a/board/freescale/t4qds/t4_pbi.cfg b/board/freescale/t4qds/t4_pbi.cfg index 6126266..8d46003 100644 --- a/board/freescale/t4qds/t4_pbi.cfg +++ b/board/freescale/t4qds/t4_pbi.cfg @@ -18,5 +18,4 @@ 09000014 ff000000 09000018 81000000 #Flush PBL data -09138000 00000000 -091380c0 00000000 +091380c0 00100000 diff --git a/board/freescale/t4rdb/t4_pbi.cfg b/board/freescale/t4rdb/t4_pbi.cfg index e7bb673..0b326fa 100644 --- a/board/freescale/t4rdb/t4_pbi.cfg +++ b/board/freescale/t4rdb/t4_pbi.cfg @@ -24,5 +24,4 @@ 09000014 ff000000 09000018 81000000 #Flush PBL data -09138000 00000000 -091380c0 00000000 +091380c0 00100000 diff --git a/tools/pblimage.c b/tools/pblimage.c index d74fde9..16d94c98 100644 --- a/tools/pblimage.c +++ b/tools/pblimage.c @@ -297,7 +297,7 @@ int pblimage_check_params(struct image_tool_params *params) pbi_crc_cmd1 = 0x13; pbi_crc_cmd2 = 0x80; pbl_cmd_initaddr = 0x82000000; - pbl_end_cmd[0] = 0x09138000; + pbl_end_cmd[0] = 0x091380c0; pbl_end_cmd[1] = 0x00000000; pbl_end_cmd[2] = 0x091380c0; pbl_end_cmd[3] = 0x00000000;
FLUSH command is restricted to CCSR board. So use WAIT command in case of non-CCSR board. Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> --- Changes for v2: - split to two patches Changes for v3: - modify commit msg board/freescale/t208xqds/t208x_pbi.cfg | 3 +-- board/freescale/t208xrdb/t2080_pbi.cfg | 3 +-- board/freescale/t4qds/t4_pbi.cfg | 3 +-- board/freescale/t4rdb/t4_pbi.cfg | 3 +-- tools/pblimage.c | 2 +- 5 files changed, 5 insertions(+), 9 deletions(-)