Patchwork [2/2,RFC] don't let BCM63XX_PHY depend on non-existant symbol

login
register
mail settings
Submitter Uwe Kleine-König
Date Oct. 4, 2010, 9:43 a.m.
Message ID <1286185413-22924-2-git-send-email-u.kleine-koenig@pengutronix.de>
Download mbox | patch
Permalink /patch/66642/
State Accepted
Delegated to: David Miller
Headers show

Comments

Uwe Kleine-König - Oct. 4, 2010, 9:43 a.m.
The kernel doesn't have a symbol called BCM63XX.  There is a symbol
BCM63XX_ENET (introduced in 9b1fc55a0500, 6 weeks after 09bb9aa0ed that
introduced BCM63XX_PHY), but the driver compiles without that, too.

Cc: Maxime Bizon <mbizon@freebox.fr>
Cc: Florian Fainelli <florian@openwrt.org>
Cc: David S. Miller <davem@davemloft.net>
Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/net/phy/Kconfig |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
David Miller - Oct. 5, 2010, 7:36 a.m.
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Mon,  4 Oct 2010 11:43:33 +0200

> The kernel doesn't have a symbol called BCM63XX.  There is a symbol
> BCM63XX_ENET (introduced in 9b1fc55a0500, 6 weeks after 09bb9aa0ed that
> introduced BCM63XX_PHY), but the driver compiles without that, too.
> 
> Cc: Maxime Bizon <mbizon@freebox.fr>
> Cc: Florian Fainelli <florian@openwrt.org>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Looks good to me, applied.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig
index eb799b3..cb3d13e 100644
--- a/drivers/net/phy/Kconfig
+++ b/drivers/net/phy/Kconfig
@@ -58,7 +58,6 @@  config BROADCOM_PHY
 
 config BCM63XX_PHY
 	tristate "Drivers for Broadcom 63xx SOCs internal PHY"
-	depends on BCM63XX
 	---help---
 	  Currently supports the 6348 and 6358 PHYs.