Patchwork [1/2] Revert "ipv4: Make INET_LRO a bool instead of tristate."

login
register
mail settings
Submitter Ben Hutchings
Date Oct. 4, 2010, 1:37 a.m.
Message ID <1286156262.3916.213.camel@localhost>
Download mbox | patch
Permalink /patch/66610/
State Accepted
Delegated to: David Miller
Headers show

Comments

Ben Hutchings - Oct. 4, 2010, 1:37 a.m.
This reverts commit e81963b180ac502fda0326edf059b1e29cdef1a2.

LRO is now deprecated in favour of GRO, and only a few drivers use it,
so it is desirable to build it as a module in distribution kernels.

The original change to prevent building it as a module was made in an
attempt to avoid the case where some dependents are set to y and some
to m, and INET_LRO can be set to m rather than y.  However, the
Kconfig system will reliably set INET_LRO=y in this case.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
Dave,

You made the change I want to revert in response to
<http://article.gmane.org/gmane.linux.kernel/825646>.  The real problem
with its configuration is actually that CONFIG_INET is not set but
CONFIG_INET_LRO=m, and the fix is to make CONFIG_PASEMI_MAC depend on
CONFIG_INET.

Ben.

 net/ipv4/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Miller - Oct. 4, 2010, 2:56 a.m.
From: Ben Hutchings <ben@decadent.org.uk>
Date: Mon, 04 Oct 2010 02:37:42 +0100

> You made the change I want to revert in response to
> <http://article.gmane.org/gmane.linux.kernel/825646>.  The real problem
> with its configuration is actually that CONFIG_INET is not set but
> CONFIG_INET_LRO=m, and the fix is to make CONFIG_PASEMI_MAC depend on
> CONFIG_INET.

Ben, you can't just revert this by itself.

That knowingly breaks the build.

If you want the tristate back, you must do it after or at the
same time as fixing the driver deps.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ben Hutchings - Oct. 4, 2010, 3:54 a.m.
On Sun, 2010-10-03 at 19:56 -0700, David Miller wrote:
> From: Ben Hutchings <ben@decadent.org.uk>
> Date: Mon, 04 Oct 2010 02:37:42 +0100
> 
> > You made the change I want to revert in response to
> > <http://article.gmane.org/gmane.linux.kernel/825646>.  The real problem
> > with its configuration is actually that CONFIG_INET is not set but
> > CONFIG_INET_LRO=m, and the fix is to make CONFIG_PASEMI_MAC depend on
> > CONFIG_INET.
> 
> Ben, you can't just revert this by itself.
> 
> That knowingly breaks the build.
> 
> If you want the tristate back, you must do it after or at the
> same time as fixing the driver deps.

The fact that the driver dependencies are broken has nothing to do with
whether CONFIG_INET_LRO is boolean or tristate.  You fixed a problem
that didn't exist rather than the problem that did.

Ben.
David Miller - Oct. 4, 2010, 4:01 a.m.
From: Ben Hutchings <ben@decadent.org.uk>
Date: Mon, 04 Oct 2010 04:54:55 +0100

> On Sun, 2010-10-03 at 19:56 -0700, David Miller wrote:
>> From: Ben Hutchings <ben@decadent.org.uk>
>> Date: Mon, 04 Oct 2010 02:37:42 +0100
>> 
>> > You made the change I want to revert in response to
>> > <http://article.gmane.org/gmane.linux.kernel/825646>.  The real problem
>> > with its configuration is actually that CONFIG_INET is not set but
>> > CONFIG_INET_LRO=m, and the fix is to make CONFIG_PASEMI_MAC depend on
>> > CONFIG_INET.
>> 
>> Ben, you can't just revert this by itself.
>> 
>> That knowingly breaks the build.
>> 
>> If you want the tristate back, you must do it after or at the
>> same time as fixing the driver deps.
> 
> The fact that the driver dependencies are broken has nothing to do with
> whether CONFIG_INET_LRO is boolean or tristate.  You fixed a problem
> that didn't exist rather than the problem that did.

Oh, I see, ok I'll apply your patches thanks for explaining Ben.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
index 94e0b51..704a0cf 100644
--- a/net/ipv4/Kconfig
+++ b/net/ipv4/Kconfig
@@ -420,7 +420,7 @@  config INET_XFRM_MODE_BEET
 	  If unsure, say Y.
 
 config INET_LRO
-	bool "Large Receive Offload (ipv4/tcp)"
+	tristate "Large Receive Offload (ipv4/tcp)"
 	default y
 	---help---
 	  Support for Large Receive Offload (ipv4/tcp).