Patchwork [ARM] Testcases incorrectly run in Thumb/Xscale

login
register
mail settings
Submitter Sofiane Naci
Date Oct. 3, 2010, 2:55 p.m.
Message ID <000401cb630a$f8915d10$e9b41730$@Naci@arm.com>
Download mbox | patch
Permalink /patch/66600/
State New
Headers show

Comments

Sofiane Naci - Oct. 3, 2010, 2:55 p.m.
Hi,

This patch fixes three testcases that are specific to ARM mode and therefore
should be skipped when compiling for Thumb.
Two of these (g2 and scd42-2) are also Xscale specific.

Thanks
Sofiane


gcc/testsuite

2010-09-27  Sofiane Naci  <sofiane.naci@arm.com>

    * gcc.target/arm/g2.c: Skip test in -mthumb.
      Skip test unless cpu is xscale.
    * gcc.target/arm/scd42-2.c: Likewise.
    * gcc.target/arm/mmx-1.c: Skip test in -mthumb.
Richard Earnshaw - Oct. 5, 2010, 9:37 a.m.
On Sun, 2010-10-03 at 15:55 +0100, Sofiane Naci wrote:
> Hi,
> 
> This patch fixes three testcases that are specific to ARM mode and therefore
> should be skipped when compiling for Thumb.
> Two of these (g2 and scd42-2) are also Xscale specific.
> 
> Thanks
> Sofiane
> 
> 
> gcc/testsuite
> 
> 2010-09-27  Sofiane Naci  <sofiane.naci@arm.com>
> 
>     * gcc.target/arm/g2.c: Skip test in -mthumb.
>       Skip test unless cpu is xscale.
>     * gcc.target/arm/scd42-2.c: Likewise.
>     * gcc.target/arm/mmx-1.c: Skip test in -mthumb.

OK.

R.

Patch

Index: /home/sofnac01/work/sandboxes/devt/trunk/source/gcc/testsuite/gcc.target/arm/g2.c
===================================================================
--- /home/sofnac01/work/sandboxes/devt/trunk/source/gcc/testsuite/gcc.target/arm/g2.c	(revision 163954)
+++ /home/sofnac01/work/sandboxes/devt/trunk/source/gcc/testsuite/gcc.target/arm/g2.c	(working copy)
@@ -2,6 +2,8 @@ 
 /* { dg-do compile } */
 /* { dg-options "-mcpu=xscale -O2" } */
 /* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-march=*" } { "-march=xscale" } } */
+/* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-mcpu=*" } { "-mcpu=xscale" } } */
+/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } { "" } } */
 /* { dg-require-effective-target arm32 } */
 
 /* Brett Gaines' test case. */
Index: /home/sofnac01/work/sandboxes/devt/trunk/source/gcc/testsuite/gcc.target/arm/mmx-1.c
===================================================================
--- /home/sofnac01/work/sandboxes/devt/trunk/source/gcc/testsuite/gcc.target/arm/mmx-1.c	(revision 163954)
+++ /home/sofnac01/work/sandboxes/devt/trunk/source/gcc/testsuite/gcc.target/arm/mmx-1.c	(working copy)
@@ -4,6 +4,7 @@ 
 /* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-mcpu=*" } { "-mcpu=iwmmxt" } } */
 /* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-mabi=*" } { "-mabi=iwmmxt" } } */
 /* { dg-skip-if "Test is specific to the iWMMXt" { arm*-*-* } { "-march=*" } { "-march=iwmmxt" } } */
+/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } { "" } } */
 /* { dg-options "-O -mno-apcs-frame -mcpu=iwmmxt -mabi=iwmmxt" } */
 /* { dg-require-effective-target arm32 } */
 /* { dg-require-effective-target arm_iwmmxt_ok } */
Index: /home/sofnac01/work/sandboxes/devt/trunk/source/gcc/testsuite/gcc.target/arm/scd42-2.c
===================================================================
--- /home/sofnac01/work/sandboxes/devt/trunk/source/gcc/testsuite/gcc.target/arm/scd42-2.c	(revision 163954)
+++ /home/sofnac01/work/sandboxes/devt/trunk/source/gcc/testsuite/gcc.target/arm/scd42-2.c	(working copy)
@@ -2,6 +2,8 @@ 
 /* { dg-do compile } */
 /* { dg-options "-mcpu=xscale -O" } */
 /* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-march=*" } { "-march=xscale" } } */
+/* { dg-skip-if "Test is specific to the Xscale" { arm*-*-* } { "-mcpu=*" } { "-mcpu=xscale" } } */
+/* { dg-skip-if "Test is specific to ARM mode" { arm*-*-* } { "-mthumb" } { "" } } */
 /* { dg-require-effective-target arm32 } */
 
 unsigned load2(void) __attribute__ ((naked));