diff mbox

[U-Boot,1/3] sunxi: Sync h3-orangepi dts files with kernel

Message ID 20160903111227.9296-1-hdegoede@redhat.com
State Accepted
Commit 019731a88f40d45bd15505402772e00d85689dd6
Delegated to: Hans de Goede
Headers show

Commit Message

Hans de Goede Sept. 3, 2016, 11:12 a.m. UTC 
This adds an emac node to the orangepi-2 dts (not yet merged upstream,
but in u-boot we already have emac support); fixes the alphetically
sorting of nodes in sun8i-h3-orangepi-plus.dts and disables some
usb controllers in sun8i-h3-orangepi-plus.dts which are only used
on the plus2e, as upstream has decided to do a separate dts files
for the plus2e.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 arch/arm/dts/sun8i-h3-orangepi-2.dts    | 11 +++++
 arch/arm/dts/sun8i-h3-orangepi-pc.dts   |  1 +
 arch/arm/dts/sun8i-h3-orangepi-plus.dts | 72 ++++++++++++---------------------
 3 files changed, 37 insertions(+), 47 deletions(-)

Comments

Ian Campbell Sept. 8, 2016, 11:58 a.m. UTC | #1 
On Sat, 2016-09-03 at 13:12 +0200, Hans de Goede wrote:
> This adds an emac node to the orangepi-2 dts (not yet merged
> upstream,
> but in u-boot we already have emac support); fixes the alphetically
> sorting of nodes in sun8i-h3-orangepi-plus.dts and disables some
> usb controllers in sun8i-h3-orangepi-plus.dts which are only used
> on the plus2e, as upstream has decided to do a separate dts files
> for the plus2e.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

After these three patches does the state of the dts files now match the
state of the files upstream, modulo things which are still in flight to
upstream (so maybe I should ask "...match the intended/eventual
state...")? If so then:

Acked-by: Ian Campbell <ijc@hellion.org.uk>
Hans de Goede Sept. 9, 2016, 9:56 a.m. UTC | #2 
Hi,

On 08-09-16 13:58, Ian Campbell wrote:
> On Sat, 2016-09-03 at 13:12 +0200, Hans de Goede wrote:
>> This adds an emac node to the orangepi-2 dts (not yet merged
>> upstream,
>> but in u-boot we already have emac support); fixes the alphetically
>> sorting of nodes in sun8i-h3-orangepi-plus.dts and disables some
>> usb controllers in sun8i-h3-orangepi-plus.dts which are only used
>> on the plus2e, as upstream has decided to do a separate dts files
>> for the plus2e.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> After these three patches does the state of the dts files now match the
> state of the files upstream, modulo things which are still in flight to
> upstream (so maybe I should ask "...match the intended/eventual
> state...")?

Yes this will make the dts files match the intended/eventual state.

Regards,

Hans
diff mbox

Patch

diff --git a/arch/arm/dts/sun8i-h3-orangepi-2.dts b/arch/arm/dts/sun8i-h3-orangepi-2.dts
index f89fe00..caa1a69 100644
--- a/arch/arm/dts/sun8i-h3-orangepi-2.dts
+++ b/arch/arm/dts/sun8i-h3-orangepi-2.dts
@@ -109,6 +109,17 @@ 
 	status = "okay";
 };
 
+&emac {
+	phy = <&phy1>;
+	phy-mode = "mii";
+	allwinner,use-internal-phy;
+	allwinner,leds-active-low;
+	status = "okay";
+	phy1: ethernet-phy@1 {
+		reg = <1>;
+	};
+};
+
 &ir {
 	pinctrl-names = "default";
 	pinctrl-0 = <&ir_pins_a>;
diff --git a/arch/arm/dts/sun8i-h3-orangepi-pc.dts b/arch/arm/dts/sun8i-h3-orangepi-pc.dts
index 24f8e97..b8340f7 100644
--- a/arch/arm/dts/sun8i-h3-orangepi-pc.dts
+++ b/arch/arm/dts/sun8i-h3-orangepi-pc.dts
@@ -169,6 +169,7 @@ 
 &emac {
 	phy = <&phy1>;
 	phy-mode = "mii";
+	allwinner,use-internal-phy;
 	allwinner,leds-active-low;
 	status = "okay";
 	phy1: ethernet-phy@1 {
diff --git a/arch/arm/dts/sun8i-h3-orangepi-plus.dts b/arch/arm/dts/sun8i-h3-orangepi-plus.dts
index 4f4bb0f..e7079b2 100644
--- a/arch/arm/dts/sun8i-h3-orangepi-plus.dts
+++ b/arch/arm/dts/sun8i-h3-orangepi-plus.dts
@@ -44,21 +44,9 @@ 
 #include "sun8i-h3-orangepi-2.dts"
 
 / {
-	model = "Xunlong Orange Pi Plus / Plus 2 / Plus 2E";
+	model = "Xunlong Orange Pi Plus / Plus 2";
 	compatible = "xunlong,orangepi-plus", "allwinner,sun8i-h3";
 
-	reg_usb3_vbus: usb3-vbus {
-		compatible = "regulator-fixed";
-		pinctrl-names = "default";
-		pinctrl-0 = <&usb3_vbus_pin_a>;
-		regulator-name = "usb3-vbus";
-		regulator-min-microvolt = <5000000>;
-		regulator-max-microvolt = <5000000>;
-		regulator-boot-on;
-		enable-active-high;
-		gpio = <&pio 6 11 GPIO_ACTIVE_HIGH>;
-	};
-
 	reg_gmac_3v3: gmac-3v3 {
 		compatible = "regulator-fixed";
 		pinctrl-names = "default";
@@ -70,16 +58,33 @@ 
 		enable-active-high;
 		gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>;
 	};
-};
 
-&ehci2 {
-	status = "okay";
+	reg_usb3_vbus: usb3-vbus {
+		compatible = "regulator-fixed";
+		pinctrl-names = "default";
+		pinctrl-0 = <&usb3_vbus_pin_a>;
+		regulator-name = "usb3-vbus";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-boot-on;
+		enable-active-high;
+		gpio = <&pio 6 11 GPIO_ACTIVE_HIGH>;
+	};
 };
 
 &ehci3 {
 	status = "okay";
 };
 
+&emac {
+	/* The Orange Pi Plus uses an external phy */
+	pinctrl-names = "default";
+	pinctrl-0 = <&emac_rgmii_pins>;
+	phy-supply = <&reg_gmac_3v3>;
+	phy-mode = "rgmii";
+	/delete-property/allwinner,use-internal-phy;
+};
+
 &mmc2 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc2_8bit_pins>;
@@ -97,28 +102,16 @@ 
 	allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
 };
 
-&ohci1 {
-	status = "okay";
-};
-
-&ohci2 {
-	status = "okay";
-};
-
-&ohci3 {
-	status = "okay";
-};
-
 &pio {
-	usb3_vbus_pin_a: usb3_vbus_pin@0 {
-		allwinner,pins = "PG11";
+	gmac_power_pin_orangepi: gmac_power_pin@0 {
+		allwinner,pins = "PD6";
 		allwinner,function = "gpio_out";
 		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
 		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
 	};
 
-	gmac_power_pin_orangepi: gmac_power_pin@0 {
-		allwinner,pins = "PD6";
+	usb3_vbus_pin_a: usb3_vbus_pin@0 {
+		allwinner,pins = "PG11";
 		allwinner,function = "gpio_out";
 		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
 		allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;
@@ -128,18 +121,3 @@ 
 &usbphy {
 	usb3_vbus-supply = <&reg_usb3_vbus>;
 };
-
-&emac {
-	pinctrl-names = "default";
-	pinctrl-0 = <&emac_rgmii_pins>;
-	phy-supply = <&reg_gmac_3v3>;
-	phy = <&phy1>;
-	phy-mode = "rgmii";
-
-	allwinner,leds-active-low;
-	status = "okay";
-
-	phy1: ethernet-phy@1 {
-		reg = <0>;
-	};
-};