diff mbox

virtio-blk: Remove hw/virtio/dataplane folder from MAINTAINERS file

Message ID 1472853784-12808-1-git-send-email-thuth@redhat.com
State New
Headers show

Commit Message

Thomas Huth Sept. 2, 2016, 10:03 p.m. UTC
The folder does not exist anymore, thus should be removed from the
MAINTAINERS file, too.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

Comments

Fam Zheng Sept. 3, 2016, 7:09 a.m. UTC | #1
On Sat, 09/03 00:03, Thomas Huth wrote:
> The folder does not exist anymore, thus should be removed from the
> MAINTAINERS file, too.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  MAINTAINERS | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b6fb84e..ff45f8c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -902,7 +902,6 @@ L: qemu-block@nongnu.org
>  S: Supported
>  F: hw/block/virtio-blk.c
>  F: hw/block/dataplane/*
> -F: hw/virtio/dataplane/*
>  T: git git://github.com/stefanha/qemu.git block
>  
>  virtio-ccw
> -- 
> 1.8.3.1
> 
> 

Reviewed-by: Fam Zheng <famz@redhat.com>
Markus Armbruster Sept. 5, 2016, 8:22 a.m. UTC | #2
Thomas Huth <thuth@redhat.com> writes:

> The folder does not exist anymore, thus should be removed from the
> MAINTAINERS file, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  MAINTAINERS | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b6fb84e..ff45f8c 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -902,7 +902,6 @@ L: qemu-block@nongnu.org
>  S: Supported
>  F: hw/block/virtio-blk.c
>  F: hw/block/dataplane/*
> -F: hw/virtio/dataplane/*
>  T: git git://github.com/stefanha/qemu.git block
>  
>  virtio-ccw

Are there any other patterns in MAINTAINERS that don't match anything?
Thomas Huth Sept. 5, 2016, 8:34 a.m. UTC | #3
On 05.09.2016 10:22, Markus Armbruster wrote:
> Thomas Huth <thuth@redhat.com> writes:
> 
>> The folder does not exist anymore, thus should be removed from the
>> MAINTAINERS file, too.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  MAINTAINERS | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index b6fb84e..ff45f8c 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -902,7 +902,6 @@ L: qemu-block@nongnu.org
>>  S: Supported
>>  F: hw/block/virtio-blk.c
>>  F: hw/block/dataplane/*
>> -F: hw/virtio/dataplane/*
>>  T: git git://github.com/stefanha/qemu.git block
>>  
> 
> Are there any other patterns in MAINTAINERS that don't match anything?

for i in `grep "^[FX]: " MAINTAINERS | sed "s/^.: //"` ; do \
  if [ ! -e "$i" ]; then echo "$i" ; fi ; \
done

include/hw/xilinx.h
include/hw/*/xlnx*.c
include/hw/acpi/piix.h
hw/i386/*dsl
scripts/acpi*py
hw/virtio/dataplane/*
include/hw/cpu/icc_bus.h
hw/cpu/icc_bus.c
block/raw-aio.h

 Thomas
Markus Armbruster Sept. 5, 2016, 11:05 a.m. UTC | #4
Thomas Huth <thuth@redhat.com> writes:

> On 05.09.2016 10:22, Markus Armbruster wrote:
>> Thomas Huth <thuth@redhat.com> writes:
>> 
>>> The folder does not exist anymore, thus should be removed from the
>>> MAINTAINERS file, too.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>  MAINTAINERS | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index b6fb84e..ff45f8c 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -902,7 +902,6 @@ L: qemu-block@nongnu.org
>>>  S: Supported
>>>  F: hw/block/virtio-blk.c
>>>  F: hw/block/dataplane/*
>>> -F: hw/virtio/dataplane/*
>>>  T: git git://github.com/stefanha/qemu.git block
>>>  
>> 
>> Are there any other patterns in MAINTAINERS that don't match anything?
>
> for i in `grep "^[FX]: " MAINTAINERS | sed "s/^.: //"` ; do \
>   if [ ! -e "$i" ]; then echo "$i" ; fi ; \
> done
>
> include/hw/xilinx.h

Gone since commit d5001cf.

> include/hw/*/xlnx*.c

Bug, should be .h.

> include/hw/acpi/piix.h

Bug, should be piix4.h.

> hw/i386/*dsl
> scripts/acpi*py

Gone since commit 9fc6502.

> hw/virtio/dataplane/*

Gone since commit fee089e.

> include/hw/cpu/icc_bus.h
> hw/cpu/icc_bus.c

Gone since commit dfeb867.

> block/raw-aio.h

Moved to include/block/raw-aio.h in commit 0187f5c.

>  Thomas

Let's fix all this.  You or I?
Thomas Huth Sept. 5, 2016, 11:34 a.m. UTC | #5
On 05.09.2016 13:05, Markus Armbruster wrote:
> Thomas Huth <thuth@redhat.com> writes:
> 
>> On 05.09.2016 10:22, Markus Armbruster wrote:
>>> Thomas Huth <thuth@redhat.com> writes:
>>>
>>>> The folder does not exist anymore, thus should be removed from the
>>>> MAINTAINERS file, too.
>>>>
>>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>>> ---
>>>>  MAINTAINERS | 1 -
>>>>  1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index b6fb84e..ff45f8c 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -902,7 +902,6 @@ L: qemu-block@nongnu.org
>>>>  S: Supported
>>>>  F: hw/block/virtio-blk.c
>>>>  F: hw/block/dataplane/*
>>>> -F: hw/virtio/dataplane/*
>>>>  T: git git://github.com/stefanha/qemu.git block
>>>>  
>>>
>>> Are there any other patterns in MAINTAINERS that don't match anything?
>>
>> for i in `grep "^[FX]: " MAINTAINERS | sed "s/^.: //"` ; do \
>>   if [ ! -e "$i" ]; then echo "$i" ; fi ; \
>> done
>>
>> include/hw/xilinx.h
> 
> Gone since commit d5001cf.
> 
>> include/hw/*/xlnx*.c
> 
> Bug, should be .h.
> 
>> include/hw/acpi/piix.h
> 
> Bug, should be piix4.h.
> 
>> hw/i386/*dsl
>> scripts/acpi*py
> 
> Gone since commit 9fc6502.
> 
>> hw/virtio/dataplane/*
> 
> Gone since commit fee089e.
> 
>> include/hw/cpu/icc_bus.h
>> hw/cpu/icc_bus.c
> 
> Gone since commit dfeb867.
> 
>> block/raw-aio.h
> 
> Moved to include/block/raw-aio.h in commit 0187f5c.
> 
>>  Thomas
> 
> Let's fix all this.  You or I?

I don't mind. I'm currently busy hunting some bugs ... So feel free to
send the patches for these issues. (and in case you also don't have time
for that now, I've also put an entry on my TODO list, so I could do that
later if you prefer that)

 Thomas
Markus Armbruster Sept. 5, 2016, 12:29 p.m. UTC | #6
Thomas Huth <thuth@redhat.com> writes:

> On 05.09.2016 13:05, Markus Armbruster wrote:
[...]
>> Let's fix all this.  You or I?
>
> I don't mind. I'm currently busy hunting some bugs ... So feel free to
> send the patches for these issues. (and in case you also don't have time
> for that now, I've also put an entry on my TODO list, so I could do that
> later if you prefer that)

Patch sent.  Thanks!
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index b6fb84e..ff45f8c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -902,7 +902,6 @@  L: qemu-block@nongnu.org
 S: Supported
 F: hw/block/virtio-blk.c
 F: hw/block/dataplane/*
-F: hw/virtio/dataplane/*
 T: git git://github.com/stefanha/qemu.git block
 
 virtio-ccw