diff mbox

[U-Boot,V2] board: am57xx: Fix missing check for beagle_x15

Message ID 20160902185133.6765-1-nm@ti.com
State Accepted
Commit c989166037941f80e0d46f1fa4e37c9f4f876b80
Delegated to: Tom Rini
Headers show

Commit Message

Nishanth Menon Sept. 2, 2016, 6:51 p.m. UTC
When beagleboard-X15 is booted, we see the following log:
Unidentified board claims BBRDX15_ in eeprom header

This is because of the missing check for x15 (the default) and reports
an error for a valid board configuration. Fix the same.

Signed-off-by: Nishanth Menon <nm@ti.com>
---
Changes since V1:
	- move the x15 check higher up in the list.

V1: https://patchwork.ozlabs.org/patch/665144/

 board/ti/am57xx/board.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Tom Rini Sept. 2, 2016, 7:08 p.m. UTC | #1
On Fri, Sep 02, 2016 at 01:51:33PM -0500, Nishanth Menon wrote:

> When beagleboard-X15 is booted, we see the following log:
> Unidentified board claims BBRDX15_ in eeprom header
> 
> This is because of the missing check for x15 (the default) and reports
> an error for a valid board configuration. Fix the same.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
Lokesh Vutla Sept. 3, 2016, 4:54 p.m. UTC | #2
On Saturday 03 September 2016 12:21 AM, Nishanth Menon wrote:
> When beagleboard-X15 is booted, we see the following log:
> Unidentified board claims BBRDX15_ in eeprom header
> 
> This is because of the missing check for x15 (the default) and reports
> an error for a valid board configuration. Fix the same.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>

Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks and regards,
Lokesh

> ---
> Changes since V1:
> 	- move the x15 check higher up in the list.
> 
> V1: https://patchwork.ozlabs.org/patch/665144/
> 
>  board/ti/am57xx/board.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c
> index 927d1364fe46..64de60254136 100644
> --- a/board/ti/am57xx/board.c
> +++ b/board/ti/am57xx/board.c
> @@ -338,7 +338,9 @@ static void setup_board_eeprom_env(void)
>  	if (rc)
>  		goto invalid_eeprom;
>  
> -	if (board_is_am572x_evm())
> +	if (board_is_x15())
> +		name = "beagle_x15";
> +	else if (board_is_am572x_evm())
>  		name = "am57xx_evm";
>  	else if (board_is_am572x_idk())
>  		name = "am572x_idk";
>
Tom Rini Sept. 7, 2016, 6 p.m. UTC | #3
On Fri, Sep 02, 2016 at 01:51:33PM -0500, Nishanth Menon wrote:

> When beagleboard-X15 is booted, we see the following log:
> Unidentified board claims BBRDX15_ in eeprom header
> 
> This is because of the missing check for x15 (the default) and reports
> an error for a valid board configuration. Fix the same.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c
index 927d1364fe46..64de60254136 100644
--- a/board/ti/am57xx/board.c
+++ b/board/ti/am57xx/board.c
@@ -338,7 +338,9 @@  static void setup_board_eeprom_env(void)
 	if (rc)
 		goto invalid_eeprom;
 
-	if (board_is_am572x_evm())
+	if (board_is_x15())
+		name = "beagle_x15";
+	else if (board_is_am572x_evm())
 		name = "am57xx_evm";
 	else if (board_is_am572x_idk())
 		name = "am572x_idk";