| Message ID | CADaLNDkZdAipxx6cfLJ6yrzTrcLPS_Ciw8+T5EUFVcRRw+fjPw@mail.gmail.com |
|---|---|
| State | New |
| Headers | show |
On Friday, September 2, 2016 11:46:31 AM CEST Duc Dang wrote: > Hi Arnd, Olof, > > This is the first part of DTS changes for X-Gene platforms targeted for 4.9. > > The changes include: > + X-Gene Soc PMU support patch set from Tai Nguyen (v10 reviewed by > Mark, DT binding document acked by Rob [1] and was suggested to merge > via am-soc tree by Will [2]) > + Follow up patch to enable DT entry for SoC PMU on X-Gene v2 > + Correct PCIe legacy interrupt mode to level-active high > + DTS entry for X-Gene hwmon (v4 acked by Guenter, DT binding document > and driver is in linux-next now [3]) > > Regards, > Duc Dang. Sorry for the long delay, I've just now started looking at the dts changes for arm64. The changes to arch/arm64/boot/dts look fine, but I don't want to mix driver changes with dts changes, as we use separate branches for those. Please send this again as two pull requests, one for the dts changes, and one for the rest (pmu driver, binding and MAINTAINERS file). Please also include an explanation in the tag description about why this gets merged through arm-soc. I see that Will suggested doing it that way, but I don't see what the reason is. We normally don't touch that directory. Arnd > > [1]: https://lkml.org/lkml/2016/7/15/563 > [2]: https://lkml.org/lkml/2016/7/20/224 > [3]: http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=893485e74c37669aeecf0b648dbfbd8e2f0471c3 > ------ > > The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: > > Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) > > are available in the git repository at: > > https://github.com/AppliedMicro/xgene-next.git tags/xgene-dts-for-v4.9-part1 > > for you to fetch changes up to 1c983fc9369420748192712bde2429af3e580390: > > arm64: dts: apm: Add X-Gene SoC hwmon to device tree (2016-09-02 > 10:43:41 -0700) > > ---------------------------------------------------------------- > X-Gene DTS changes queued for v4.9 - part 1 > > This patch set includes: > + X-Gene v1 SoC Performance Monitoring Unit (PMU) support > + DTS entry to enable SoC PMU for X-Gene v2 SoC > + PCIe legacy interrupt polarity fix for X-Gene > + X-Gene SoC hwmon DTS entry >
On Wed, Sep 14, 2016 at 7:59 AM, Arnd Bergmann <arnd@arndb.de> wrote: > On Friday, September 2, 2016 11:46:31 AM CEST Duc Dang wrote: >> Hi Arnd, Olof, >> >> This is the first part of DTS changes for X-Gene platforms targeted for 4.9. >> >> The changes include: >> + X-Gene Soc PMU support patch set from Tai Nguyen (v10 reviewed by >> Mark, DT binding document acked by Rob [1] and was suggested to merge >> via am-soc tree by Will [2]) >> + Follow up patch to enable DT entry for SoC PMU on X-Gene v2 >> + Correct PCIe legacy interrupt mode to level-active high >> + DTS entry for X-Gene hwmon (v4 acked by Guenter, DT binding document >> and driver is in linux-next now [3]) >> >> Regards, >> Duc Dang. > > Sorry for the long delay, I've just now started looking at the dts changes > for arm64. The changes to arch/arm64/boot/dts look fine, but I don't > want to mix driver changes with dts changes, as we use separate > branches for those. > > Please send this again as two pull requests, one for the dts changes, and > one for the rest (pmu driver, binding and MAINTAINERS file). Please > also include an explanation in the tag description about why this gets > merged through arm-soc. I see that Will suggested doing it that way, > but I don't see what the reason is. We normally don't touch that directory. Hi Arnd, I am not clear about the reason either. Probably we don't have a dedicated tree for SoC PMU? Hi Will, Can you please comment? Regards, Duc Dang. > > Arnd > >> >> [1]: https://lkml.org/lkml/2016/7/15/563 >> [2]: https://lkml.org/lkml/2016/7/20/224 >> [3]: http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=893485e74c37669aeecf0b648dbfbd8e2f0471c3 >> ------ >> >> The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: >> >> Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) >> >> are available in the git repository at: >> >> https://github.com/AppliedMicro/xgene-next.git tags/xgene-dts-for-v4.9-part1 >> >> for you to fetch changes up to 1c983fc9369420748192712bde2429af3e580390: >> >> arm64: dts: apm: Add X-Gene SoC hwmon to device tree (2016-09-02 >> 10:43:41 -0700) >> >> ---------------------------------------------------------------- >> X-Gene DTS changes queued for v4.9 - part 1 >> >> This patch set includes: >> + X-Gene v1 SoC Performance Monitoring Unit (PMU) support >> + DTS entry to enable SoC PMU for X-Gene v2 SoC >> + PCIe legacy interrupt polarity fix for X-Gene >> + X-Gene SoC hwmon DTS entry >> > >
On Wed, Sep 14, 2016 at 06:57:59PM -0700, Duc Dang wrote: > On Wed, Sep 14, 2016 at 7:59 AM, Arnd Bergmann <arnd@arndb.de> wrote: > > On Friday, September 2, 2016 11:46:31 AM CEST Duc Dang wrote: > >> Hi Arnd, Olof, > >> > >> This is the first part of DTS changes for X-Gene platforms targeted for 4.9. > >> > >> The changes include: > >> + X-Gene Soc PMU support patch set from Tai Nguyen (v10 reviewed by > >> Mark, DT binding document acked by Rob [1] and was suggested to merge > >> via am-soc tree by Will [2]) > >> + Follow up patch to enable DT entry for SoC PMU on X-Gene v2 > >> + Correct PCIe legacy interrupt mode to level-active high > >> + DTS entry for X-Gene hwmon (v4 acked by Guenter, DT binding document > >> and driver is in linux-next now [3]) > >> > >> Regards, > >> Duc Dang. > > > > Sorry for the long delay, I've just now started looking at the dts changes > > for arm64. The changes to arch/arm64/boot/dts look fine, but I don't > > want to mix driver changes with dts changes, as we use separate > > branches for those. > > > > Please send this again as two pull requests, one for the dts changes, and > > one for the rest (pmu driver, binding and MAINTAINERS file). Please > > also include an explanation in the tag description about why this gets > > merged through arm-soc. I see that Will suggested doing it that way, > > but I don't see what the reason is. We normally don't touch that directory. > Hi Arnd, > > I am not clear about the reason either. Probably we don't have a > dedicated tree for SoC PMU? That's right, there isn't a dedicated tree for SoC PMUs. I tend to handle the architected PMUs (e.g. the ones in the CPUs), but other PMUs have been ad-hoc in the past. That said, Mark and I do tend to review PMU drivers, because the internal perf interface is pretty easy to get wrong. Arnd -- what would you like to see here? I could collect SoC PMU patches together and send you a pull request, or would you like me to take them via the arm64 tree? It's worth noting that we have PMU drivers under drivers/bus and drivers/hwtracing too, and I *think* arm-soc has handled those in the past. Will
On Thu, Sep 15, 2016 at 12:30 AM, Will Deacon <will.deacon@arm.com> wrote: > On Wed, Sep 14, 2016 at 06:57:59PM -0700, Duc Dang wrote: >> On Wed, Sep 14, 2016 at 7:59 AM, Arnd Bergmann <arnd@arndb.de> wrote: >> > On Friday, September 2, 2016 11:46:31 AM CEST Duc Dang wrote: >> >> Hi Arnd, Olof, >> >> >> >> This is the first part of DTS changes for X-Gene platforms targeted for 4.9. >> >> >> >> The changes include: >> >> + X-Gene Soc PMU support patch set from Tai Nguyen (v10 reviewed by >> >> Mark, DT binding document acked by Rob [1] and was suggested to merge >> >> via am-soc tree by Will [2]) >> >> + Follow up patch to enable DT entry for SoC PMU on X-Gene v2 >> >> + Correct PCIe legacy interrupt mode to level-active high >> >> + DTS entry for X-Gene hwmon (v4 acked by Guenter, DT binding document >> >> and driver is in linux-next now [3]) >> >> >> >> Regards, >> >> Duc Dang. >> > >> > Sorry for the long delay, I've just now started looking at the dts changes >> > for arm64. The changes to arch/arm64/boot/dts look fine, but I don't >> > want to mix driver changes with dts changes, as we use separate >> > branches for those. >> > >> > Please send this again as two pull requests, one for the dts changes, and >> > one for the rest (pmu driver, binding and MAINTAINERS file). Please >> > also include an explanation in the tag description about why this gets >> > merged through arm-soc. I see that Will suggested doing it that way, >> > but I don't see what the reason is. We normally don't touch that directory. >> Hi Arnd, >> >> I am not clear about the reason either. Probably we don't have a >> dedicated tree for SoC PMU? > > That's right, there isn't a dedicated tree for SoC PMUs. I tend to handle > the architected PMUs (e.g. the ones in the CPUs), but other PMUs have > been ad-hoc in the past. That said, Mark and I do tend to review PMU > drivers, because the internal perf interface is pretty easy to get wrong. > > Arnd -- what would you like to see here? I could collect SoC PMU patches > together and send you a pull request, or would you like me to take them via > the arm64 tree? It's worth noting that we have PMU drivers under drivers/bus > and drivers/hwtracing too, and I *think* arm-soc has handled those in the > past. We're fine taking the code, we just don't want the driver changes in the same branch as the DTS changes. -Olof
On Thursday, September 15, 2016 8:30:30 AM CEST Will Deacon wrote: > On Wed, Sep 14, 2016 at 06:57:59PM -0700, Duc Dang wrote: > > On Wed, Sep 14, 2016 at 7:59 AM, Arnd Bergmann <arnd@arndb.de> wrote: > > > On Friday, September 2, 2016 11:46:31 AM CEST Duc Dang wrote: > > > Please send this again as two pull requests, one for the dts changes, and > > > one for the rest (pmu driver, binding and MAINTAINERS file). Please > > > also include an explanation in the tag description about why this gets > > > merged through arm-soc. I see that Will suggested doing it that way, > > > but I don't see what the reason is. We normally don't touch that directory. > > Hi Arnd, > > > > I am not clear about the reason either. Probably we don't have a > > dedicated tree for SoC PMU? > > That's right, there isn't a dedicated tree for SoC PMUs. I tend to handle > the architected PMUs (e.g. the ones in the CPUs), but other PMUs have > been ad-hoc in the past. That said, Mark and I do tend to review PMU > drivers, because the internal perf interface is pretty easy to get wrong. > > Arnd -- what would you like to see here? I could collect SoC PMU patches > together and send you a pull request, or would you like me to take them via > the arm64 tree? It's worth noting that we have PMU drivers under drivers/bus > and drivers/hwtracing too, and I *think* arm-soc has handled those in the > past. I (and I suspect the same of Olof) don't understand enough about PMU drivers to be a good gatekeeper for PMU drivers, so I've had to rely on platform maintainers to know what they are doing when they sent me a driver in the past. I had not realized that we already have those drivers in multiple places, and that seems reason enough to get a maintainer for them who can review and apply the patches, as well as possibly consolidate them in once place. I don't mind forwarding the drivers to Linus in the next/drivers branch of arm-soc, like we do for drivers/reset which also has its own maintainer who picks up the patches to forward them to us. It would certainly help us if you can collect the changes and forward them, thanks a lot for the offer! Since I know you have a lot on your plate already, how about finding another co-maintainer who doesn't already own a subsystem but understands PMUs and could use some on-the-job training for this? For v4.9, I'd just take the pull request once Duc resends separate branches, and then we start a more formal procedure for v4.10 (or late if there are no PMU patches during that time). Arnd
On Thu, Sep 15, 2016 at 11:15:35AM +0100, Will Deacon wrote: > From 436d3a7ad25517433fc8f563f44fdab3c4801666 Mon Sep 17 00:00:00 2001 > From: Will Deacon <will.deacon@arm.com> > Date: Thu, 15 Sep 2016 10:14:41 +0100 > Subject: [PATCH] MAINTAINERS: Update ARM PMU PROFILING AND DEBUGGING entry > > There are an increasing number of ARM SoC PMU drivers appearing for > things like interconnects, memory controllers and cache controllers. > Rather than have these handled on an ad-hoc basis, where SoC maintainers > each send their PMU drivers directly to arm-soc, let's take these into > drivers/perf/ and send a single pull request to arm-soc instead, much > like other subsystems. > > This patch amends the ARM PMU MAINTAINERS entry to include all of > drivers/perf/ (currently just the ARM CPU PMU), changes Mark Rutland > from Reviewer to Maintainer, so that he can help with the new tree and > adds the device-tree binding to the list of maintained files. > > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Will Deacon <will.deacon@arm.com> FWIW: Acked-by: Mark Rutland <mark.rutland@arm.com> Mark. > --- > MAINTAINERS | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 6781a3febd59..090694e685ba 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -913,15 +913,16 @@ F: arch/arm/include/asm/floppy.h > > ARM PMU PROFILING AND DEBUGGING > M: Will Deacon <will.deacon@arm.com> > -R: Mark Rutland <mark.rutland@arm.com> > +M: Mark Rutland <mark.rutland@arm.com> > S: Maintained > F: arch/arm*/kernel/perf_* > F: arch/arm/oprofile/common.c > F: arch/arm*/kernel/hw_breakpoint.c > F: arch/arm*/include/asm/hw_breakpoint.h > F: arch/arm*/include/asm/perf_event.h > -F: drivers/perf/arm_pmu.c > +F: drivers/perf/* > F: include/linux/perf/arm_pmu.h > +F: Documentation/devicetree/bindings/arm/pmu.txt > > ARM PORT > M: Russell King <linux@armlinux.org.uk> > -- > 2.5.0 >
On Thursday, September 15, 2016 12:24:40 PM CEST Mark Rutland wrote: > On Thu, Sep 15, 2016 at 11:15:35AM +0100, Will Deacon wrote: > > From 436d3a7ad25517433fc8f563f44fdab3c4801666 Mon Sep 17 00:00:00 2001 > > From: Will Deacon <will.deacon@arm.com> > > Date: Thu, 15 Sep 2016 10:14:41 +0100 > > Subject: [PATCH] MAINTAINERS: Update ARM PMU PROFILING AND DEBUGGING entry > > > > There are an increasing number of ARM SoC PMU drivers appearing for > > things like interconnects, memory controllers and cache controllers. > > Rather than have these handled on an ad-hoc basis, where SoC maintainers > > each send their PMU drivers directly to arm-soc, let's take these into > > drivers/perf/ and send a single pull request to arm-soc instead, much > > like other subsystems. > > > > This patch amends the ARM PMU MAINTAINERS entry to include all of > > drivers/perf/ (currently just the ARM CPU PMU), changes Mark Rutland > > from Reviewer to Maintainer, so that he can help with the new tree and > > adds the device-tree binding to the list of maintained files. > > > > Cc: Mark Rutland <mark.rutland@arm.com> > > Cc: Arnd Bergmann <arnd@arndb.de> > > Signed-off-by: Will Deacon <will.deacon@arm.com> > > FWIW: > > Acked-by: Mark Rutland <mark.rutland@arm.com> > Acked-by: Arnd Bergmann <arnd@arndb.de>
Hi Arnd, Olof, This is the first part of DTS changes for X-Gene platforms targeted for 4.9. The changes include: + X-Gene Soc PMU support patch set from Tai Nguyen (v10 reviewed by Mark, DT binding document acked by Rob [1] and was suggested to merge via am-soc tree by Will [2]) + Follow up patch to enable DT entry for SoC PMU on X-Gene v2 + Correct PCIe legacy interrupt mode to level-active high + DTS entry for X-Gene hwmon (v4 acked by Guenter, DT binding document and driver is in linux-next now [3]) Regards, Duc Dang. [1]: https://lkml.org/lkml/2016/7/15/563 [2]: https://lkml.org/lkml/2016/7/20/224 [3]: http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=893485e74c37669aeecf0b648dbfbd8e2f0471c3 ------ The following changes since commit 29b4817d4018df78086157ea3a55c1d9424a7cfc: Linux 4.8-rc1 (2016-08-07 18:18:00 -0700) are available in the git repository at: https://github.com/AppliedMicro/xgene-next.git tags/xgene-dts-for-v4.9-part1 for you to fetch changes up to 1c983fc9369420748192712bde2429af3e580390: arm64: dts: apm: Add X-Gene SoC hwmon to device tree (2016-09-02 10:43:41 -0700) ---------------------------------------------------------------- X-Gene DTS changes queued for v4.9 - part 1 This patch set includes: + X-Gene v1 SoC Performance Monitoring Unit (PMU) support + DTS entry to enable SoC PMU for X-Gene v2 SoC + PCIe legacy interrupt polarity fix for X-Gene + X-Gene SoC hwmon DTS entry ---------------------------------------------------------------- Duc Dang (2): arm64: dts: apm: Add APM X-Gene v2 SoC PMU DTS entries arm64: dts: apm: Fix interrupt polarity for X-Gene PCIe legacy interrupts Tai Nguyen (4): MAINTAINERS: Add entry for APM X-Gene SoC PMU driver Documentation: Add documentation for APM X-Gene SoC PMU DTS binding perf: xgene: Add APM X-Gene SoC Performance Monitoring Unit driver arm64: dts: apm: Add APM X-Gene SoC PMU DTS entries hotran (1): arm64: dts: apm: Add X-Gene SoC hwmon to device tree .../devicetree/bindings/perf/apm-xgene-pmu.txt | 112 ++ Documentation/perf/xgene-pmu.txt | 48 + MAINTAINERS | 7 + arch/arm64/boot/dts/apm/apm-shadowcat.dtsi | 79 +- arch/arm64/boot/dts/apm/apm-storm.dtsi | 103 +- drivers/perf/Kconfig | 7 + drivers/perf/Makefile | 1 + drivers/perf/xgene_pmu.c | 1398 ++++++++++++++++++++ 8 files changed, 1727 insertions(+), 28 deletions(-) create mode 100644 Documentation/devicetree/bindings/perf/apm-xgene-pmu.txt create mode 100644 Documentation/perf/xgene-pmu.txt create mode 100644 drivers/perf/xgene_pmu.c