Message ID | 201010012117.o91LHCJt021158@imap1.linux-foundation.org |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: akpm@linux-foundation.org Date: Fri, 01 Oct 2010 14:17:12 -0700 > From: Andrew Morton <akpm@linux-foundation.org> > > ERROR: trailing statements should be on next line > #23: FILE: drivers/net/tulip/de4x5.c:5477: > + if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT; > > total: 1 errors, 0 warnings, 8 lines checked > > ./patches/drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl.patch has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. > > Please run checkpatch prior to sending patches > > Cc: Dan Rosenberg <dan.j.rosenberg@gmail.com> > Cc: Grant Grundler <grundler@parisc-linux.org> > Cc: Jeff Mahoney <jeffm@suse.com> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Applied to net-next-2.6 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -puN drivers/net/tulip/de4x5.c~drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes drivers/net/tulip/de4x5.c --- a/drivers/net/tulip/de4x5.c~drivers-net-tulip-de4x5c-fix-copy-length-in-de4x5_ioctl-checkpatch-fixes +++ a/drivers/net/tulip/de4x5.c @@ -5474,7 +5474,8 @@ de4x5_ioctl(struct net_device *dev, stru tmp.lval[6] = inl(DE4X5_STRR); j+=4; tmp.lval[7] = inl(DE4X5_SIGR); j+=4; ioc->len = j; - if (copy_to_user(ioc->data, tmp.lval, ioc->len)) return -EFAULT; + if (copy_to_user(ioc->data, tmp.lval, ioc->len)) + return -EFAULT; break; #define DE4X5_DUMP 0x0f /* Dump the DE4X5 Status */