Message ID | 1472781036-13547-1-git-send-email-fgao@ikuai8.com |
---|---|
State | Changes Requested |
Delegated to: | Pablo Neira |
Headers | show |
fgao@ikuai8.com <fgao@ikuai8.com> wrote: > From: Gao Feng <fgao@ikuai8.com> > > Print the warning log when fail to add seqadj extension like > nf_ct_acct_ext_add does. It could be helpful to find the problem. Failure to add ext area means that we're pretty much completely out of memory. There is nothing the user could do, so pr_warn (or any other log level ...) is not really helpful. Besides, memory subsystem will already print diagnostic information in that case. -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/net/netfilter/nf_conntrack_seqadj.h b/include/net/netfilter/nf_conntrack_seqadj.h index 4b33629..d548b9c 100644 --- a/include/net/netfilter/nf_conntrack_seqadj.h +++ b/include/net/netfilter/nf_conntrack_seqadj.h @@ -27,7 +27,13 @@ static inline struct nf_conn_seqadj *nfct_seqadj(const struct nf_conn *ct) static inline struct nf_conn_seqadj *nfct_seqadj_ext_add(struct nf_conn *ct) { - return nf_ct_ext_add(ct, NF_CT_EXT_SEQADJ, GFP_ATOMIC); + struct nf_conn_seqadj *seqadj = nf_ct_ext_add(ct, NF_CT_EXT_SEQADJ, + GFP_ATOMIC); + + if (!seqadj) + pr_warn("failed to add seqadj extension area"); + + return seqadj; } int nf_ct_seqadj_init(struct nf_conn *ct, enum ip_conntrack_info ctinfo,