Patchwork Fix format string warning in arch/powerpc/boot/main.c

login
register
mail settings
Submitter Jon Smirl
Date Oct. 31, 2008, 2:31 a.m.
Message ID <20081031023105.25877.93051.stgit@terra>
Download mbox | patch
Permalink /patch/6651/
State Superseded
Headers show

Comments

Jon Smirl - Oct. 31, 2008, 2:31 a.m.
Fix format string warning in arch/powerpc/boot/main.c

 BOOTCC  arch/powerpc/boot/main.o
arch/powerpc/boot/main.c: In function 'prep_kernel':
arch/powerpc/boot/main.c:65: warning: format '%08x' expects type
'unsigned int', but argument 3 has type 'long unsigned int'

Signed-off-by: Jon Smirl <jonsmirl@gmail.com>
---
 arch/powerpc/boot/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
David Gibson - Oct. 31, 2008, 2:34 a.m.
On Thu, Oct 30, 2008 at 10:31:05PM -0400, Jon Smirl wrote:
> Fix format string warning in arch/powerpc/boot/main.c
> 
>  BOOTCC  arch/powerpc/boot/main.o
> arch/powerpc/boot/main.c: In function 'prep_kernel':
> arch/powerpc/boot/main.c:65: warning: format '%08x' expects type
> 'unsigned int', but argument 3 has type 'long unsigned int'
> 
> Signed-off-by: Jon Smirl <jonsmirl@gmail.com>

Acked-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  arch/powerpc/boot/main.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/boot/main.c b/arch/powerpc/boot/main.c
> index ae32801..5afa1d4 100644
> --- a/arch/powerpc/boot/main.c
> +++ b/arch/powerpc/boot/main.c
> @@ -63,7 +63,7 @@ static struct addr_range prep_kernel(void)
>  		 */
>  		if ((unsigned long)_start < ei.loadsize)
>  			fatal("Insufficient memory for kernel at address 0!"
> -			       " (_start=%p, uncomressed size=%08x)\n\r",
> +			       " (_start=%p, uncomressed size=%08lx)\n\r",

Hrm.. of course.. that leaves the typo "uncomressed".  Apparently I
was having a bad day when I wrote that statement :-/.

Patch

diff --git a/arch/powerpc/boot/main.c b/arch/powerpc/boot/main.c
index ae32801..5afa1d4 100644
--- a/arch/powerpc/boot/main.c
+++ b/arch/powerpc/boot/main.c
@@ -63,7 +63,7 @@  static struct addr_range prep_kernel(void)
 		 */
 		if ((unsigned long)_start < ei.loadsize)
 			fatal("Insufficient memory for kernel at address 0!"
-			       " (_start=%p, uncomressed size=%08x)\n\r",
+			       " (_start=%p, uncomressed size=%08lx)\n\r",
 			       _start, ei.loadsize);
 
 		if ((unsigned long)_end < ei.memsize)