From patchwork Thu Sep 1 22:43:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolin Chen X-Patchwork-Id: 665067 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sQHNj4W3cz9s8x for ; Fri, 2 Sep 2016 08:43:49 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=XUsnBuvz; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751972AbcIAWns (ORCPT ); Thu, 1 Sep 2016 18:43:48 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:34135 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbcIAWnq (ORCPT ); Thu, 1 Sep 2016 18:43:46 -0400 Received: by mail-pf0-f195.google.com with SMTP id g202so4947688pfb.1; Thu, 01 Sep 2016 15:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Zk20iVfTbs5vwSHHCD2hxh5xOX5kpMZOzCI+zwq6XPY=; b=XUsnBuvz88CbhayRsFjWzd7w4gn60AOLgh7CTtBmoF8FSHJXL1Bkkk+m2TOdqD/EhK gPVnSvrGnnADh6iTNYx4B896G7rzqxS5ma/POKJnNArJLtBhlYBs9n1gO2ZOuD/0aCji 65whNEUG0dv4+lQ5F605OO4DhJva+7rTS3nIAf7dbwHL1ypQ4+ZgfNLdvS4w5cIhYtHw I+1Nm566mSoZyNfFHZYv1J8I5zRZ9/byOaYUBcUOLaS3+MLJ9wbCWFJW1etAXlLXxffR 5X+Q4C9unOmdNg5CUUzQibMcGOVtKx2jpjwsHnjvOf4nfe/ZGUDp0j/bgyNE/qY8DOwW BFVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Zk20iVfTbs5vwSHHCD2hxh5xOX5kpMZOzCI+zwq6XPY=; b=gcyJGDM88sbNhHsHIMTYhsZYbBjXY45oVplNH2XUaGXqXg+dpmFz0KVAcJAqEgJeTt EXwVfqxVxCeqbe0I8Maj4kIRhURxeJ/p7axFhvGraPkdAUOTuwjk6ARD2NlBLe6zYdmF ao8Riw/BPD325oDHPRQ65Ww/ZIdTS2Aja6m0SWMQWPs72JRVhKwPUgNLj1xnJ/JsIVhN Jg+2P4Tay1jcwkqGeY2y3onHvSX2aC/NzEG/abaFIVLXP0+/Qx2jFyFQguU7LG3GjV2X k3kFgQANRtir7VbaVUD0R3GsIzKsnlSBSfXA+x5nn0gFuK57PmxOiwPQd8aAKcL6twbH GNJQ== X-Gm-Message-State: AE9vXwNeeiCIkgXfh61p10qs8qubMvUquLT8xxFlqoIk/vwgN18uGY9fCe6mkAsp1ARwVw== X-Received: by 10.98.99.67 with SMTP id x64mr31285123pfb.26.1472769825726; Thu, 01 Sep 2016 15:43:45 -0700 (PDT) Received: from Asurada-Nvidia.nvidia.com (searspoint.nvidia.com. [216.228.112.21]) by smtp.gmail.com with ESMTPSA id s89sm9892349pfi.83.2016.09.01.15.43.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 01 Sep 2016 15:43:45 -0700 (PDT) From: Nicolin Chen To: vinod.koul@intel.com, jonathanh@nvidia.com Cc: linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, dmaengine@vger.kernel.org, gnurou@gmail.com, thierry.reding@gmail.com, swarren@wwwdotorg.org, ldewangan@nvidia.com Subject: [PATCH] dmaengine: tegra210-adma: Add some necessary dev_err() before error out Date: Thu, 1 Sep 2016 15:43:17 -0700 Message-Id: <1472769797-31650-2-git-send-email-nicoleotsuka@gmail.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1472769797-31650-1-git-send-email-nicoleotsuka@gmail.com> References: <1472769797-31650-1-git-send-email-nicoleotsuka@gmail.com> Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org There could be something going wrong during the probe() part, so it would not be ideal for debugging by silently returning. This patches adds some necessary dev_err() to give the hints. Signed-off-by: Nicolin Chen --- drivers/dma/tegra210-adma.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c index b10cbaa..09b46f7 100644 --- a/drivers/dma/tegra210-adma.c +++ b/drivers/dma/tegra210-adma.c @@ -218,8 +218,10 @@ static int tegra_adma_init(struct tegra_adma *tdma) ret = readx_poll_timeout(readl, tdma->base_addr + ADMA_GLOBAL_SOFT_RESET, status, status == 0, 20, 10000); - if (ret) + if (ret) { + dev_err(tdma->dev, "Timeout waiting for soft reset\n"); return ret; + } /* Enable global ADMA registers */ tdma_write(tdma, ADMA_GLOBAL_CMD, 1); @@ -581,6 +583,7 @@ static int tegra_adma_alloc_chan_resources(struct dma_chan *dc) ret = pm_runtime_get_sync(tdc2dev(tdc)); if (ret < 0) { + dev_err(tdc2dev(tdc), "failed to get pm runtime: %d\n", ret); free_irq(tdc->irq, tdc); return ret; } @@ -647,8 +650,10 @@ static int tegra_adma_runtime_resume(struct device *dev) int ret; ret = pm_clk_resume(dev); - if (ret) + if (ret) { + dev_err(dev, "failed to resume pm clock: %d\n", ret); return ret; + } tdma_write(tdma, ADMA_GLOBAL_CMD, tdma->global_cmd); @@ -718,6 +723,9 @@ static int tegra_adma_probe(struct platform_device *pdev) tdc->irq = of_irq_get(pdev->dev.of_node, i); if (tdc->irq < 0) { + dev_err(&pdev->dev, + "failed to get irq for channel %d: %d\n", + i + 1, tdc->irq); ret = tdc->irq; goto irq_dispose; }