Message ID | 1472724886-28301-2-git-send-email-bharatku@xilinx.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <linux-pci-owner@vger.kernel.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sPz5q2x38z9s8x for <incoming@patchwork.ozlabs.org>; Thu, 1 Sep 2016 20:29:51 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b=Gy8CREpY; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932705AbcIAK3u (ORCPT <rfc822;incoming@patchwork.ozlabs.org>); Thu, 1 Sep 2016 06:29:50 -0400 Received: from mail-dm3nam03on0065.outbound.protection.outlook.com ([104.47.41.65]:30632 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932568AbcIAK3t (ORCPT <rfc822;linux-pci@vger.kernel.org>); Thu, 1 Sep 2016 06:29:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=pnWrHVQtUrwgIWdC6Rl5r0X+HLlCVqmG/l1nDOk7AR4=; b=Gy8CREpYDqr/xXB+vmp5vzlQZqcJobTLb8iQa0zgmr/15jgx3poYQcLUm0gX2ocFa0MEIOwfv+AQTGDC2eGPoep1xIxmLriDiwYAbB6MSZGnz6sZq5kHiymq2TVWvzE7qETjomgsfOON5v5caMSOa0Kdr9/yG/VQDQZsJjfeu+I= Received: from BN6PR02CA0069.namprd02.prod.outlook.com (10.175.94.159) by BLUPR0201MB1473.namprd02.prod.outlook.com (10.163.119.151) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9; Thu, 1 Sep 2016 10:15:05 +0000 Received: from SN1NAM02FT019.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e44::209) by BN6PR02CA0069.outlook.office365.com (2603:10b6:404:f9::31) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.587.13 via Frontend Transport; Thu, 1 Sep 2016 10:15:05 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; wanadoo.fr; dkim=none (message not signed) header.d=none;wanadoo.fr; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by SN1NAM02FT019.mail.protection.outlook.com (10.152.72.130) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.587.6 via Frontend Transport; Thu, 1 Sep 2016 10:15:05 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from <bharat.kumar.gogada@xilinx.com>) id 1bfP1S-000392-FY; Thu, 01 Sep 2016 03:15:02 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from <bharat.kumar.gogada@xilinx.com>) id 1bfP1S-0002Ls-4X; Thu, 01 Sep 2016 03:15:02 -0700 Received: from xsj-pvapsmtp01 (xsj-mail.xilinx.com [149.199.38.66]) by xsj-smtp-dlp2.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id u81AEpJI001824; Thu, 1 Sep 2016 03:14:51 -0700 Received: from [172.23.64.217] (helo=xhd-lin64re105.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from <bharatku@xilinx.com>) id 1bfP1G-0002Ia-VX; Thu, 01 Sep 2016 03:14:51 -0700 Received: by xhd-lin64re105.xilinx.com (Postfix, from userid 45489) id BC8CBCA1C4F; Thu, 1 Sep 2016 15:44:49 +0530 (IST) From: Bharat Kumar Gogada <bharat.kumar.gogada@xilinx.com> To: <bhelgaas@google.com>, <soren.brinkmann@xilinx.com>, <christophe.jaillet@wanadoo.fr>, <grygorii.strashko@ti.com>, <yinghai@kernel.org>, <lorenzo.pieralisi@arm.com>, <fengguang.wu@intel.com>, <michal.simek@xilinx.com>, <arnd@arndb.de> CC: <linux-arm-kernel@lists.infradead.org>, <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <rgummal@xilinx.com>, Bharat Kumar Gogada <bharatku@xilinx.com> Subject: [PATCH 2/6] PCI: Xilinx : Clear interrupt register for invalid interrupt. Date: Thu, 1 Sep 2016 15:44:42 +0530 Message-ID: <1472724886-28301-2-git-send-email-bharatku@xilinx.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1472724886-28301-1-git-send-email-bharatku@xilinx.com> References: <1472724886-28301-1-git-send-email-bharatku@xilinx.com> X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-22548.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(199003)(189002)(48376002)(42186005)(5660300001)(107886002)(2950100001)(45336002)(46386002)(106466001)(626004)(90966002)(33646002)(8676002)(36756003)(86362001)(356003)(19580395003)(8936002)(19580405001)(7846002)(87936001)(189998001)(81156014)(305945005)(52956003)(47776003)(7416002)(229853001)(5001770100001)(76176999)(81166006)(50466002)(2906002)(36386004)(63266004)(50986999)(50226002)(5003940100001)(103686003)(4326007)(4001430100002)(2201001)(92566002)(586003)(11100500001)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0201MB1473; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; PTR:unknown-60-83.xilinx.com; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; SN1NAM02FT019; 1:ryHJ5Fh59+y+K9MEU4jDBMswOtO45ZRar0cGRf2TNnOPi5LVPTsy0jmaF+vdrNOSrpmtkTNAczAAeLontyBah1ROyHm7gKtshxo8+WS/WXN3WnWHhAoYE/n3hGuiA9eZSjvxPnjhxqKOZL4gGt1anknPsPJon6Xkli6YDxHsnbB4THoLjnp51EC6kfyh38dUN0K/sTf9TUN+Fea23ncY+zpv1omRnYKum2KKcUvxW6tXuVrKLJnjciP+l7kvtpy4m1pId1VnrIe7Puhgt3Yzy3eFpFn7r8Hxwtwb/8o7e9tAa0tOKUSB9dzdsdxKXzWuTsgx7NQhKLrS2OV5+u1NN4DVPinZtjfKydiGmBtuU8F+yD3tePVqf3jdnoALgnQBD0BT8y2SakBFnAmoi067gOZHBPaT0JJ8KDHQU1T0KHvqe7LlXtXbsLzWj4nZ251EOHUIsfulm26VO6whp2oWVRZwIEljNqkUudV8oGx2X3W3b4HVRKO39lJt/Q0kgYSLX1OPGB3NbcpkneCHxGx1dmofArffVpvAq9Ieo4rsGx37RcOh6FDBGY9TXILwc54+5K5hdMM+yDVMTPTGtbGA3Uo5MOIDGgv9cbhV2FDhYRmit1vBnPsD35Gky02acXBQAHe1xAOZWlO6uVY3ZITjsA== MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 83e7dbca-9ad6-4c11-87b4-08d3d250d827 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1473; 2:vnCIbcweK5L5lDgyQNCtvT4x9DFBnWFkBUXyXBvhyCfEqd6lLPWUrUtKra3o0egRLK1ZSHGB/VB9C+HiLwem674KSTJkoXAcI1/8OtTT2GHYVisqYhVQo5g/kR29jXqVyxk4ZrAZ3FYFYq3rxRMZHHofD2WTjPhvE0DvG9O/aF/MkwrU9mLsgd4fL+m4vQRR; 3:d5xwiSExCq7bh4X/syEheXJImjHGjxarwnqWfjJUQTcgOGWvpv/cEbozmpmNVVSYKy8oPMWcNT2SMAXIMKUMDHzEYczs1kPhM2xfh34LvDyq+bSJZpS0c7D+HSblTeSljpx/FNd9qssj8xMdJHW6sSIslBXAuN9G7iB8sNycKtfg9z3dqURaaMVTH1hknF0VlbtuQaRn3DyfKvh+e60q556j6PEbV1RyZ1USBlNnkiB4pbeA+j1stm+Exy5LoWglCwgYwaGx81dhZTkDXPV9XA==; 25:dyVy9W4ktm+91g7fBxMf0pkym7OSkZJHK4vtxp8o6Udih7GcTZrg/aE8xdHmlwRGV0ZTqsbbgEVz1b3UzKn5Kkc3oBShf9sWhMjl7zmsQ1HWZ8JsllxpZ0MyPyPIvnZy07xPeqkZwkz+OTOiTrTb+79BFqMGoD8yFsO+I5AOqLKd3p4MXk3+VuNftQpWEL6DIhkn+zcOuEOcYEAnw8kGieqV1IPxxAHUll72lGOmMpgeVg/qLoUCfiXXcwjGWiTHct+dlqhhOHAfEPD9rQMkVfy9JVQ0mxfwObBJGPnC+yYopLaqaGGJtpjAbX76L7Ev67GjDFBKOsh4dRE0+lUzb4/KiF4szZGdgwo0ab5kjvJvHVoqCVqz6W5y6w1pNvHPCmNNb2DehirKjX1wa25Qe4UbsgtMBCRlL3ycE+9RqCM= X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(8251501002); SRVR:BLUPR0201MB1473; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1473; 31:u1TwMkV8yWEvBhecEVpUnFxT/Fb6DHw92qMyKSvCsDiMsGD0tJdCxuD3WeCkqWVmxfKsEQgxZ+XPX8jZ5sd2E7v/mdtfDsgv7x65za+qiOGSB/vYAfYFUiAwWJQPa166AKwu3EdiFrkAe7fGwi6rUruX898L7CDiBbGAW6D3UzfpDc5cEjnFvx9uiJ+Y8jOzueXlh1pk08urgoDnFLYzkO3CRDy988FBUrml2QYv5rI=; 20:MDEjkEmfD99I/all4Nxw9e7gYorX5vC4t3oxVHmLDoMNVJImhsfOVeKf3IazY15QLhuDH87pA5iy8jFYrADTEXWhGG+tHD9O2KzA82s6Jvwv0LDhjUve7q0sh7RR0JUamlLxGdQY2Z6A8PdOFv+aiBBMyWz3SlSt9k0i0KWodm7KbftuBw2gfsZU6IaqcuyMuc8zEBaLcR/nK8WTWDRAca8xjH1Df/YL7GfXXvuBI6auzQ7ZbhGk079SUkyRQs2eWgs7AN9Y4T5LH8frPsfmXsTyTU9QeDgYndglHdymDUA6dLBcOEfBylBtm9av7fNVnO+d8jk7q3HG3ohljJMICPpYMPBokbkPvh9cFKWr1qt5c7UjAz/KgkwzXB7MaVlCar61Xnw9OyMuEDkjGWpV4eeaZtCmDls1nbDC1fBLHJAPklh+Q1x53xZY8aKYhkdhjYV7c9b+CTHB7aIk5mhKlxw++J+1sOz1N7d2kcs9ASYFta+/CSGEGhDIw0zDH4jM X-Microsoft-Antispam-PRVS: <BLUPR0201MB1473FBF632462A14C6D229E4D0E20@BLUPR0201MB1473.namprd02.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(13015025)(13017025)(13023025)(13024025)(13018025)(3002001)(10201501046)(6055026); SRVR:BLUPR0201MB1473; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0201MB1473; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1473; 4:cwWaEB+wGQ8ezh9HEJYxu9BvmDfCOEJrPM0exD+Xda96m5vKxqf8pZLwHalU0w2Szumj+Azr9p/qbx98Jc3gYoFXj0/lO0fR9bGVpeqPtBptoViTdf9U9oXyVxPgZ00c4VBnYpbKYcHxgfRuRFiuXTO9ezpMgfpvwJtfR2oFd8X5CKaX+eOoQDcPr3Mko3vR5vGIDzb+R+d01W/eLZMWAevmyVvezrtnNYFMmQNrFkDG3tw6s5wPVphJ0dL29fD33zm7bg+DCh3hM1FAG8WWyq4fqEWNdigvTl44eQvnOFS/jaHXt8faLYv1grp2+3HcqdxaXNv8Cq+ojhtzJX+pv05UPIwTY4KjX8w8ms4RQAwiT/aSgo97FwlcsE7EKN+MWp+BKc9UVFVfrtA62AeyY6rFT89Pk55fUegOEB2G60ORhd7+8uF/mArDWktkfQN7Ri4o1sfjsquRQZCZq1BMJ6cKjGo3pzy0GNsMJxUfBu7Tq/70gAFBWC0sdkbBJMEXIK9+HOVNSAryhtQ2T0dTsRZ/hKHdRNhZv2zDEP2Ptm8= X-Forefront-PRVS: 0052308DC6 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0201MB1473; 23:P4P8ueGMnNDPpwtszS9tCWpdcQ+AU8NgcvKvDoY?= =?us-ascii?Q?VMtHyrTX4fGGViTuephCC0UNEn5oMPGhUWf39z3ES11dMe6QcHDTqYB+uNJx?= =?us-ascii?Q?TxDwEYN2payV0dkY0CDG3iQk8jTymQNOSQgV++hUMSNV80eP1/Ygh4XRpRU+?= =?us-ascii?Q?3L1pIgfgSGXC2xD9Uph2gRwE2NawTla3uJB0wvAGqkyJyHOyVNyMiXbKoFaj?= =?us-ascii?Q?o00AZrmI/H8Gt/ctmPGrE7WBoQt++p9vx61n92JnjFItO3F0YMNUT4LofO2N?= =?us-ascii?Q?ovVKWODcg/1C0EIw/baMPr4+QOdLLGUVvyctmt3379j+akeOI2mYoMI59gIK?= =?us-ascii?Q?hwP+3jnYhiTI+ZBxeFSblv6CxxjD67ofDYLo5uh7XxUpNMgVhcPWKts+BD8S?= =?us-ascii?Q?OIHnH9V6F/jIOQsSApZh8BsGy9RkXDF6Aa/0Aou1UHI+OESPZxdrBeRCrt3g?= =?us-ascii?Q?gXTEj8YQFrHJ7KhJ7u9x3eVf+M0ZlqkC3cg3YUmQYcOu/+wDSxJjM5LHa6kb?= =?us-ascii?Q?7dYDIePXM2iUkZzFxsKdCVLDdpTJloEh9JNAF2NxmXaOA1SzIQQDwRS9y265?= =?us-ascii?Q?Wma/qGKY7dmCCTOs8KO8FgZhEMYWRCPxB5rZInNDacaMr64c57/rjhbZoxto?= =?us-ascii?Q?09BX0npECjpq4eYdjSQjcYgtFxeljJyR1L4Tm0iVItwzy9TK1Jb01NWzllKf?= =?us-ascii?Q?VEPoxyTCkMe56cUFx3ps/ChSbzNB8/GoewjsPjWXnzypww3r62dnNRRT8uBV?= =?us-ascii?Q?Pwx936K8GoytzJjzW9xuePlg1XTMaGjC8zImvzWovNAbkOmkbRS5/FOU0VPz?= =?us-ascii?Q?PI7/vrr0ZN9/wTHFN8/Jy4RwBbaHhq3x0Yw9TcyB88rPgcgnsV4A7eDFUD1o?= =?us-ascii?Q?MdhRcAjDz6B/4vKW6SgiEpLQfuXLaRKwCic0PZlAKYnFbNo696QSKrv8pkzN?= =?us-ascii?Q?0N2nLYzNuEyX7r69itmRaT2Akm/61OQODFIPw6moIf9RfWmTx7NODK0ryNZ6?= =?us-ascii?Q?E+65GbDrVprEQBTYOp9ym9hUaKk8tE7fXk3zl6GhjmRAqJnkdQ2BNmThmKAP?= =?us-ascii?Q?nlXOTN+8ArkJXo0gledFFWnMg2h71sJT28iQFtnQW8hxBNQ7SWdWem5c0xX3?= =?us-ascii?Q?Iidg28H47Y0wTUii/HQSTfiOTYJVqcMz+9gKQTidpy3Rs5/XvGKOgef7eWB6?= =?us-ascii?Q?5md/qSgBwnyOWHo37s8gYqh2yd+i/b+WXtP38U/ceIAA/5TqeDgHTaqR8Xrl?= =?us-ascii?Q?Gaa7NpxXRn2Av8Xqqqw8=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0201MB1473; 6:wG/1mWrnwCBswSE7iCwkAjcHE3Kyv+jLkZj2GvNuSJcPjtoHnlYhR3SW6K0OhiwqXixecNu+nbNwBlXXEaVBp2SEhSaIPiuCuin4uUC3blJx1pz4Fv/d7I5CRPCrRYKh7C7XwIRrvz6gJzpZnpIAolfdgko2F19Z3YLA0LNQBoZzuo2wZ9pWfP2giDx/96gpxq8VZhB46lXKMuAeBaJbUwuI6wprsW1vUVh3sBd5I1I9g0bNjDCXyvl6G9eKfoU7Za5ZkGQzG2a/n4EfGYpPvAYM8IngCZHG7x1gqWoHr2vjnrtn8ickBjtBUDfvHcmaEejM4J8Z7D2etWMaAbQkZg==; 5:AZhJOiHs/uTYfrshoAHvo3gRs47Ilioes1vQ94hpJiH1jFYoVBPeSjU8nx9+668TWbHSQYFj6BvB6H8IYixyqBeBd/B4bewjm3uuPUqDKrZGZQAQyHgfgQJonWbZTOJVjB0L02eIQAvRUbXwzWis1A==; 24:LcitNM3nC81OObsKv/UeqLZOthmIsy07HDkmrSeTGEJ0yKrj6QWq5gM9a+LlviO3VMy5mhA8oH2oSF+OlKiesowfInCPK3liIC/umQp77zg=; 7:uquQ9hJQecMrAftOvefovpAxiBB5OnaR8aY1HS4zgp7iW2vp34spM9g/fi0ZkBEcPq9cGZn5Z+QWq0MbZjSmyfppFzoW5nz1chjFp0BLfPEQs8eKU33Vi4I7Mo40yb0Q3pociI93HVFe67DsBbx6O2fH2iaNe+s8Y5OiayXjYuDC+G8m3EOVGgpPjwzknGjoHzFraRtI09lSAnsZS8iZ/Q/sRl9LF6Md+c49TrVJkE9EGSezpusA1owL4XSLCVmT SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2016 10:15:05.0995 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0201MB1473 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: <linux-pci.vger.kernel.org> X-Mailing-List: linux-pci@vger.kernel.org |
diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c index bd64677..de1c758 100644 --- a/drivers/pci/host/pcie-xilinx.c +++ b/drivers/pci/host/pcie-xilinx.c @@ -434,7 +434,7 @@ static irqreturn_t xilinx_pcie_intr_handler(int irq, void *data) /* Check whether interrupt valid */ if (!(val & XILINX_PCIE_RPIFR1_INTR_VALID)) { dev_warn(port->dev, "RP Intr FIFO1 read error\n"); - return IRQ_HANDLED; + goto error; } if (!(val & XILINX_PCIE_RPIFR1_MSI_INTR)) { @@ -456,7 +456,7 @@ static irqreturn_t xilinx_pcie_intr_handler(int irq, void *data) if (!(val & XILINX_PCIE_RPIFR1_INTR_VALID)) { dev_warn(port->dev, "RP Intr FIFO1 read error\n"); - return IRQ_HANDLED; + goto error; } if (val & XILINX_PCIE_RPIFR1_MSI_INTR) { @@ -501,6 +501,7 @@ static irqreturn_t xilinx_pcie_intr_handler(int irq, void *data) if (status & XILINX_PCIE_INTR_MST_ERRP) dev_warn(port->dev, "Master error poison\n"); +error: /* Clear the Interrupt Decode register */ pcie_write(port, status, XILINX_PCIE_REG_IDR);
The interrupt decode register is not being cleared if an invalid interrupt arises. This patch adds checks and clears decode register in this case. Signed-off-by: Bharat Kumar Gogada <bharatku@xilinx.com> --- drivers/pci/host/pcie-xilinx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)