From patchwork Fri Oct 1 18:19:13 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 66478 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0E485B70DF for ; Sat, 2 Oct 2010 04:26:53 +1000 (EST) Received: from localhost ([127.0.0.1]:40601 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P1kJm-0001Vm-3P for incoming@patchwork.ozlabs.org; Fri, 01 Oct 2010 14:26:50 -0400 Received: from [140.186.70.92] (port=49496 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P1kDU-00068f-LD for qemu-devel@nongnu.org; Fri, 01 Oct 2010 14:20:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P1kD3-0003KS-4t for qemu-devel@nongnu.org; Fri, 01 Oct 2010 14:20:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P1kD2-0003KI-TH for qemu-devel@nongnu.org; Fri, 01 Oct 2010 14:19:53 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o91IJqFI021028 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Oct 2010 14:19:52 -0400 Received: from localhost (ovpn-113-58.phx2.redhat.com [10.3.113.58]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o91IJpW1022325; Fri, 1 Oct 2010 14:19:51 -0400 From: Luiz Capitulino To: aliguori@us.ibm.com Date: Fri, 1 Oct 2010 15:19:13 -0300 Message-Id: <1285957167-1228-10-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1285957167-1228-1-git-send-email-lcapitulino@redhat.com> References: <1285957167-1228-1-git-send-email-lcapitulino@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.16 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] [PATCH 09/23] Monitor: Convert do_info() back to HMP X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This is a HMP specific handler, it makes no sense to have it under QMP. Signed-off-by: Luiz Capitulino --- monitor.c | 5 ++--- qemu-monitor.hx | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/monitor.c b/monitor.c index 7f2af49..f0854c4 100644 --- a/monitor.c +++ b/monitor.c @@ -636,7 +636,7 @@ static void user_async_info_handler(Monitor *mon, const mon_cmd_t *cmd) } } -static int do_info(Monitor *mon, const QDict *qdict, QObject **ret_data) +static void do_info(Monitor *mon, const QDict *qdict) { const mon_cmd_t *cmd; const char *item = qdict_get_try_str(qdict, "item"); @@ -668,11 +668,10 @@ static int do_info(Monitor *mon, const QDict *qdict, QObject **ret_data) cmd->mhandler.info(mon); } - return 0; + return; help: help_cmd(mon, "info"); - return 0; } static void do_info_version_print(Monitor *mon, const QObject *data) diff --git a/qemu-monitor.hx b/qemu-monitor.hx index 49bcd8d..57d28ac 100644 --- a/qemu-monitor.hx +++ b/qemu-monitor.hx @@ -1654,8 +1654,7 @@ EQMP .args_type = "item:s?", .params = "[subcommand]", .help = "show various information about the system state", - .user_print = monitor_user_noop, - .mhandler.cmd_new = do_info, + .mhandler.cmd = do_info, }, STEXI