From patchwork Wed Aug 31 22:35:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. Murphy" X-Patchwork-Id: 664698 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sPgGW5RJsz9s9G for ; Thu, 1 Sep 2016 08:36:19 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=S9Hdz0fK; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:subject:to:cc:date:mime-version :content-type:content-transfer-encoding:message-id; q=dns; s= default; b=rWwCVdTNon56PVR0v4Bh/CL3fh94+67RRR+nOLkwtCG/bDzMmne7P xj7+0/O5NqrPPUatlCjULC0Y5cegvOfhaD+E5r33H37NF3C1xW6V5Gc7C25uARkR nB+2qy//Xf5q6wRdnhuBqiAyZXSmdLaEf66JHN0L3LHWrxFmzl3WBk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:subject:to:cc:date:mime-version :content-type:content-transfer-encoding:message-id; s=default; bh=O85AvjVz8ABL29Hvv4mB+C3vemo=; b=S9Hdz0fK9269WIsOTllMSNqTnpMi pFyZ/FafHR8ObJ3Uf48Of5TkZf2zaBFCEij1cScKAtuHDY2zEvGQQMJGeErUAo2z GPmgj9vT+0424gcI3uTBAOYSMeMT2qYAaMURNPKpPvks0WjlcpTO79ggpl/xH9iw m0Bs09wL+Unkkwg= Received: (qmail 2537 invoked by alias); 31 Aug 2016 22:36:14 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 2135 invoked by uid 89); 31 Aug 2016 22:36:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.4 required=5.0 tests=AWL, BAYES_50, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, RCVD_IN_SEMBACKSCATTER autolearn=no version=3.3.2 spammy=2.4.11, prototypes, prec, sk:__kerne X-HELO: mx0a-001b2d01.pphosted.com X-IBM-Helo: d01dlp02.pok.ibm.com X-IBM-MailFrom: murphyp@linux.vnet.ibm.com From: "Paul E. Murphy" Subject: [PATCH] Remove unneeded stubs for k_rem_pio2l. To: "libc-alpha@sourceware.org" Cc: Joseph Myers Date: Wed, 31 Aug 2016 17:35:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16083122-0044-0000-0000-00000111925F X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005688; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000184; SDB=6.00752279; UDB=6.00355664; IPR=6.00525090; BA=6.00004683; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012539; XFM=3.00000011; UTC=2016-08-31 22:36:01 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16083122-0045-0000-0000-000005289947 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-08-31_05:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608310255 As noted by Joseph in https://sourceware.org/ml/libc-alpha/2016-08/msg00927.html It is simpler to just tweak math/Makefile, and remove the unused declaration from math_private.h. ---8<--- This is only used for the float and double variants. Instead, just add it to the type specific list of files, and remove all stubs, and remove the declaration from math_private.h. I verified x86_64, i486, ia64, m68k, and ppc64 build. * math/Makefile (libm-calls): Remove k_rem_pio2F. (type-double-routines): Add k_rem_pio2. (type-float-routines): Add k_rem_pio2f. * sysdeps/generic/math_private.h: (__kernel_rem_pio2l): Removed. * math/k_rem_pio2l.c: Removed. * sysdeps/i386/fpu/k_rem_pio2l.c: Removed. * sysdeps/ia64/fpu/k_rem_pio2l.c: Removed. * sysdeps/m68k/m680x0/fpu/k_rem_pio2l.c: Removed. * sysdeps/x86_64/fpu/k_rem_pio2l.c: Removed. --- math/Makefile | 6 +++--- math/k_rem_pio2l.c | 15 --------------- sysdeps/generic/math_private.h | 2 -- sysdeps/i386/fpu/k_rem_pio2l.c | 3 --- sysdeps/ia64/fpu/k_rem_pio2l.c | 1 - sysdeps/m68k/m680x0/fpu/k_rem_pio2l.c | 3 --- sysdeps/x86_64/fpu/k_rem_pio2l.c | 1 - 7 files changed, 3 insertions(+), 28 deletions(-) delete mode 100644 math/k_rem_pio2l.c delete mode 100644 sysdeps/i386/fpu/k_rem_pio2l.c delete mode 100644 sysdeps/ia64/fpu/k_rem_pio2l.c delete mode 100644 sysdeps/m68k/m680x0/fpu/k_rem_pio2l.c delete mode 100644 sysdeps/x86_64/fpu/k_rem_pio2l.c diff --git a/math/Makefile b/math/Makefile index c0d7ff0..6a90a36 100644 --- a/math/Makefile +++ b/math/Makefile @@ -56,7 +56,7 @@ libm-calls = \ e_hypotF e_j0F e_j1F e_jnF e_lgammaF_r e_logF e_log10F e_powF \ e_rem_pio2F e_remainderF e_scalbF e_sinhF e_sqrtF e_gammaF_r \ e_ilogbF \ - k_cosF k_rem_pio2F k_sinF k_tanF s_asinhF s_atanF s_cbrtF \ + k_cosF k_sinF k_tanF s_asinhF s_atanF s_cbrtF \ s_ceilF s_cosF s_erfF s_expm1F s_fabsF \ s_floorF s_log1pF w_log1pF s_logbF \ s_nextafterF s_nexttowardF s_rintF s_scalblnF w_scalblnF \ @@ -99,11 +99,11 @@ type-ldouble-yes := ldouble type-double-suffix := type-double-routines := branred doasin dosincos halfulp mpa mpatan2 \ mpatan mpexp mplog mpsqrt mptan sincos32 slowexp \ - slowpow sincostab + slowpow sincostab k_rem_pio2 # float support type-float-suffix := f -type-float-routines := +type-float-routines := k_rem_pio2f # Apply suffix to each type in arg 1 diff --git a/math/k_rem_pio2l.c b/math/k_rem_pio2l.c deleted file mode 100644 index 01bf158..0000000 --- a/math/k_rem_pio2l.c +++ /dev/null @@ -1,15 +0,0 @@ -#include -#include -#include -#include - -int -__kernel_rem_pio2l (long double *x, long double *y, int e0, int nx, int prec, - const int *ipio2) -{ - fputs ("__kernel_rem_pio2l not implemented\n", stderr); - __set_errno (ENOSYS); - return 0.0; -} - -stub_warning (__kernel_rem_pio2l) diff --git a/sysdeps/generic/math_private.h b/sysdeps/generic/math_private.h index cf1865d..24adcfb 100644 --- a/sysdeps/generic/math_private.h +++ b/sysdeps/generic/math_private.h @@ -317,8 +317,6 @@ extern long double __kernel_cosl (long double,long double); extern long double __kernel_tanl (long double,long double,int); extern void __kernel_sincosl (long double,long double, long double *,long double *, int); -extern int __kernel_rem_pio2l (long double*,long double*,int,int, - int,const int*); #ifndef NO_LONG_DOUBLE /* prototypes required to compile the ldbl-96 support without warnings */ diff --git a/sysdeps/i386/fpu/k_rem_pio2l.c b/sysdeps/i386/fpu/k_rem_pio2l.c deleted file mode 100644 index 1347b04..0000000 --- a/sysdeps/i386/fpu/k_rem_pio2l.c +++ /dev/null @@ -1,3 +0,0 @@ -/* Empty. This file is only meant to avoid compiling the file with the - same name in the libm-ieee754 directory. The code is not used since - there is an assembler version for all users of this file. */ diff --git a/sysdeps/ia64/fpu/k_rem_pio2l.c b/sysdeps/ia64/fpu/k_rem_pio2l.c deleted file mode 100644 index 41254ae..0000000 --- a/sysdeps/ia64/fpu/k_rem_pio2l.c +++ /dev/null @@ -1 +0,0 @@ -/* Not needed. */ diff --git a/sysdeps/m68k/m680x0/fpu/k_rem_pio2l.c b/sysdeps/m68k/m680x0/fpu/k_rem_pio2l.c deleted file mode 100644 index 1347b04..0000000 --- a/sysdeps/m68k/m680x0/fpu/k_rem_pio2l.c +++ /dev/null @@ -1,3 +0,0 @@ -/* Empty. This file is only meant to avoid compiling the file with the - same name in the libm-ieee754 directory. The code is not used since - there is an assembler version for all users of this file. */ diff --git a/sysdeps/x86_64/fpu/k_rem_pio2l.c b/sysdeps/x86_64/fpu/k_rem_pio2l.c deleted file mode 100644 index eea55a9..0000000 --- a/sysdeps/x86_64/fpu/k_rem_pio2l.c +++ /dev/null @@ -1 +0,0 @@ -/* Not needed. */