Remove unneeded stubs for k_rem_pio2l.
diff mbox

Message ID a323c28c-720c-d552-c040-424ae236aa67@linux.vnet.ibm.com
State New
Headers show

Commit Message

Paul E. Murphy Aug. 31, 2016, 10:35 p.m. UTC
As noted by Joseph in
https://sourceware.org/ml/libc-alpha/2016-08/msg00927.html

It is simpler to just tweak math/Makefile, and remove the
unused declaration from math_private.h.

---8<---
This is only used for the float and double variants.

Instead, just add it to the type specific list of files,
and remove all stubs, and remove the declaration from
math_private.h.

I verified x86_64, i486, ia64, m68k, and ppc64 build.

	* math/Makefile (libm-calls): Remove k_rem_pio2F.
	(type-double-routines): Add k_rem_pio2.
	(type-float-routines): Add k_rem_pio2f.

	* sysdeps/generic/math_private.h:
	(__kernel_rem_pio2l): Removed.

	* math/k_rem_pio2l.c: Removed.
	* sysdeps/i386/fpu/k_rem_pio2l.c: Removed.
	* sysdeps/ia64/fpu/k_rem_pio2l.c: Removed.
	* sysdeps/m68k/m680x0/fpu/k_rem_pio2l.c: Removed.
	* sysdeps/x86_64/fpu/k_rem_pio2l.c: Removed.
---
 math/Makefile                         |  6 +++---
 math/k_rem_pio2l.c                    | 15 ---------------
 sysdeps/generic/math_private.h        |  2 --
 sysdeps/i386/fpu/k_rem_pio2l.c        |  3 ---
 sysdeps/ia64/fpu/k_rem_pio2l.c        |  1 -
 sysdeps/m68k/m680x0/fpu/k_rem_pio2l.c |  3 ---
 sysdeps/x86_64/fpu/k_rem_pio2l.c      |  1 -
 7 files changed, 3 insertions(+), 28 deletions(-)
 delete mode 100644 math/k_rem_pio2l.c
 delete mode 100644 sysdeps/i386/fpu/k_rem_pio2l.c
 delete mode 100644 sysdeps/ia64/fpu/k_rem_pio2l.c
 delete mode 100644 sysdeps/m68k/m680x0/fpu/k_rem_pio2l.c
 delete mode 100644 sysdeps/x86_64/fpu/k_rem_pio2l.c

Comments

Joseph Myers Aug. 31, 2016, 10:40 p.m. UTC | #1
On Wed, 31 Aug 2016, Paul E. Murphy wrote:

> 	* math/Makefile (libm-calls): Remove k_rem_pio2F.
> 	(type-double-routines): Add k_rem_pio2.
> 	(type-float-routines): Add k_rem_pio2f.
> 
> 	* sysdeps/generic/math_private.h:
> 	(__kernel_rem_pio2l): Removed.
> 
> 	* math/k_rem_pio2l.c: Removed.
> 	* sysdeps/i386/fpu/k_rem_pio2l.c: Removed.
> 	* sysdeps/ia64/fpu/k_rem_pio2l.c: Removed.
> 	* sysdeps/m68k/m680x0/fpu/k_rem_pio2l.c: Removed.
> 	* sysdeps/x86_64/fpu/k_rem_pio2l.c: Removed.

OK.
Paul E. Murphy Sept. 1, 2016, 3:34 p.m. UTC | #2
On 08/31/2016 05:40 PM, Joseph Myers wrote:
> On Wed, 31 Aug 2016, Paul E. Murphy wrote:
> 
>> 	* math/Makefile (libm-calls): Remove k_rem_pio2F.
>> 	(type-double-routines): Add k_rem_pio2.
>> 	(type-float-routines): Add k_rem_pio2f.
>>
>> 	* sysdeps/generic/math_private.h:
>> 	(__kernel_rem_pio2l): Removed.
>>
>> 	* math/k_rem_pio2l.c: Removed.
>> 	* sysdeps/i386/fpu/k_rem_pio2l.c: Removed.
>> 	* sysdeps/ia64/fpu/k_rem_pio2l.c: Removed.
>> 	* sysdeps/m68k/m680x0/fpu/k_rem_pio2l.c: Removed.
>> 	* sysdeps/x86_64/fpu/k_rem_pio2l.c: Removed.
> 
> OK.
> 

Committed as 2bad840.

Patch
diff mbox

diff --git a/math/Makefile b/math/Makefile
index c0d7ff0..6a90a36 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -56,7 +56,7 @@  libm-calls =								  \
 	e_hypotF e_j0F e_j1F e_jnF e_lgammaF_r e_logF e_log10F e_powF	  \
 	e_rem_pio2F e_remainderF e_scalbF e_sinhF e_sqrtF e_gammaF_r	  \
 	e_ilogbF							  \
-	k_cosF k_rem_pio2F k_sinF k_tanF s_asinhF s_atanF s_cbrtF	  \
+	k_cosF k_sinF k_tanF s_asinhF s_atanF s_cbrtF			  \
 	s_ceilF s_cosF s_erfF s_expm1F s_fabsF				  \
 	s_floorF s_log1pF w_log1pF s_logbF				  \
 	s_nextafterF s_nexttowardF s_rintF s_scalblnF w_scalblnF	  \
@@ -99,11 +99,11 @@  type-ldouble-yes := ldouble
 type-double-suffix :=
 type-double-routines := branred doasin dosincos halfulp mpa mpatan2	\
 		       mpatan mpexp mplog mpsqrt mptan sincos32 slowexp	\
-		       slowpow sincostab
+		       slowpow sincostab k_rem_pio2
 
 # float support
 type-float-suffix := f
-type-float-routines :=
+type-float-routines := k_rem_pio2f
 
 
 # Apply suffix to each type in arg 1
diff --git a/math/k_rem_pio2l.c b/math/k_rem_pio2l.c
deleted file mode 100644
index 01bf158..0000000
--- a/math/k_rem_pio2l.c
+++ /dev/null
@@ -1,15 +0,0 @@ 
-#include <math.h>
-#include <math_private.h>
-#include <stdio.h>
-#include <errno.h>
-
-int
-__kernel_rem_pio2l (long double *x, long double *y, int e0, int nx, int prec,
-		    const int *ipio2)
-{
-  fputs ("__kernel_rem_pio2l not implemented\n", stderr);
-  __set_errno (ENOSYS);
-  return 0.0;
-}
-
-stub_warning (__kernel_rem_pio2l)
diff --git a/sysdeps/generic/math_private.h b/sysdeps/generic/math_private.h
index cf1865d..24adcfb 100644
--- a/sysdeps/generic/math_private.h
+++ b/sysdeps/generic/math_private.h
@@ -317,8 +317,6 @@  extern long double __kernel_cosl (long double,long double);
 extern long double __kernel_tanl (long double,long double,int);
 extern void __kernel_sincosl (long double,long double,
 			      long double *,long double *, int);
-extern int   __kernel_rem_pio2l (long double*,long double*,int,int,
-				 int,const int*);
 
 #ifndef NO_LONG_DOUBLE
 /* prototypes required to compile the ldbl-96 support without warnings */
diff --git a/sysdeps/i386/fpu/k_rem_pio2l.c b/sysdeps/i386/fpu/k_rem_pio2l.c
deleted file mode 100644
index 1347b04..0000000
--- a/sysdeps/i386/fpu/k_rem_pio2l.c
+++ /dev/null
@@ -1,3 +0,0 @@ 
-/* Empty.  This file is only meant to avoid compiling the file with the
-   same name in the libm-ieee754 directory.  The code is not used since
-   there is an assembler version for all users of this file.  */
diff --git a/sysdeps/ia64/fpu/k_rem_pio2l.c b/sysdeps/ia64/fpu/k_rem_pio2l.c
deleted file mode 100644
index 41254ae..0000000
--- a/sysdeps/ia64/fpu/k_rem_pio2l.c
+++ /dev/null
@@ -1 +0,0 @@ 
-/* Not needed. */
diff --git a/sysdeps/m68k/m680x0/fpu/k_rem_pio2l.c b/sysdeps/m68k/m680x0/fpu/k_rem_pio2l.c
deleted file mode 100644
index 1347b04..0000000
--- a/sysdeps/m68k/m680x0/fpu/k_rem_pio2l.c
+++ /dev/null
@@ -1,3 +0,0 @@ 
-/* Empty.  This file is only meant to avoid compiling the file with the
-   same name in the libm-ieee754 directory.  The code is not used since
-   there is an assembler version for all users of this file.  */
diff --git a/sysdeps/x86_64/fpu/k_rem_pio2l.c b/sysdeps/x86_64/fpu/k_rem_pio2l.c
deleted file mode 100644
index eea55a9..0000000
--- a/sysdeps/x86_64/fpu/k_rem_pio2l.c
+++ /dev/null
@@ -1 +0,0 @@ 
-/*  Not needed.  */