internal: Dont define functions on yet unsupported architechtures

Message ID 20160831182210.18533-1-urjaman@gmail.com
State New
Headers show

Commit Message

Urja Rannikko Aug. 31, 2016, 6:22 p.m.
This fixes a warning with newer (6.1) gcc on ARM,
as tested by swiftgeek on irc.

Signed-off-by: Urja Rannikko <urjaman@gmail.com>
---
 internal.c | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Stefan Tauner Dec. 4, 2016, 2:31 a.m. | #1
On Wed, 31 Aug 2016 21:22:10 +0300
Urja Rannikko <urjaman@gmail.com> wrote:

> This fixes a warning with newer (6.1) gcc on ARM,
> as tested by swiftgeek on irc.
> 
> Signed-off-by: Urja Rannikko <urjaman@gmail.com>

Thanks. I have replaced the prototypes at the top with the actual
implementations to get rid of the redundancy, which spares us from
duplicating the #ifs and comments too.

Patch

diff --git a/internal.c b/internal.c
index 4062b64..aa5f1d1 100644
--- a/internal.c
+++ b/internal.c
@@ -131,6 +131,8 @@  int register_superio(struct superio s)
 int is_laptop = 0;
 int laptop_ok = 0;
 
+/* This matches with the #if for the registration of par_master_internal */
+#if IS_X86 || IS_MIPS
 static void internal_chip_writeb(const struct flashctx *flash, uint8_t val,
 				 chipaddr addr);
 static void internal_chip_writew(const struct flashctx *flash, uint16_t val,
@@ -155,6 +157,7 @@  static const struct par_master par_master_internal = {
 		.chip_writel		= internal_chip_writel,
 		.chip_writen		= fallback_chip_writen,
 };
+#endif
 
 enum chipbustype internal_buses_supported = BUS_NONE;
 
@@ -358,6 +361,8 @@  int internal_init(void)
 }
 #endif
 
+/* This matches with the #if for the registration of par_master_internal */
+#if IS_X86 || IS_MIPS
 static void internal_chip_writeb(const struct flashctx *flash, uint8_t val,
 				 chipaddr addr)
 {
@@ -400,3 +405,4 @@  static void internal_chip_readn(const struct flashctx *flash, uint8_t *buf,
 	mmio_readn((void *)addr, buf, len);
 	return;
 }
+#endif