| Message ID | 20160831081817.5191-2-maxime.ripard@free-electrons.com |
|---|---|
| State | New |
| Headers | show |
On Wed, 31 Aug 2016, Maxime Ripard wrote: > Some backlight GPIOs might be connected to some i2c based expanders whose > access might sleep. > > Since it's not in any critical path, use the cansleep variant of the GPIO > API. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > drivers/video/backlight/pwm_bl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. > diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c > index b2b366bb0f97..12614006211e 100644 > --- a/drivers/video/backlight/pwm_bl.c > +++ b/drivers/video/backlight/pwm_bl.c > @@ -55,7 +55,7 @@ static void pwm_backlight_power_on(struct pwm_bl_data *pb, int brightness) > dev_err(pb->dev, "failed to enable power supply\n"); > > if (pb->enable_gpio) > - gpiod_set_value(pb->enable_gpio, 1); > + gpiod_set_value_cansleep(pb->enable_gpio, 1); > > pwm_enable(pb->pwm); > pb->enabled = true; > @@ -70,7 +70,7 @@ static void pwm_backlight_power_off(struct pwm_bl_data *pb) > pwm_disable(pb->pwm); > > if (pb->enable_gpio) > - gpiod_set_value(pb->enable_gpio, 0); > + gpiod_set_value_cansleep(pb->enable_gpio, 0); > > regulator_disable(pb->power_supply); > pb->enabled = false;
diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index b2b366bb0f97..12614006211e 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -55,7 +55,7 @@ static void pwm_backlight_power_on(struct pwm_bl_data *pb, int brightness) dev_err(pb->dev, "failed to enable power supply\n"); if (pb->enable_gpio) - gpiod_set_value(pb->enable_gpio, 1); + gpiod_set_value_cansleep(pb->enable_gpio, 1); pwm_enable(pb->pwm); pb->enabled = true; @@ -70,7 +70,7 @@ static void pwm_backlight_power_off(struct pwm_bl_data *pb) pwm_disable(pb->pwm); if (pb->enable_gpio) - gpiod_set_value(pb->enable_gpio, 0); + gpiod_set_value_cansleep(pb->enable_gpio, 0); regulator_disable(pb->power_supply); pb->enabled = false;
Some backlight GPIOs might be connected to some i2c based expanders whose access might sleep. Since it's not in any critical path, use the cansleep variant of the GPIO API. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- drivers/video/backlight/pwm_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)