From patchwork Fri Oct 1 11:56:26 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh KUMAR X-Patchwork-Id: 66441 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 563E1B70E3 for ; Sat, 2 Oct 2010 03:02:13 +1000 (EST) Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1P1iyQ-0006Bu-QQ; Fri, 01 Oct 2010 17:00:42 +0000 Received: from casper.infradead.org ([2001:770:15f::2]) by bombadil.infradead.org with esmtps (Exim 4.72 #1 (Red Hat Linux)) id 1P1iw5-0003pB-Vh; Fri, 01 Oct 2010 16:58:18 +0000 Received: from eu1sys200aog104.obsmtp.com ([207.126.144.117]) by casper.infradead.org with smtps (Exim 4.72 #1 (Red Hat Linux)) id 1P1eHX-0008Hy-J7; Fri, 01 Oct 2010 12:00:09 +0000 Received: from source ([164.129.1.35]) (using TLSv1) by eu1sys200aob104.postini.com ([207.126.147.11]) with SMTP ID DSNKTKXM2qcxckZvgdfDcg32aMemF6QCZlah@postini.com; Fri, 01 Oct 2010 12:00:07 UTC Received: from zeta.dmz-eu.st.com (ns2.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6B77AEA; Fri, 1 Oct 2010 11:57:55 +0000 (GMT) Received: from mail2.dlh.st.com (mail2.dlh.st.com [10.199.8.22]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E167A2648; Fri, 1 Oct 2010 11:57:51 +0000 (GMT) Received: from localhost (dlhl0509.dlh.st.com [10.199.7.86]) by mail2.dlh.st.com (MOS 3.8.7a) with ESMTP id CUF01012 (AUTH viresh.kumar@st.com); Fri, 1 Oct 2010 17:27:51 +0530 (IST) From: Viresh KUMAR To: linux-arm-kernel@lists.infradead.org, rtc-linux@googlegroups.com, a.zummo@towertech.it, dbrownell@users.sourceforge.net, linux-usb@vger.kernel.org, linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, linux-mtd@lists.infradead.org, dwmw2@infradead.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org Subject: [PATCH V2 66/69] ST SPEAr13xx: Pass default padmux settings as parameter to spear13**_init routine Date: Fri, 1 Oct 2010 17:26:26 +0530 Message-Id: <8f1014d21b888fac4aea1778c1032e5d02079329.1285933332.git.viresh.kumar@st.com> X-Mailer: git-send-email 1.7.2.2 In-Reply-To: References: In-Reply-To: References: X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20101001_130007_914882_5FB70CF6 X-CRM114-Status: GOOD ( 11.21 ) X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.1 on casper.infradead.org summary: Content analysis details: (-4.2 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [207.126.144.117 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: pratyush.anand@st.com, Viresh Kumar , vipulkumar.samar@st.com, bhupesh.sharma@st.com, armando.visconti@st.com, vipin.kumar@st.com, shiraz.hashim@st.com, rajeev-dlh.kumar@st.com, deepak.sikri@st.com X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linux-mtd-bounces@lists.infradead.org Errors-To: linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org This patch makes pmx_driver static to spear1300.c and spear1310.c, also now default setting of padmux are sent to spear1300_init and spear1310_init routines Signed-off-by: Viresh Kumar --- arch/arm/mach-spear13xx/include/mach/generic.h | 8 ++++---- arch/arm/mach-spear13xx/spear1300.c | 9 +++++++-- arch/arm/mach-spear13xx/spear1300_evb.c | 7 +------ arch/arm/mach-spear13xx/spear1310.c | 9 +++++++-- arch/arm/mach-spear13xx/spear1310_evb.c | 7 +------ 5 files changed, 20 insertions(+), 20 deletions(-) diff --git a/arch/arm/mach-spear13xx/include/mach/generic.h b/arch/arm/mach-spear13xx/include/mach/generic.h index f619b70..e005936 100644 --- a/arch/arm/mach-spear13xx/include/mach/generic.h +++ b/arch/arm/mach-spear13xx/include/mach/generic.h @@ -220,8 +220,6 @@ extern struct pmx_dev pmx_uart1_modem; #define SPEAR_GPT0_CHAN0_IRQ IRQ_GPT0_TMR0 #define SPEAR_GPT0_CHAN1_IRQ IRQ_GPT0_TMR1 -extern struct pmx_driver pmx_driver; - /* Add spear13xx family device structure declarations here */ extern struct amba_device spear13xx_gpio_device[]; extern struct amba_device spear13xx_ssp_device; @@ -255,7 +253,8 @@ void spear13xx_secondary_startup(void); /* spear1300 declarations */ #ifdef CONFIG_MACH_SPEAR1300 /* Add spear1300 machine function declarations here */ -void __init spear1300_init(void); +void __init spear1300_init(struct pmx_mode *pmx_mode, struct pmx_dev **pmx_devs, + u8 pmx_dev_count); #endif /* CONFIG_MACH_SPEAR1300 */ @@ -266,7 +265,8 @@ extern struct platform_device spear1310_can0_device; extern struct platform_device spear1310_can1_device; /* Add spear1310 machine function declarations here */ -void __init spear1310_init(void); +void __init spear1310_init(struct pmx_mode *pmx_mode, struct pmx_dev **pmx_devs, + u8 pmx_dev_count); #endif /* CONFIG_MACH_SPEAR1310 */ diff --git a/arch/arm/mach-spear13xx/spear1300.c b/arch/arm/mach-spear13xx/spear1300.c index 28822a3..b10f7a0 100644 --- a/arch/arm/mach-spear13xx/spear1300.c +++ b/arch/arm/mach-spear13xx/spear1300.c @@ -15,11 +15,12 @@ #include /* pmx driver structure */ -struct pmx_driver pmx_driver; +static struct pmx_driver pmx_driver; /* Add spear1300 specific devices here */ -void __init spear1300_init(void) +void __init spear1300_init(struct pmx_mode *pmx_mode, struct pmx_dev **pmx_devs, + u8 pmx_dev_count) { int ret; @@ -27,6 +28,10 @@ void __init spear1300_init(void) spear13xx_init(); /* pmx initialization */ + pmx_driver.mode = pmx_mode; + pmx_driver.devs = pmx_devs; + pmx_driver.devs_count = pmx_dev_count; + ret = pmx_register(&pmx_driver); if (ret) pr_err("padmux: registeration failed. err no: %d\n", ret); diff --git a/arch/arm/mach-spear13xx/spear1300_evb.c b/arch/arm/mach-spear13xx/spear1300_evb.c index ceb3bd0..4c8365b 100644 --- a/arch/arm/mach-spear13xx/spear1300_evb.c +++ b/arch/arm/mach-spear13xx/spear1300_evb.c @@ -122,11 +122,6 @@ static void __init spear1300_evb_init(void) { unsigned int i; - /* padmux initialization, must be done before spear1300_init */ - pmx_driver.mode = NULL; - pmx_driver.devs = pmx_devs; - pmx_driver.devs_count = ARRAY_SIZE(pmx_devs); - /* set keyboard plat data */ kbd_set_plat_data(&spear13xx_kbd_device, &kbd_data); @@ -136,7 +131,7 @@ static void __init spear1300_evb_init(void) nand_mach_init(FSMC_NAND_BW8); /* call spear1300 machine init function */ - spear1300_init(); + spear1300_init(NULL, pmx_devs, ARRAY_SIZE(pmx_devs)); /* Register slave devices on the I2C buses */ i2c_register_board_devices(); diff --git a/arch/arm/mach-spear13xx/spear1310.c b/arch/arm/mach-spear13xx/spear1310.c index 39ea491..375f5b2 100644 --- a/arch/arm/mach-spear13xx/spear1310.c +++ b/arch/arm/mach-spear13xx/spear1310.c @@ -17,7 +17,7 @@ #include /* pmx driver structure */ -struct pmx_driver pmx_driver; +static struct pmx_driver pmx_driver; /* Pad multiplexing for uart1_modem device */ static struct pmx_mux_reg pmx_uart1_modem_mux[] = { @@ -393,7 +393,8 @@ struct platform_device spear1310_can1_device = { .resource = can1_resources, }; -void __init spear1310_init(void) +void __init spear1310_init(struct pmx_mode *pmx_mode, struct pmx_dev **pmx_devs, + u8 pmx_dev_count) { int ret; @@ -401,6 +402,10 @@ void __init spear1310_init(void) spear13xx_init(); /* pmx initialization */ + pmx_driver.mode = pmx_mode; + pmx_driver.devs = pmx_devs; + pmx_driver.devs_count = pmx_dev_count; + ret = pmx_register(&pmx_driver); if (ret) pr_err("padmux: registeration failed. err no: %d\n", ret); diff --git a/arch/arm/mach-spear13xx/spear1310_evb.c b/arch/arm/mach-spear13xx/spear1310_evb.c index c4b83b2..a263b40 100644 --- a/arch/arm/mach-spear13xx/spear1310_evb.c +++ b/arch/arm/mach-spear13xx/spear1310_evb.c @@ -133,11 +133,6 @@ static void __init spear1310_evb_init(void) { unsigned int i; - /* padmux initialization, must be done before spear1300_init */ - pmx_driver.mode = NULL; - pmx_driver.devs = pmx_devs; - pmx_driver.devs_count = ARRAY_SIZE(pmx_devs); - /* set keyboard plat data */ kbd_set_plat_data(&spear13xx_kbd_device, &kbd_data); @@ -147,7 +142,7 @@ static void __init spear1310_evb_init(void) nand_mach_init(FSMC_NAND_BW8); /* call spear1310 machine init function */ - spear1310_init(); + spear1310_init(NULL, pmx_devs, ARRAY_SIZE(pmx_devs)); /* Register slave devices on the I2C buses */ i2c_register_board_devices();