| Message ID | CAN04xNR8SH4D57mfY0nVDSNWvZfaaOLci2yB0-8nKg=Hv9SEbw@mail.gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
On Tue, 30 Aug 2016 17:32:52 -0700 Iskren Chernev <iskren@imo.im> wrote: > From 416f45b62f33017d19a9b14e7b0179807c993cbe Mon Sep 17 00:00:00 2001 > From: Iskren Chernev <iskren@imo.im> > Date: Tue, 30 Aug 2016 17:08:54 -0700 > Subject: [PATCH bug-fix] iproute: fix documentation for ip rule scan order > > --- > man/man8/ip-rule.8 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied
On Thu, Sep 01, 2016 at 09:04:54AM -0700, Stephen Hemminger wrote: > On Tue, 30 Aug 2016 17:32:52 -0700 > Iskren Chernev <iskren@imo.im> wrote: > > > From 416f45b62f33017d19a9b14e7b0179807c993cbe Mon Sep 17 00:00:00 2001 > > From: Iskren Chernev <iskren@imo.im> > > Date: Tue, 30 Aug 2016 17:08:54 -0700 > > Subject: [PATCH bug-fix] iproute: fix documentation for ip rule scan order > > > > --- > > man/man8/ip-rule.8 | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/man/man8/ip-rule.8 b/man/man8/ip-rule.8 > > index 1774ae3..3508d80 100644 > > --- a/man/man8/ip-rule.8 > > +++ b/man/man8/ip-rule.8 > > @@ -93,7 +93,7 @@ Each policy routing rule consists of a > > .B selector > > and an > > .B action predicate. > > -The RPDB is scanned in order of decreasing priority. The selector > > +The RPDB is scanned in order of increasing priority. The selector > > of each rule is applied to {source address, destination address, > > incoming > > interface, tos, fwmark} and, if the selector matches the packet, > > the action is performed. The action predicate may return with success. > > -- > > 2.4.5 > > Applied I'm sorry I didn't notice before but this just reverts the change done by commit 49572501664d ("iproute2: clarification of various man8 pages"). IMHO the problem is that both versions are equally confusing as the word "priority" can be understood in two different senses. How about more explicit formulation, e.g. ... in order of decreasing logical priority (i.e. increasing numeric values). Would that be better? Michal Kubecek
diff --git a/man/man8/ip-rule.8 b/man/man8/ip-rule.8 index 1774ae3..3508d80 100644 --- a/man/man8/ip-rule.8 +++ b/man/man8/ip-rule.8 @@ -93,7 +93,7 @@ Each policy routing rule consists of a .B selector and an .B action predicate. -The RPDB is scanned in order of decreasing priority. The selector +The RPDB is scanned in order of increasing priority. The selector of each rule is applied to {source address, destination address, incoming interface, tos, fwmark} and, if the selector matches the packet, the action is performed. The action predicate may return with success.
From 416f45b62f33017d19a9b14e7b0179807c993cbe Mon Sep 17 00:00:00 2001 From: Iskren Chernev <iskren@imo.im> Date: Tue, 30 Aug 2016 17:08:54 -0700 Subject: [PATCH bug-fix] iproute: fix documentation for ip rule scan order --- man/man8/ip-rule.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.4.5