| Message ID | 20160830163201.GA25869@Karyakshetra |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, Aug 30, 2016 at 10:02:01PM +0530, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces > deprecated create_singlethread_workqueue(). This is the identity > conversion. > > The workqueue "wq" queues multiple work items viz > &bond->mcast_work, &nnw->work, &bond->mii_work, &bond->arp_work, > &bond->alb_work, &bond->mii_work, &bond->ad_work, &bond->slave_arr_work > which require strict execution ordering. Hence, an ordered dedicated > workqueue has been used. > > Since, it is a network driver, WQ_MEM_RECLAIM has been set to > ensure forward progress under memory pressure. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Acked-by: Tejun Heo <tj@kernel.org> Thanks.
From: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Date: Tue, 30 Aug 2016 22:02:01 +0530 > alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces > deprecated create_singlethread_workqueue(). This is the identity > conversion. > > The workqueue "wq" queues multiple work items viz > &bond->mcast_work, &nnw->work, &bond->mii_work, &bond->arp_work, > &bond->alb_work, &bond->mii_work, &bond->ad_work, &bond->slave_arr_work > which require strict execution ordering. Hence, an ordered dedicated > workqueue has been used. > > Since, it is a network driver, WQ_MEM_RECLAIM has been set to > ensure forward progress under memory pressure. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Applied.
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 941ec99..ebaf1a9 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -4635,7 +4635,7 @@ static int bond_init(struct net_device *bond_dev) netdev_dbg(bond_dev, "Begin bond_init\n"); - bond->wq = create_singlethread_workqueue(bond_dev->name); + bond->wq = alloc_ordered_workqueue(bond_dev->name, WQ_MEM_RECLAIM); if (!bond->wq) return -ENOMEM;
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces deprecated create_singlethread_workqueue(). This is the identity conversion. The workqueue "wq" queues multiple work items viz &bond->mcast_work, &nnw->work, &bond->mii_work, &bond->arp_work, &bond->alb_work, &bond->mii_work, &bond->ad_work, &bond->slave_arr_work which require strict execution ordering. Hence, an ordered dedicated workqueue has been used. Since, it is a network driver, WQ_MEM_RECLAIM has been set to ensure forward progress under memory pressure. Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com> --- drivers/net/bonding/bond_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.1.4