| Message ID | 1472572593-86410-1-git-send-email-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL 0/2] Last minute fixes for 2.7.0-rc5
Type: series
Message-id: 1472572593-86410-1-git-send-email-pbonzini@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/1472572593-86410-1-git-send-email-pbonzini@redhat.com -> patchew/1472572593-86410-1-git-send-email-pbonzini@redhat.com
Switched to a new branch 'test'
b79a461 optionrom: cope with multiple -O options
ccab731 Revert "Change net/socket.c to use socket_*() functions"
=== OUTPUT BEGIN ===
Checking PATCH 1/2: Revert "Change net/socket.c to use socket_*() functions"...
ERROR: braces {} are necessary for all arms of this statement
#30: FILE: net/socket.c:495:
+ if (parse_host_port(&saddr, host_str) < 0)
[...]
ERROR: braces {} are necessary for all arms of this statement
#81: FILE: net/socket.c:539:
+ if (parse_host_port(&saddr, host_str) < 0)
[...]
total: 2 errors, 0 warnings, 104 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/2: optionrom: cope with multiple -O options...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
The following changes since commit 135a972b45203ba992afc99ef4f061be8a5acae0: translate: early exit in tb_flush if there is no tcg (2016-08-30 13:30:55 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git for you to fetch changes up to 336d5881a927cd80e8c0ff61c7f76b1433f91bb0: optionrom: cope with multiple -O options (2016-08-30 16:28:46 +0200) ---------------------------------------------------------------- * pc-bios/optionrom/Makefile fix for -O0 * revert socket_connect change ---------------------------------------------------------------- Paolo Bonzini (2): Revert "Change net/socket.c to use socket_*() functions" optionrom: cope with multiple -O options net/socket.c | 55 +++++++++++++++++++++++----------------------- pc-bios/optionrom/Makefile | 5 +---- 2 files changed, 29 insertions(+), 31 deletions(-)