| Message ID | 1472530253-94132-3-git-send-email-arei.gonglei@huawei.com |
|---|---|
| State | New |
| Headers | show |
Reviewed-by: Dmitry Fleytman <dmitry@daynix.com> > On 30 Aug 2016, at 07:10 AM, Gonglei <arei.gonglei@huawei.com> wrote: > > hw/net/e1000e_core.c:56: warning: e1000e_set_interrupt_cause declared inline after being called > hw/net/e1000e_core.c:56: warning: previous declaration of e1000e_set_interrupt_cause was here > > Signed-off-by: Gonglei <arei.gonglei@huawei.com> > --- > hw/net/e1000e_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c > index badb1fe..825e169 100644 > --- a/hw/net/e1000e_core.c > +++ b/hw/net/e1000e_core.c > @@ -2168,7 +2168,7 @@ e1000e_update_interrupt_state(E1000ECore *core) > } > } > > -static inline void > +static void > e1000e_set_interrupt_cause(E1000ECore *core, uint32_t val) > { > trace_e1000e_irq_set_cause_entry(val, core->mac[ICR]); > -- > 1.7.12.4 > >
Who can pick up this patch? Dmitry or Jason? Thanks! Regards, -Gonglei > -----Original Message----- > From: Dmitry Fleytman [mailto:dmitry@daynix.com] > Sent: Wednesday, August 31, 2016 8:59 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; berrange@redhat.com > Subject: Re: [PATCH v2 2/2] e1000: fix buliding complaint > > Reviewed-by: Dmitry Fleytman <dmitry@daynix.com> > > > On 30 Aug 2016, at 07:10 AM, Gonglei <arei.gonglei@huawei.com> wrote: > > > > hw/net/e1000e_core.c:56: warning: e1000e_set_interrupt_cause declared > inline after being called > > hw/net/e1000e_core.c:56: warning: previous declaration of > e1000e_set_interrupt_cause was here > > > > Signed-off-by: Gonglei <arei.gonglei@huawei.com> > > --- > > hw/net/e1000e_core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c > > index badb1fe..825e169 100644 > > --- a/hw/net/e1000e_core.c > > +++ b/hw/net/e1000e_core.c > > @@ -2168,7 +2168,7 @@ e1000e_update_interrupt_state(E1000ECore > *core) > > } > > } > > > > -static inline void > > +static void > > e1000e_set_interrupt_cause(E1000ECore *core, uint32_t val) > > { > > trace_e1000e_irq_set_cause_entry(val, core->mac[ICR]); > > -- > > 1.7.12.4 > > > >
> On 9 Sep 2016, at 10:15 AM, Gonglei (Arei) <arei.gonglei@huawei.com> wrote: > > Who can pick up this patch? Dmitry or Jason? Thanks! Jason, would you please? > > > Regards, > -Gonglei > > >> -----Original Message----- >> From: Dmitry Fleytman [mailto:dmitry@daynix.com] >> Sent: Wednesday, August 31, 2016 8:59 PM >> To: Gonglei (Arei) >> Cc: qemu-devel@nongnu.org; berrange@redhat.com >> Subject: Re: [PATCH v2 2/2] e1000: fix buliding complaint >> >> Reviewed-by: Dmitry Fleytman <dmitry@daynix.com> >> >>> On 30 Aug 2016, at 07:10 AM, Gonglei <arei.gonglei@huawei.com> wrote: >>> >>> hw/net/e1000e_core.c:56: warning: e1000e_set_interrupt_cause declared >> inline after being called >>> hw/net/e1000e_core.c:56: warning: previous declaration of >> e1000e_set_interrupt_cause was here >>> >>> Signed-off-by: Gonglei <arei.gonglei@huawei.com> >>> --- >>> hw/net/e1000e_core.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c >>> index badb1fe..825e169 100644 >>> --- a/hw/net/e1000e_core.c >>> +++ b/hw/net/e1000e_core.c >>> @@ -2168,7 +2168,7 @@ e1000e_update_interrupt_state(E1000ECore >> *core) >>> } >>> } >>> >>> -static inline void >>> +static void >>> e1000e_set_interrupt_cause(E1000ECore *core, uint32_t val) >>> { >>> trace_e1000e_irq_set_cause_entry(val, core->mac[ICR]); >>> -- >>> 1.7.12.4 >>> >>> >
On 2016年09月13日 14:00, Dmitry Fleytman wrote: >> >On 9 Sep 2016, at 10:15 AM, Gonglei (Arei)<arei.gonglei@huawei.com> wrote: >> > >> >Who can pick up this patch? Dmitry or Jason? Thanks! > Jason, would you please? > Picked in my tree. Thanks
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index badb1fe..825e169 100644 --- a/hw/net/e1000e_core.c +++ b/hw/net/e1000e_core.c @@ -2168,7 +2168,7 @@ e1000e_update_interrupt_state(E1000ECore *core) } } -static inline void +static void e1000e_set_interrupt_cause(E1000ECore *core, uint32_t val) { trace_e1000e_irq_set_cause_entry(val, core->mac[ICR]);
hw/net/e1000e_core.c:56: warning: e1000e_set_interrupt_cause declared inline after being called hw/net/e1000e_core.c:56: warning: previous declaration of e1000e_set_interrupt_cause was here Signed-off-by: Gonglei <arei.gonglei@huawei.com> --- hw/net/e1000e_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)