| Message ID | 1472471973-23041-1-git-send-email-baoyou.xie@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Monday 29 August 2016, Baoyou Xie wrote: > We get 1 warning when biuld kernel with W=1: > drivers/isdn/hardware/mISDN/w6692.c:851:6: warning: no previous prototype for 'initW6692' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is declared > and don't need a declaration, but can be made static. > so this patch marks it 'static'. > > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> > --- > drivers/isdn/hardware/mISDN/w6692.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) The patch looks good, but now you have sent two different patches with the same subject line. Since this is just one driver and each instance is a trivial change, I'd suggest doing a single combined patch for them. Similarly, when you have multiple patches within one subsystem (e.g. two different scsi drivers), it helps to have a series of patches as you did with the ASoC patches. Arnd
diff --git a/drivers/isdn/hardware/mISDN/w6692.c b/drivers/isdn/hardware/mISDN/w6692.c index 7416755..3b067ea 100644 --- a/drivers/isdn/hardware/mISDN/w6692.c +++ b/drivers/isdn/hardware/mISDN/w6692.c @@ -848,7 +848,7 @@ dbusy_timer_handler(struct dchannel *dch) } } -void initW6692(struct w6692_hw *card) +static void initW6692(struct w6692_hw *card) { u8 val;
We get 1 warning when biuld kernel with W=1: drivers/isdn/hardware/mISDN/w6692.c:851:6: warning: no previous prototype for 'initW6692' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. so this patch marks it 'static'. Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org> --- drivers/isdn/hardware/mISDN/w6692.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)