From patchwork Fri Oct 1 11:32:51 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 66337 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id B6CF8B70E6 for ; Fri, 1 Oct 2010 21:33:03 +1000 (EST) Received: (qmail 8870 invoked by alias); 1 Oct 2010 11:33:01 -0000 Received: (qmail 8853 invoked by uid 22791); 1 Oct 2010 11:33:00 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-yw0-f47.google.com (HELO mail-yw0-f47.google.com) (209.85.213.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Oct 2010 11:32:54 +0000 Received: by ywe9 with SMTP id 9so1067036ywe.20 for ; Fri, 01 Oct 2010 04:32:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.90.65.7 with SMTP id n7mr1376614aga.51.1285932772101; Fri, 01 Oct 2010 04:32:52 -0700 (PDT) Received: by 10.220.202.9 with HTTP; Fri, 1 Oct 2010 04:32:51 -0700 (PDT) In-Reply-To: References: Date: Fri, 1 Oct 2010 04:32:51 -0700 Message-ID: Subject: Re: PATCH COMMITTED: Fix -fsplit-stack build with old binutils From: "H.J. Lu" To: Ian Lance Taylor Cc: gcc-patches@gcc.gnu.org X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On Mon, Sep 27, 2010 at 5:07 PM, Ian Lance Taylor wrote: > http://gcc.gnu.org/ml/gcc-regression/2010-09/msg00356.html shows a build > failure with the -fsplit-stack patches: > > /home/regress/tbox/svn-gcc/libgcc/config/i386/morestack.S > /home/regress/tbox/svn-gcc/libgcc/config/i386/morestack.S: Assembler messages: > /home/regress/tbox/svn-gcc/libgcc/config/i386/morestack.S:138: Error: unknown pseudo-op: `.cfi_personality' > /home/regress/tbox/svn-gcc/libgcc/config/i386/morestack.S:139: Error: unknown pseudo-op: `.cfi_lsda' > make[3]: *** [morestack_s.o] Error 1 > > gas picked up support for .cfi_personality 2006-11-03, which was in the > binutils 2.18 release. > > This patch changes gcc to only support -fsplit-stack if the .cfi > pseudo-ops are available in the assembler.  Another approach would be to > spell out the information in morestack.S, but that does not seem to me > like a useful way to spend time considering how long the GNU binutils > have supported the pseudo-ops. > > Bootstrapped and tested on x86_64-unknown-linux-gnu.  Committed to > mainline. > > Ian > > > gcc/ChangeLog: > > 2010-09-27  Ian Lance Taylor   > >        * config/i386/i386.c (ix86_supports_split_stack): -fsplit-stack >        requires assembler support for CFI directives. > > libgcc/ChangeLog: > > 2010-09-27  Ian Lance Taylor   > >        * configure.ac: Test whether assembler supports CFI directives. >        * config.host: Only add t-stack and i386/t-stack-i386 to >        tmake_file if libgcc_cv_cfi is "yes". >        * configure: Rebuild. > I checked in this patch to add the missing `$'. Index: config.host =================================================================== --- config.host (revision 164874) +++ config.host (working copy) @@ -610,7 +610,7 @@ i[34567]86-*-linux* | x86_64-*-linux* | i[34567]86-*-gnu*) tmake_file="${tmake_file} t-tls" if test "$libgcc_cv_cfi" = "yes"; then - tmake_file="{$tmake_file} t-stack i386/t-stack-i386" + tmake_file="${$tmake_file} t-stack i386/t-stack-i386" fi ;; esac Index: ChangeLog =================================================================== --- ChangeLog (revision 164874) +++ ChangeLog (working copy) @@ -1,3 +1,8 @@ +2010-10-01 H.J. Lu + + PR target/45858 + * config.host: Add the missing `$'. + 2010-09-30 Michael Eager * config.host: Add microblaze*-*-*.