| Message ID | 20160826212821.GA21305@waldemar-brodkorb.de |
|---|---|
| State | Rejected |
| Headers | show |
Hello, On Fri, 26 Aug 2016 23:28:21 +0200, Waldemar Brodkorb wrote: > Fixes: > http://autobuild.buildroot.net/results/3aa73620d0f1afcc82de93069c9693e1ca755bb9 > > Signed-off-by: Waldemar Brodkorb <wbx@openadk.org> I disagree with this change because it seems more like a toolchain issue than the package really needing dynamic library support. And indeed, the following static only configuration that includes zeromq builds perfectly fine: BR2_arm=y BR2_STATIC_LIBS=y BR2_TOOLCHAIN_EXTERNAL=y BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/br-arm-full-static-2016.08-rc1-4-g07e8d1c.tar.bz2" BR2_TOOLCHAIN_EXTERNAL_GCC_4_9=y BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_14=y BR2_TOOLCHAIN_EXTERNAL_LOCALE=y # BR2_TOOLCHAIN_EXTERNAL_HAS_THREADS_DEBUG is not set BR2_TOOLCHAIN_EXTERNAL_INET_RPC=y BR2_TOOLCHAIN_EXTERNAL_CXX=y BR2_INIT_NONE=y BR2_SYSTEM_BIN_SH_NONE=y # BR2_PACKAGE_BUSYBOX is not set BR2_PACKAGE_ZEROMQ=y # BR2_TARGET_ROOTFS_TAR is not set Best regards, Thomas
diff --git a/package/zeromq/Config.in b/package/zeromq/Config.in index d5c9dea..178b044 100644 --- a/package/zeromq/Config.in +++ b/package/zeromq/Config.in @@ -1,12 +1,13 @@ -comment "zeromq needs a toolchain w/ C++, wchar, threads" +comment "zeromq needs a toolchain w/ C++, wchar, threads, dynamic library" depends on !(BR2_INSTALL_LIBSTDCPP && BR2_USE_WCHAR && \ - BR2_TOOLCHAIN_HAS_THREADS) + BR2_TOOLCHAIN_HAS_THREADS) || BR2_STATIC_LIBS config BR2_PACKAGE_ZEROMQ bool "zeromq" depends on BR2_INSTALL_LIBSTDCPP depends on BR2_USE_WCHAR # util-linux depends on BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_STATIC_LIBS select BR2_PACKAGE_UTIL_LINUX select BR2_PACKAGE_UTIL_LINUX_LIBUUID help @@ -27,12 +28,8 @@ config BR2_PACKAGE_ZEROMQ if BR2_PACKAGE_ZEROMQ -comment "norm support needs a toolchain w/ dynamic library" - depends on BR2_STATIC_LIBS - config BR2_PACKAGE_ZEROMQ_NORM bool "NORM support" - depends on !BR2_STATIC_LIBS select BR2_PACKAGE_NORM help Add support for NACK-Oriented Reliable Multicast (RFC 5740)
Fixes: http://autobuild.buildroot.net/results/3aa73620d0f1afcc82de93069c9693e1ca755bb9 Signed-off-by: Waldemar Brodkorb <wbx@openadk.org> --- package/zeromq/Config.in | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)