From patchwork Fri Aug 26 19:28:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Paul E. Murphy" X-Patchwork-Id: 663222 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3sLWL52xGYz9sD5 for ; Sat, 27 Aug 2016 05:28:28 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b=DUSTvs6F; dkim-atps=neutral DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:references:in-reply-to:to:cc:from:date :mime-version:content-type:content-transfer-encoding:message-id; q=dns; s=default; b=AWDKCJEH9NLvDdQ/kjemf+qteN0X+pL20SwUKmxHlID IhGuBiiGN51oib4UWde918aHlwbMO4+zjezaS9p7Apzz/3ljtkLjM0KNYNTu8QqR F2TPpVmxRAOBtKk/5VuzrIo1qU0u1Acnxe9td3FAY4AQwLHrIZ3q23glNYrTdQXY = DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:subject:references:in-reply-to:to:cc:from:date :mime-version:content-type:content-transfer-encoding:message-id; s=default; bh=KPdb12ZH2xq353CVqYKdS/L+1L8=; b=DUSTvs6FPSrcVLrRQ hEjtxIwDiTPR1j0JLck0mnqFZJrVm5+xe2TIU+PEeEyVO5hNGvANC1EDY4wF93Km iyTlM8dnkSCdxU6wno3xmx2TF+prd+hH42i26WH7pifVGUBs2ebChADO+/zui2Br +Qv7McdH1x0EBfNACWQ+eWY+DI= Received: (qmail 48976 invoked by alias); 26 Aug 2016 19:28:21 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 48958 invoked by uid 89); 26 Aug 2016 19:28:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL, BAYES_00, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_LOW, RCVD_IN_SEMBACKSCATTER autolearn=no version=3.3.2 spammy=F22, f22, D*GLIBC_2.1, D*1 X-HELO: mx0a-001b2d01.pphosted.com X-IBM-Helo: d03dlp03.boulder.ibm.com X-IBM-MailFrom: murphyp@linux.vnet.ibm.com Subject: [PATCH] sparcv9: Restore fdiml@GLIBC_2.1 [Was Re: [PATCH 3/3] sparc32/sparcv9: add a VIS3 version of fdim] References: In-Reply-To: To: Aurelien Jarno Cc: "libc-alpha@sourceware.org" From: "Paul E. Murphy" X-Forwarded-Message-Id: Date: Fri, 26 Aug 2016 14:28:12 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16082619-0008-0000-0000-0000056839EC X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005644; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000183; SDB=6.00750112; UDB=6.00354234; IPR=6.00522747; BA=6.00004676; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012480; XFM=3.00000011; UTC=2016-08-26 19:28:16 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16082619-0009-0000-0000-00003A9ADE13 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-08-26_13:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608260246 Hi Aurelien, [Sorry for the duplicate, I forgot the CC to libc-alpha] I tested using the F22 cross-compiler on x86-64, and verified the symbol is once again exported. It turns out most other architectures don't have quite as convoluted Implies as ppc64. Likewise, doing "#include_next " gave me a compiler error. I'll commit the following if it is ok. ---8<--- Use s_fdim.c from sysdeps/ieee754/ldbl-opt/ instead of math/ to ensure a compat symbol for fdiml is created. [BZ #20517] * sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c: Include ldbl-opt/s_fdim.c to ensure fdiml@GLIBC_2.1 is exported. --- sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c index c9c7704..9666741 100644 --- a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c +++ b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fdim.c @@ -29,4 +29,4 @@ weak_alias (__fdim, fdim) # define __fdim __fdim_generic #endif -#include +#include