| Message ID | 1472207269-18499-5-git-send-email-Bhaskar.Upadhaya@nxp.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On Fri, 2016-08-26 at 15:57 +0530, Bhaskar Upadhaya wrote: > Signed-off-by: Bhaskar Upadhaya <Bhaskar.Upadhaya@nxp.com> > --- > Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > index 41e9f55..5755697 100644 > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt > @@ -15,6 +15,7 @@ Required properties: > - compatible: should contain the platform identifier such as: > "fsl,ls1021a-pcie", "snps,dw-pcie" > "fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie" > + "fsl,ls1012a-pcie", "fsl,ls1043a-pcie" ,"snps,dw-pcie" Whitespace doesn't match. Why are you listing both ls1012a and ls1043a together? Are they 100% compatible? Why are we updating all these bindings every time we come out with a new chip, rather than having a <chip> pattern like we did in other bindings? -Scott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt index 41e9f55..5755697 100644 --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt @@ -15,6 +15,7 @@ Required properties: - compatible: should contain the platform identifier such as: "fsl,ls1021a-pcie", "snps,dw-pcie" "fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie" + "fsl,ls1012a-pcie", "fsl,ls1043a-pcie" ,"snps,dw-pcie" - reg: base addresses and lengths of the PCIe controller - interrupts: A list of interrupt outputs of the controller. Must contain an entry for each entry in the interrupt-names property.
Signed-off-by: Bhaskar Upadhaya <Bhaskar.Upadhaya@nxp.com> --- Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 + 1 file changed, 1 insertion(+)