Patchwork mtd-utils: sys_errmsg: optimize indentation

login
register
mail settings
Submitter Mike Frysinger
Date Oct. 1, 2010, 5:39 a.m.
Message ID <1285911589-9323-1-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/66305/
State Accepted, archived
Commit 90ebf6f62007726bea619dcb5beb6e858bedfd6d
Headers show

Comments

Mike Frysinger - Oct. 1, 2010, 5:39 a.m.
Rather than do a for loop and output 1 space at a time, let the printf
code take care of indenting the string based on the constant length.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 include/common.h |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

Patch

diff --git a/include/common.h b/include/common.h
index 9f49f55..6684a73 100644
--- a/include/common.h
+++ b/include/common.h
@@ -65,11 +65,9 @@  extern "C" {
 /* System error messages */
 #define sys_errmsg(fmt, ...)  ({                                            \
 	int _err = errno;                                                   \
-	size_t _i;                                                          \
 	errmsg(fmt, ##__VA_ARGS__);                                         \
-	for (_i = 0; _i < sizeof(PROGRAM_NAME) + 1; _i++)                   \
-		fprintf(stderr, " ");                                       \
-	fprintf(stderr, "error %d (%s)\n", _err, strerror(_err));           \
+	fprintf(stderr, "%*serror %d (%s)\n", (int)sizeof(PROGRAM_NAME) + 1,\
+		"", _err, strerror(_err));                                  \
 	-1;                                                                 \
 })
 #define sys_errmsg_die(fmt, ...) do {                                       \