diff mbox

net: dsa: bcm_sf2: Utilize mask clear/set helpers in bcm_sf2_intr_disable

Message ID 1472163645-7058-1-git-send-email-fainelli@broadcom.com
State Superseded, archived
Headers show

Commit Message

Florian Fainelli Aug. 25, 2016, 10:20 p.m. UTC 
From: Florian Fainelli <florian.fainelli@broadcom.com>

And while at it, remove the unecessary writing of zeroes to the CPU_MASK_CLEAR
register since it has no functional use.

refs #SWLINUX-4144

Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
---
 drivers/net/dsa/bcm_sf2.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Florian Fainelli Aug. 25, 2016, 10:23 p.m. UTC | #1 
On 08/25/2016 03:20 PM, Florian Fainelli wrote:
> From: Florian Fainelli <florian.fainelli@broadcom.com>
> 
> And while at it, remove the unecessary writing of zeroes to the CPU_MASK_CLEAR
> register since it has no functional use.
> 
> refs #SWLINUX-4144
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>

I will resend that, this taken from an internal tree as-is, sorry about
that.
diff mbox

Patch

diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
index 30c662adf2cc..706a19a672f3 100644
--- a/drivers/net/dsa/bcm_sf2.c
+++ b/drivers/net/dsa/bcm_sf2.c
@@ -670,12 +670,10 @@  static int bcm_sf2_sw_rst(struct bcm_sf2_priv *priv)
 
 static void bcm_sf2_intr_disable(struct bcm_sf2_priv *priv)
 {
-	intrl2_0_writel(priv, 0xffffffff, INTRL2_CPU_MASK_SET);
+	intrl2_0_mask_set(priv, 0xffffffff);
 	intrl2_0_writel(priv, 0xffffffff, INTRL2_CPU_CLEAR);
-	intrl2_0_writel(priv, 0, INTRL2_CPU_MASK_CLEAR);
-	intrl2_1_writel(priv, 0xffffffff, INTRL2_CPU_MASK_SET);
+	intrl2_1_mask_set(priv, 0xffffffff);
 	intrl2_1_writel(priv, 0xffffffff, INTRL2_CPU_CLEAR);
-	intrl2_1_writel(priv, 0, INTRL2_CPU_MASK_CLEAR);
 }
 
 static int bcm_sf2_sw_setup(struct dsa_switch *ds)