diff mbox

[U-Boot,v3,10/11] ti_armv7_common: Disable Falcon Mode on HS devices

Message ID 20160825214541.22896-11-afd@ti.com
State Accepted
Commit e95b9b4437bcc31107bdc3b7625bd7c11ad24ef7
Delegated to: Tom Rini
Headers show

Commit Message

Andrew Davis Aug. 25, 2016, 9:45 p.m. UTC
Authentication of images in Falcon Mode is not supported. Do not enable
SPL_OS_BOOT when TI_SECURE_DEVICE is enabled. This prevents attempting
to directly load kernel images which will fail, for security reasons,
on HS devices, the board is locked if a non-authenticatable image load
is attempted, so we disable attempting Falcon Mode.

Signed-off-by: Andrew F. Davis <afd@ti.com>
---
 include/configs/ti_armv7_common.h | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

Comments

Tom Rini Aug. 26, 2016, 9:30 p.m. UTC | #1
On Thu, Aug 25, 2016 at 04:45:40PM -0500, Andrew F. Davis wrote:

> Authentication of images in Falcon Mode is not supported. Do not enable
> SPL_OS_BOOT when TI_SECURE_DEVICE is enabled. This prevents attempting
> to directly load kernel images which will fail, for security reasons,
> on HS devices, the board is locked if a non-authenticatable image load
> is attempted, so we disable attempting Falcon Mode.
> 
> Signed-off-by: Andrew F. Davis <afd@ti.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
diff mbox

Patch

diff --git a/include/configs/ti_armv7_common.h b/include/configs/ti_armv7_common.h
index 9f947ee..949b6d1 100644
--- a/include/configs/ti_armv7_common.h
+++ b/include/configs/ti_armv7_common.h
@@ -198,16 +198,21 @@ 
 
 /*
  * Our platforms make use of SPL to initalize the hardware (primarily
- * memory) enough for full U-Boot to be loaded.  We also support Falcon
- * Mode so that the Linux kernel can be booted directly from SPL
- * instead, if desired.  We make use of the general SPL framework found
- * under common/spl/.  Given our generally common memory map, we set a
- * number of related defaults and sizes here.
+ * memory) enough for full U-Boot to be loaded. We make use of the general
+ * SPL framework found under common/spl/.  Given our generally common memory
+ * map, we set a number of related defaults and sizes here.
  */
 #if !defined(CONFIG_NOR_BOOT) && \
 	!(defined(CONFIG_QSPI_BOOT) && defined(CONFIG_AM43XX))
 #define CONFIG_SPL_FRAMEWORK
+
+/*
+ * We also support Falcon Mode so that the Linux kernel can be booted
+ * directly from SPL. This is not currently available on HS devices.
+ */
+#if !defined(CONFIG_TI_SECURE_DEVICE)
 #define CONFIG_SPL_OS_BOOT
+#endif
 
 /*
  * Place the image at the start of the ROM defined image space (per