Patchwork [00/44] Merge changes from Graphite branch to trunk

login
register
mail settings
Submitter Sebastian Pop
Date Sept. 30, 2010, 9:28 p.m.
Message ID <AANLkTi=BVRpu71Rm6aRPuP19c7WRmw2U3QhPXTsCARzy@mail.gmail.com>
Download mbox | patch
Permalink /patch/66275/
State New
Headers show

Comments

Sebastian Pop - Sept. 30, 2010, 9:28 p.m.
On Thu, Sep 30, 2010 at 13:04, Sebastian Pop <sebpop@gmail.com> wrote:
> Hi,
>
> This patch set merges to trunk some of the changes from the Graphite
> branch.
>
> The new scop detection is not robust enough and is thus not merged to
> trunk.  I also decided to not enable the write to disk of the OpenSCoP
> and CLooG formats: the functionality will be included in trunk, but is
> not enabled by any flag and not documented.
>
> I am bootstrapping and testing these patches together on amd64-linux,
> and I will commit to trunk after testing.
>

Committed to trunk r164770 to r164814.
I also adjusted a failing testcase as attached.

Sebastian Pop
--
AMD / Open Source Compiler Engineering / GNU Tools
Jack Howarth - Sept. 30, 2010, 10:04 p.m.
On Thu, Sep 30, 2010 at 04:28:36PM -0500, Sebastian Pop wrote:
> On Thu, Sep 30, 2010 at 13:04, Sebastian Pop <sebpop@gmail.com> wrote:
> > Hi,
> >
> > This patch set merges to trunk some of the changes from the Graphite
> > branch.
> >
> > The new scop detection is not robust enough and is thus not merged to
> > trunk.  I also decided to not enable the write to disk of the OpenSCoP
> > and CLooG formats: the functionality will be included in trunk, but is
> > not enabled by any flag and not documented.
> >
> > I am bootstrapping and testing these patches together on amd64-linux,
> > and I will commit to trunk after testing.
> >
> 
> Committed to trunk r164770 to r164814.
> I also adjusted a failing testcase as attached.
> 
> Sebastian Pop

Sebastian,
    What are the prospects for getting PR40979 fixed?
              Jack

> --
> AMD / Open Source Compiler Engineering / GNU Tools

> From 8afca39d3cd92546137819f7e33065b7c32131ca Mon Sep 17 00:00:00 2001
> From: spop <spop@138bc75d-0d04-0410-961f-82ee72b054a4>
> Date: Thu, 30 Sep 2010 21:22:16 +0000
> Subject: [PATCH] Adjust failing testsuite pattern.
> 
> 2010-09-30  Sebastian Pop  <sebastian.pop@amd.com>
> 
> 	* testsuite/libgomp.graphite/force-parallel-1.c: Adjust.
> 
> git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@164814 138bc75d-0d04-0410-961f-82ee72b054a4
> ---
>  libgomp/ChangeLog                                  |    4 ++++
>  .../testsuite/libgomp.graphite/force-parallel-1.c  |    2 +-
>  2 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog
> index 7de7df6..84845cb 100644
> --- a/libgomp/ChangeLog
> +++ b/libgomp/ChangeLog
> @@ -1,3 +1,7 @@
> +2010-09-30  Sebastian Pop  <sebastian.pop@amd.com>
> +
> +	* testsuite/libgomp.graphite/force-parallel-1.c: Adjust.
> +
>  2010-09-23  Tobias Burnus  <burnus@net-b.de>
>  
>  	* libgomp.texi (omp_get_nested, omp_set_nested, omp_set_dynamic):
> diff --git a/libgomp/testsuite/libgomp.graphite/force-parallel-1.c b/libgomp/testsuite/libgomp.graphite/force-parallel-1.c
> index 1ad4b41..7f043d8 100644
> --- a/libgomp/testsuite/libgomp.graphite/force-parallel-1.c
> +++ b/libgomp/testsuite/libgomp.graphite/force-parallel-1.c
> @@ -23,7 +23,7 @@ int main(void)
>  }
>  
>  /* Check that parallel code generation part make the right answer.  */
> -/* { dg-final { scan-tree-dump-times "1 loops carried no dependency" 1 "graphite" } } */
> +/* { dg-final { scan-tree-dump-times "1 loops carried no dependency" 2 "graphite" } } */
>  /* { dg-final { cleanup-tree-dump "graphite" } } */
>  /* { dg-final { scan-tree-dump-times "loopfn" 5 "optimized" } } */
>  /* { dg-final { cleanup-tree-dump "parloops" } } */
> -- 
> 1.7.0.4
>
Sebastian Pop - Sept. 30, 2010, 10:18 p.m.
On Thu, Sep 30, 2010 at 17:04, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
>    What are the prospects for getting PR40979 fixed?

> PR40979: induct benchmark 60% slower when compiled with -fgraphite-identity

Is this still a problem?  Could you try to measure the perf with trunk?

Thanks,
Sebastian

Patch

From 8afca39d3cd92546137819f7e33065b7c32131ca Mon Sep 17 00:00:00 2001
From: spop <spop@138bc75d-0d04-0410-961f-82ee72b054a4>
Date: Thu, 30 Sep 2010 21:22:16 +0000
Subject: [PATCH] Adjust failing testsuite pattern.

2010-09-30  Sebastian Pop  <sebastian.pop@amd.com>

	* testsuite/libgomp.graphite/force-parallel-1.c: Adjust.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@164814 138bc75d-0d04-0410-961f-82ee72b054a4
---
 libgomp/ChangeLog                                  |    4 ++++
 .../testsuite/libgomp.graphite/force-parallel-1.c  |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog
index 7de7df6..84845cb 100644
--- a/libgomp/ChangeLog
+++ b/libgomp/ChangeLog
@@ -1,3 +1,7 @@ 
+2010-09-30  Sebastian Pop  <sebastian.pop@amd.com>
+
+	* testsuite/libgomp.graphite/force-parallel-1.c: Adjust.
+
 2010-09-23  Tobias Burnus  <burnus@net-b.de>
 
 	* libgomp.texi (omp_get_nested, omp_set_nested, omp_set_dynamic):
diff --git a/libgomp/testsuite/libgomp.graphite/force-parallel-1.c b/libgomp/testsuite/libgomp.graphite/force-parallel-1.c
index 1ad4b41..7f043d8 100644
--- a/libgomp/testsuite/libgomp.graphite/force-parallel-1.c
+++ b/libgomp/testsuite/libgomp.graphite/force-parallel-1.c
@@ -23,7 +23,7 @@  int main(void)
 }
 
 /* Check that parallel code generation part make the right answer.  */
-/* { dg-final { scan-tree-dump-times "1 loops carried no dependency" 1 "graphite" } } */
+/* { dg-final { scan-tree-dump-times "1 loops carried no dependency" 2 "graphite" } } */
 /* { dg-final { cleanup-tree-dump "graphite" } } */
 /* { dg-final { scan-tree-dump-times "loopfn" 5 "optimized" } } */
 /* { dg-final { cleanup-tree-dump "parloops" } } */
-- 
1.7.0.4