From patchwork Thu Sep 30 20:56:12 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [11/19] QMP: Simplify do_info_commands() X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 66268 Message-Id: <1285880180-29724-12-git-send-email-lcapitulino@redhat.com> To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, armbru@redhat.com Date: Thu, 30 Sep 2010 17:56:12 -0300 From: Luiz Capitulino List-Id: qemu-devel.nongnu.org We now iterate over QMP's dispatch tables, no need to check for QMP-only handlers anymore. Signed-off-by: Luiz Capitulino --- monitor.c | 13 ++++--------- 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/monitor.c b/monitor.c index 7cb66df..dbf6e18 100644 --- a/monitor.c +++ b/monitor.c @@ -746,18 +746,13 @@ static void do_info_commands(Monitor *mon, QObject **ret_data) cmd_list = qlist_new(); for (cmd = qmp_cmds; cmd->name != NULL; cmd++) { - if (monitor_handler_ported(cmd) && !monitor_cmd_user_only(cmd) && - !compare_cmd(cmd->name, "info")) { - qlist_append_obj(cmd_list, get_cmd_dict(cmd->name)); - } + qlist_append_obj(cmd_list, get_cmd_dict(cmd->name)); } for (cmd = qmp_query_cmds; cmd->name != NULL; cmd++) { - if (monitor_handler_ported(cmd) && !monitor_cmd_user_only(cmd)) { - char buf[128]; - snprintf(buf, sizeof(buf), "query-%s", cmd->name); - qlist_append_obj(cmd_list, get_cmd_dict(buf)); - } + char buf[128]; + snprintf(buf, sizeof(buf), "query-%s", cmd->name); + qlist_append_obj(cmd_list, get_cmd_dict(buf)); } *ret_data = QOBJECT(cmd_list);