| Message ID | 1472010404-334-5-git-send-email-kever.yang@rock-chips.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Glass |
| Headers | show |
Hi Kever, On Aug 23, 2016 20:48, "Kever Yang" <kever.yang@rock-chips.com> wrote: > > To support fastboot, we need to enable the controller first. > rk3399 is using dwc3 as usb device controller, this patch enable > the configs for dwc3 gadget. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > Reviewed-by: Simon Glass <sjg@chromium.org> > --- > > Changes in v2: > - remove config for USB2PHY UTMI BITS > > include/configs/rk3399_common.h | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h > index 6875308..fcd1700 100644 > --- a/include/configs/rk3399_common.h > +++ b/include/configs/rk3399_common.h > @@ -27,6 +27,26 @@ > > #define CONFIG_SYS_BOOTM_LEN (64 << 20) /* 64M */ > > +/* usb device */ > +#define CONFIG_USB_DWC3 > +#define CONFIG_USB_DWC3_GADGET > +#define CONFIG_USB_GADGET > +#define CONFIG_USB_GADGET_DUALSPEED > +#define CONFIG_USB_GADGET_VBUS_DRAW 0 > + > +/* fastboot */ > +#define CONFIG_CMD_FASTBOOT > +#define CONFIG_USB_FUNCTION_FASTBOOT > +#define CONFIG_FASTBOOT_FLASH > +#define CONFIG_FASTBOOT_FLASH_MMC_DEV 1 /* eMMC */ > +#define CONFIG_FASTBOOT_BUF_ADDR CONFIG_SYS_LOAD_ADDR > +#define CONFIG_FASTBOOT_BUF_SIZE 0x08000000 > + > +#define CONFIG_USB_GADGET_DOWNLOAD > +#define CONFIG_G_DNL_MANUFACTURER "Rockchip" > +#define CONFIG_G_DNL_VENDOR_NUM 0x2207 > +#define CONFIG_G_DNL_PRODUCT_NUM 0x330a > + FYI - All of these new defines are now in Kconfig.... Thanks, Steve > /* MMC/SD IP block */ > #define CONFIG_MMC > #define CONFIG_GENERIC_MMC > -- > 1.9.1 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot
Hi Steve, On 08/28/2016 06:22 AM, Steve Rae wrote: > > Hi Kever, > > On Aug 23, 2016 20:48, "Kever Yang" <kever.yang@rock-chips.com > <mailto:kever.yang@rock-chips.com>> wrote: > > > > To support fastboot, we need to enable the controller first. > > rk3399 is using dwc3 as usb device controller, this patch enable > > the configs for dwc3 gadget. > > > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com > <mailto:kever.yang@rock-chips.com>> > > Reviewed-by: Simon Glass <sjg@chromium.org <mailto:sjg@chromium.org>> > > --- > > > > Changes in v2: > > - remove config for USB2PHY UTMI BITS > > > > include/configs/rk3399_common.h | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/include/configs/rk3399_common.h > b/include/configs/rk3399_common.h > > index 6875308..fcd1700 100644 > > --- a/include/configs/rk3399_common.h > > +++ b/include/configs/rk3399_common.h > > @@ -27,6 +27,26 @@ > > > > #define CONFIG_SYS_BOOTM_LEN (64 << 20) /* 64M */ > > > > +/* usb device */ > > +#define CONFIG_USB_DWC3 > > +#define CONFIG_USB_DWC3_GADGET > > +#define CONFIG_USB_GADGET > > +#define CONFIG_USB_GADGET_DUALSPEED > > +#define CONFIG_USB_GADGET_VBUS_DRAW 0 > > + > > +/* fastboot */ > > +#define CONFIG_CMD_FASTBOOT > > +#define CONFIG_USB_FUNCTION_FASTBOOT > > +#define CONFIG_FASTBOOT_FLASH > > +#define CONFIG_FASTBOOT_FLASH_MMC_DEV 1 /* eMMC */ > > +#define CONFIG_FASTBOOT_BUF_ADDR CONFIG_SYS_LOAD_ADDR > > +#define CONFIG_FASTBOOT_BUF_SIZE 0x08000000 > > + > > +#define CONFIG_USB_GADGET_DOWNLOAD > > +#define CONFIG_G_DNL_MANUFACTURER "Rockchip" > > +#define CONFIG_G_DNL_VENDOR_NUM 0x2207 > > +#define CONFIG_G_DNL_PRODUCT_NUM 0x330a > > + > FYI - All of these new defines are now in Kconfig.... > Thanks for point out, I will rebase this patch and move these defines into Kconfig. Regards, - Kever > > Thanks, Steve > > > /* MMC/SD IP block */ > > #define CONFIG_MMC > > #define CONFIG_GENERIC_MMC > > -- > > 1.9.1 > > > > _______________________________________________ > > U-Boot mailing list > > U-Boot@lists.denx.de <mailto:U-Boot@lists.denx.de> > > http://lists.denx.de/mailman/listinfo/u-boot >
diff --git a/include/configs/rk3399_common.h b/include/configs/rk3399_common.h index 6875308..fcd1700 100644 --- a/include/configs/rk3399_common.h +++ b/include/configs/rk3399_common.h @@ -27,6 +27,26 @@ #define CONFIG_SYS_BOOTM_LEN (64 << 20) /* 64M */ +/* usb device */ +#define CONFIG_USB_DWC3 +#define CONFIG_USB_DWC3_GADGET +#define CONFIG_USB_GADGET +#define CONFIG_USB_GADGET_DUALSPEED +#define CONFIG_USB_GADGET_VBUS_DRAW 0 + +/* fastboot */ +#define CONFIG_CMD_FASTBOOT +#define CONFIG_USB_FUNCTION_FASTBOOT +#define CONFIG_FASTBOOT_FLASH +#define CONFIG_FASTBOOT_FLASH_MMC_DEV 1 /* eMMC */ +#define CONFIG_FASTBOOT_BUF_ADDR CONFIG_SYS_LOAD_ADDR +#define CONFIG_FASTBOOT_BUF_SIZE 0x08000000 + +#define CONFIG_USB_GADGET_DOWNLOAD +#define CONFIG_G_DNL_MANUFACTURER "Rockchip" +#define CONFIG_G_DNL_VENDOR_NUM 0x2207 +#define CONFIG_G_DNL_PRODUCT_NUM 0x330a + /* MMC/SD IP block */ #define CONFIG_MMC #define CONFIG_GENERIC_MMC