diff mbox

[-next] vmxnet3: fix non static symbol warning

Message ID 1471964718-32543-1-git-send-email-weiyj.lk@gmail.com
State Changes Requested, archived
Delegated to: David Miller
Headers show

Commit Message

Wei Yongjun Aug. 23, 2016, 3:05 p.m. UTC
From: Wei Yongjun <weiyongjun1@huawei.com>

Fixes the following sparse warning:

drivers/net/vmxnet3/vmxnet3_drv.c:1645:1: warning:
 symbol 'vmxnet3_rq_destroy_all_rxdataring' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shrikrishna Khare Aug. 23, 2016, 5:13 p.m. UTC | #1
On Tue, 23 Aug 2016, Wei Yongjun wrote:

> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/net/vmxnet3/vmxnet3_drv.c:1645:1: warning:
> symbol 'vmxnet3_rq_destroy_all_rxdataring' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Thanks for catching and fixing this. The fix looks good. But, could you 
please send this against net tree instead of net-next?


> ---
> drivers/net/vmxnet3/vmxnet3_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 4244b9d..2fd93b4 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -1641,7 +1641,7 @@ static void vmxnet3_rq_destroy(struct vmxnet3_rx_queue *rq,
> 	}
> }
>
> -void
> +static void
> vmxnet3_rq_destroy_all_rxdataring(struct vmxnet3_adapter *adapter)
> {
> 	int i;
>
>
>
>
diff mbox

Patch

diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
index 4244b9d..2fd93b4 100644
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -1641,7 +1641,7 @@  static void vmxnet3_rq_destroy(struct vmxnet3_rx_queue *rq,
 	}
 }
 
-void
+static void
 vmxnet3_rq_destroy_all_rxdataring(struct vmxnet3_adapter *adapter)
 {
 	int i;