| Message ID | 84eg5gwhfm.wl-Peter.Chubb@data61.csiro.au |
|---|---|
| State | Superseded |
| Delegated to: | Tom Warren |
| Headers | show |
On 08/22/2016 04:46 PM, Peter Chubb wrote: > > U-Boot's console buffer size needs to be bigger to allow the > default image on NVIDIA's Linux4Tegra to boot. > > Otherwise one sees: > bootarg overflow 602+0+0+1 > 512 > on the console, and the board refuses to boot. This is probably fine, but ... > diff --git a/include/configs/tegra-common.h b/include/configs/tegra-common.h ... > -#define CONFIG_SYS_CBSIZE (256 * 2) /* Console I/O Buffer Size */ > +#define CONFIG_SYS_CBSIZE (256 * 3) /* Console I/O Buffer Size */ ... "3" feels odd since it's not a power of 2:-) Perhaps you could try cherry-picking the following commit from our L4T U-Boot and if it works for you, submit that instead. That would also reduce the mainline<->L4T U-Boot delta. > http://nv-tegra.nvidia.com/gitweb/?p=3rdparty/u-boot.git;a=commit;h=d03e1b861b9eaaf13fa37a8d4251d78b3814eaaf git remote add nv-tegra-u-boot \ git://nv-tegra.nvidia.com/3rdparty/u-boot.git git fetch nv-tegra-u-boot git cherry-pick -s 81df4b5097ef72b9e1565c8f3fb45a9c14a9984e
>>>>> "Tom" == Tom Warren <TWarren@nvidia.com> writes:
Tom> Peter, It appears that this got rolled into 'ARM: tegra: increase
Tom> console buffer size and sys args num', so I'm going to mark it as
Tom> Superseded in my Patchwork queue.
Yes, Stephen asked me to cherrypick instead from the tegra u-boot
repo, and I did and submitted it.
Tom> What's the status of the 'increase console buffer size and sys
Tom> args num' patch? I've currently got it marked as 'Changes
Tom> Requested'.
Maybe you missed it, but the changed version was sent to the U-Boot
list. I'll send it again if need be. Message ID:
20160825011915.4767-1-Peter.Chubb@data61.csiro.au
Peter C
On 09/01/2016 04:53 PM, Peter.Chubb@data61.csiro.au wrote: >>>>>> "Tom" == Tom Warren <TWarren@nvidia.com> writes: > > Tom> Peter, It appears that this got rolled into 'ARM: tegra: increase > Tom> console buffer size and sys args num', so I'm going to mark it as > Tom> Superseded in my Patchwork queue. > > Yes, Stephen asked me to cherrypick instead from the tegra u-boot > repo, and I did and submitted it. > > Tom> What's the status of the 'increase console buffer size and sys > Tom> args num' patch? I've currently got it marked as 'Changes > Tom> Requested'. > > Maybe you missed it, but the changed version was sent to the U-Boot > list. I'll send it again if need be. Message ID: > 20160825011915.4767-1-Peter.Chubb@data61.csiro.au I don't have that message either, and Google can't find it.
>>>>> "Stephen" == Stephen Warren <swarren@wwwdotorg.org> writes:
Stephen> I don't have that message either, and Google can't find it.
I'll send it again.
Thanks.
diff --git a/include/configs/tegra-common.h b/include/configs/tegra-common.h index 7b0940a..8e874d3 100644 --- a/include/configs/tegra-common.h +++ b/include/configs/tegra-common.h @@ -76,7 +76,7 @@ * Increasing the size of the IO buffer as default nfsargs size is more * than 256 and so it is not possible to edit it */ -#define CONFIG_SYS_CBSIZE (256 * 2) /* Console I/O Buffer Size */ +#define CONFIG_SYS_CBSIZE (256 * 3) /* Console I/O Buffer Size */ /* Print Buffer Size */ #define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + \ sizeof(CONFIG_SYS_PROMPT) + 16)
U-Boot's console buffer size needs to be bigger to allow the default image on NVIDIA's Linux4Tegra to boot. Otherwise one sees: bootarg overflow 602+0+0+1 > 512 on the console, and the board refuses to boot. Signed-off-by: Peter Chubb <peter.chubb@data61.csiro.au> --- include/configs/tegra-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)